github
/
portainer
mirror of https://github.com/portainer/portainer
1
0
Fork 0
Code Issues Releases Wiki Activity

fix(app/update_schedule): create schedule performance issues at scale (#1002)

release/2.33.0-rc1
LP B 2025-08-12 16:50:11 +02:00 committed by GitHub
parent 3ee20863d6
commit 5f6fa4d79f
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/endpoints/utils.go
View File

@ -36,7 +36,13 @@ func HasDirectConnectivity(endpoint *portainer.Endpoint) bool {
// IsNewerThan225 returns true if the agent version is newer than 2.25.0 // IsNewerThan225 returns true if the agent version is newer than 2.25.0
// this is used to check if the agent is compatible with the new diagnostics feature // this is used to check if the agent is compatible with the new diagnostics feature
func IsNewerThan225(agentVersion string) bool { func IsNewerThan225(agentVersion string) bool {
v1, _ := version.NewVersion(agentVersion) v1, err := version.NewVersion(agentVersion)
v2, _ := version.NewVersion("2.25.0") if err != nil || v1 == nil {
return false
}
v2, err := version.NewVersion("2.25.0")
if err != nil || v2 == nil {
return false
}
return v1.GreaterThanOrEqual(v2) return v1.GreaterThanOrEqual(v2)
} }

5
pkg/endpoints/utils_test.go
View File

@ -251,6 +251,11 @@ func TestIsNewerThan225(t *testing.T) {
version: "2.24.0", version: "2.24.0",
expected: false, expected: false,
}, },
{
name: "Not a version",
version: "NotAVersion",
expected: false,
},
} }
for _, tt := range tests { for _, tt := range tests {