From f2cd33e831780dd81c2610193cd116613afb5a7a Mon Sep 17 00:00:00 2001 From: Chaim Lev-Ari Date: Thu, 20 Dec 2018 17:37:35 +0200 Subject: [PATCH 1/2] feat(container-creation): call stopAndRename after pullImage (#2564) * refactor(container): remove bind of function --- .../views/containers/create/createContainerController.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/docker/views/containers/create/createContainerController.js b/app/docker/views/containers/create/createContainerController.js index 2498c4245..44f3af9dd 100644 --- a/app/docker/views/containers/create/createContainerController.js +++ b/app/docker/views/containers/create/createContainerController.js @@ -659,7 +659,7 @@ function ($q, $scope, $state, $timeout, $transition$, $filter, Container, Contai } $scope.state.actionInProgress = true; return pullImageIfNeeded() - .then(stopAndRenameContainer(oldContainer)) + .then(stopAndRenameContainer) .then(createNewContainer) .then(applyResourceControl) .then(connectToExtraNetworks) @@ -695,7 +695,7 @@ function ($q, $scope, $state, $timeout, $transition$, $filter, Container, Contai } } - function stopAndRenameContainer(oldContainer) { + function stopAndRenameContainer() { if (!oldContainer) { return $q.when(); } From 463b379876014041c5f2b2c1382f19d827a53d75 Mon Sep 17 00:00:00 2001 From: Anthony Lapenna Date: Thu, 27 Dec 2018 09:03:13 +0100 Subject: [PATCH 2/2] docs(README): remove broken badges and links --- README.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/README.md b/README.md index cee536856..3a8035de2 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,6 @@ [![Documentation Status](https://readthedocs.org/projects/portainer/badge/?version=stable)](http://portainer.readthedocs.io/en/stable/?badge=stable) [![Build Status](https://semaphoreci.com/api/v1/portainer/portainer-ci/branches/develop/badge.svg)](https://semaphoreci.com/portainer/portainer-ci) [![Code Climate](https://codeclimate.com/github/portainer/portainer/badges/gpa.svg)](https://codeclimate.com/github/portainer/portainer) -[![Slack](https://portainer.io/slack/badge.svg)](https://portainer.io/slack/) [![Gitter](https://badges.gitter.im/portainer/Lobby.svg)](https://gitter.im/portainer/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge) [![Donate](https://img.shields.io/badge/Donate-PayPal-green.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=YHXZJQNJQ36H6) @@ -20,8 +19,6 @@ ## Demo - - You can try out the public demo instance: http://demo.portainer.io/ (login with the username **admin** and the password **tryportainer**). Please note that the public demo cluster is **reset every 15min**.