From 45cada05d572961e9006b1505709bf12a35215fc Mon Sep 17 00:00:00 2001
From: Chaim Lev-Ari <chiptus@users.noreply.github.com>
Date: Mon, 24 Aug 2020 05:54:02 +0300
Subject: [PATCH] feat(custom-templates): validate unique template name (#4264)

* feat(custom-template): check for name uniqueness

* feat(custom-templates): check unique name on edit
---
 .../createCustomTemplateViewController.js     | 17 ++++++++++++++++-
 .../editCustomTemplateViewController.js       | 19 ++++++++++++++++++-
 2 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/app/portainer/views/custom-templates/create-custom-template-view/createCustomTemplateViewController.js b/app/portainer/views/custom-templates/create-custom-template-view/createCustomTemplateViewController.js
index bfa4e9893..494f90e5c 100644
--- a/app/portainer/views/custom-templates/create-custom-template-view/createCustomTemplateViewController.js
+++ b/app/portainer/views/custom-templates/create-custom-template-view/createCustomTemplateViewController.js
@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import { AccessControlFormData } from 'Portainer/components/accessControlForm/porAccessControlFormModel';
 
 class CreateCustomTemplateViewController {
@@ -29,6 +30,7 @@ class CreateCustomTemplateViewController {
       fromStack: false,
       loading: true,
     };
+    this.templates = [];
 
     this.createCustomTemplate = this.createCustomTemplate.bind(this);
     this.createCustomTemplateAsync = this.createCustomTemplateAsync.bind(this);
@@ -73,7 +75,7 @@ class CreateCustomTemplateViewController {
       this.Notifications.success('Custom template successfully created');
       this.$state.go('docker.templates.custom');
     } catch (err) {
-      this.Notifications.error('Deployment error', err, 'Unable to create custom template');
+      this.Notifications.error('Failure', err, 'A template with the same name already exists');
     } finally {
       this.state.actionInProgress = false;
     }
@@ -87,6 +89,13 @@ class CreateCustomTemplateViewController {
       return false;
     }
 
+    const title = this.formValues.Title;
+    const isNotUnique = _.some(this.templates, (template) => template.Title === title);
+    if (isNotUnique) {
+      this.state.formValidationError = 'A template with the same name already exists';
+      return false;
+    }
+
     const isAdmin = this.Authentication.isAdmin();
     const accessControlData = this.formValues.AccessControlData;
     const error = this.FormValidator.validateAccessControl(accessControlData, isAdmin);
@@ -145,6 +154,12 @@ class CreateCustomTemplateViewController {
       this.formValues.Type = +type;
     }
 
+    try {
+      this.templates = await this.CustomTemplateService.customTemplates();
+    } catch (err) {
+      this.Notifications.error('Failure loading', err, 'Failed loading custom templates');
+    }
+
     this.state.loading = false;
   }
 }
diff --git a/app/portainer/views/custom-templates/edit-custom-template-view/editCustomTemplateViewController.js b/app/portainer/views/custom-templates/edit-custom-template-view/editCustomTemplateViewController.js
index f06874b40..aaba57872 100644
--- a/app/portainer/views/custom-templates/edit-custom-template-view/editCustomTemplateViewController.js
+++ b/app/portainer/views/custom-templates/edit-custom-template-view/editCustomTemplateViewController.js
@@ -1,3 +1,5 @@
+import _ from 'lodash';
+
 import { AccessControlFormData } from 'Portainer/components/accessControlForm/porAccessControlFormModel';
 import { ResourceControlViewModel } from 'Portainer/models/resourceControl/resourceControl';
 
@@ -10,6 +12,7 @@ class EditCustomTemplateViewController {
     this.state = {
       formValidationError: '',
     };
+    this.templates = [];
 
     this.getTemplate = this.getTemplate.bind(this);
     this.getTemplateAsync = this.getTemplateAsync.bind(this);
@@ -44,6 +47,14 @@ class EditCustomTemplateViewController {
       return false;
     }
 
+    const title = this.formValues.Title;
+    const id = this.$state.params.id;
+    const isNotUnique = _.some(this.templates, (template) => template.Title === title && template.Id != id);
+    if (isNotUnique) {
+      this.state.formValidationError = `A template with the name ${title} already exists`;
+      return false;
+    }
+
     const isAdmin = this.Authentication.isAdmin();
     const accessControlData = this.formValues.AccessControlData;
     const error = this.FormValidator.validateAccessControl(accessControlData, isAdmin);
@@ -85,8 +96,14 @@ class EditCustomTemplateViewController {
     this.formValues.fileContent = cm.getValue();
   }
 
-  $onInit() {
+  async $onInit() {
     this.getTemplate();
+
+    try {
+      this.templates = await this.CustomTemplateService.customTemplates();
+    } catch (err) {
+      this.Notifications.error('Failure loading', err, 'Failed loading custom templates');
+    }
   }
 }