From 42497ab60cfcf46f39817853fe5918e4de5b59ee Mon Sep 17 00:00:00 2001
From: Chaim Lando <chiptus@gmail.com>
Date: Wed, 12 Sep 2018 10:16:28 +0300
Subject: [PATCH] feat(host-details): hide missing info

---
 .../engine-details-panel.html                  | 10 +++++-----
 .../host-details-panel/host-details-panel.html | 18 +++++++++---------
 .../swarm-node-details-panel-controller.js     |  2 +-
 .../swarm-node-details-panel.html              |  2 +-
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel.html b/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel.html
index d9a9691cc..76e87e6a9 100644
--- a/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel.html
+++ b/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel.html
@@ -5,19 +5,19 @@
       <rd-widget-body classes="no-padding">
         <table class="table">
           <tbody>
-            <tr>
+            <tr ng-if="$ctrl.engine.releaseVersion">
               <td>Version</td>
-              <td>{{ $ctrl.engine.releaseVersion }} (API: {{ $ctrl.engine.apiVersion }})</td>
+              <td>{{ $ctrl.engine.releaseVersion }} <span ng-if="$ctrl.engine.apiVersion">(API: {{ $ctrl.engine.apiVersion }})</span></td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.engine.rootDirectory">
               <td>Root directory</td>
               <td>{{ $ctrl.engine.rootDirectory }}</td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.engine.storageDriver">
               <td>Storage Driver</td>
               <td>{{ $ctrl.engine.storageDriver }}</td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.engine.loggingDriver">
               <td>Logging Driver</td>
               <td>{{ $ctrl.engine.loggingDriver }}</td>
             </tr>
diff --git a/app/docker/components/host-view-panels/host-details-panel/host-details-panel.html b/app/docker/components/host-view-panels/host-details-panel/host-details-panel.html
index 8c1bae1ca..6713ae681 100644
--- a/app/docker/components/host-view-panels/host-details-panel/host-details-panel.html
+++ b/app/docker/components/host-view-panels/host-details-panel/host-details-panel.html
@@ -5,38 +5,38 @@
       <rd-widget-body classes="no-padding">
         <table class="table">
           <tbody>
-            <tr>
+            <tr ng-if="$ctrl.host.name">
               <td>Hostname</td>
               <td>{{ $ctrl.host.name }}</td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.host.os">
               <td>OS Information</td>
               <td>{{ $ctrl.host.os.type }} {{$ctrl.host.os.arch}} {{$ctrl.host.os.name}}</td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.host.kernelVersion">
               <td>Kernel Version</td>
               <td>{{ $ctrl.host.kernelVersion }}</td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.host.totalCPU">
               <td>Total CPU</td>
               <td>{{ $ctrl.host.totalCPU }}</td>
             </tr>
-            <tr>
+            <tr ng-if="$ctrl.host.totalMemory">
               <td>Total memory</td>
               <td>{{ $ctrl.host.totalMemory | humansize }}</td>
             </tr>
-            <!-- <tr ng-if="$ctrl.isAgent">
+            <tr ng-if="$ctrl.host.physicalDeviceInfo">
               <td>Physical device information</td>
               <td>{{ $ctrl.host.physicalDeviceInfo }}</td>
             </tr>
-            <tr ng-if="$ctrl.isAgent">
+            <tr ng-if="$ctrl.host.pciDevices">
               <td>Installed PCI devices</td>
               <td>{{ $ctrl.host.pciDevices }}</td>
             </tr>
-            <tr ng-if="$ctrl.isAgent">
+            <tr ng-if="$ctrl.host.physicalDisk">
               <td>Physical disk</td>
               <td>{{ $ctrl.host.physicalDisk }}</td>
-            </tr> -->
+            </tr>
           </tbody>
         </table>
       </rd-widget-body>
diff --git a/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel-controller.js b/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel-controller.js
index 12365ceac..c2ae18175 100644
--- a/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel-controller.js
+++ b/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel-controller.js
@@ -21,7 +21,7 @@ angular
         }
         if (this.details.role === managerRole) {
           this.state.managerAddress =
-            '(Manager address: ' + this.details.managerAddress + ')';
+            '(' + this.details.managerAddress + ')';
         }
       }
 
diff --git a/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel.html b/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel.html
index 830ece9f5..036da9772 100644
--- a/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel.html
+++ b/app/docker/components/host-view-panels/swarm-node-details-panel/swarm-node-details-panel.html
@@ -5,7 +5,7 @@
       <rd-widget-body classes="no-padding">
         <table class="table">
           <tbody>
-            <tr>
+            <tr ng-if="$ctrl.details.name">
               <td>Node name</td>
               <td>{{ $ctrl.details.name }}</td>
             </tr>