github
/
portainer
mirror of https://github.com/portainer/portainer
1
0
Fork 0
Code Issues Releases Wiki Activity

fix(app): autoscaling min validation [EE-6387] (#10945)

pull/10956/head
Ali 2024-01-15 14:34:16 +13:00 committed by GitHub
parent b3b7cfa77f
commit 3a959208a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/react/kubernetes/applications/components/AutoScalingFormSection/AutoScalingFormSection.tsx
View File

@ -48,7 +48,7 @@ export function AutoScalingFormSection({
<Input
id="min-instances"
type="number"
min="0"
min="1"
value={values.minReplicas}
max={values.maxReplicas || 1}
onChange={(e) =>

37
app/react/kubernetes/applications/components/AutoScalingFormSection/autoScalingValidation.ts
View File

@ -12,26 +12,25 @@ export function autoScalingValidation(
const { autoScalerOverflow } = validationData || {};
return object({
isUsed: boolean().required(),
minReplicas: number()
.min(0, 'Minimum instances must be greater than 0.')
.when('isUsed', (isUsed: boolean) =>
isUsed
? number()
.required('Minimum instances is required.')
.test(
'maxReplicas',
'Minimum instances must be less than maximum instances.',
// eslint-disable-next-line func-names
function (this, value?: number): boolean {
if (!value) {
return false;
}
const { maxReplicas } = this.parent as AutoScalingFormValues;
return !maxReplicas || value < maxReplicas;
minReplicas: number().when('isUsed', (isUsed: boolean) =>
isUsed
? number()
.required('Minimum instances is required.')
.min(1, 'Minimum instances must be greater than 0.')
.test(
'maxReplicas',
'Minimum instances must be less than maximum instances.',
// eslint-disable-next-line func-names
function (this, value?: number): boolean {
if (!value) {
return true;
}
)
: number()
),
const { maxReplicas } = this.parent as AutoScalingFormValues;
return !maxReplicas || value < maxReplicas;
}
)
: number()
),
maxReplicas: number().when('isUsed', (isUsed: boolean) =>
isUsed
? number()