fix(app):fix additional not save warning EE-799 (#5161)

* fix(app):fix additional not save warning EE-799

* fix additional warning when user leave page

* fix additional warning when user leave page in buildImageController.js

* fix docker build controller additional warning message

* fix changes required from reviews

* - refactored ondestroy hook function to align it closer to (below) oninit
- removed duplicated hook func duplication in configurationController

Co-authored-by: zees-dev <dev.786zshan@gmail.com>

app/docker/views/configs/create/createConfigController.js

@@ -62,6 +62,10 @@ class CreateConfigController {
     }
   }
 
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
+
   async uiCanExit() {
     if (this.formValues.displayCodeEditor && this.formValues.ConfigContent && this.state.isEditorDirty) {
       return this.ModalService.confirmWebEditorDiscard();

app/docker/views/images/build/buildImageController.js

@@ -23,6 +23,10 @@ function BuildImageController($scope, $async, $window, ModalService, BuildServic
     }
   };
 
+  $scope.$on('$destroy', function () {
+    $scope.state.isEditorDirty = false;
+  });
+
   $scope.addImageName = function () {
     $scope.formValues.ImageNames.push({ Name: '' });
   };

app/edge/views/edge-jobs/createEdgeJobView/createEdgeJobViewController.js

@@ -77,4 +77,8 @@ export class CreateEdgeJobViewController {
       }
     };
   }
+
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
 }

app/edge/views/edge-jobs/edgeJob/edgeJobController.js

@@ -170,4 +170,8 @@ export class EdgeJobController {
       }
     };
   }
+
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
 }

app/edge/views/edge-stacks/createEdgeStackView/createEdgeStackViewController.js

@@ -71,6 +71,10 @@ export class CreateEdgeStackViewController {
     };
   }
 
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
+
   createStack() {
     return this.$async(this.createStackAsync);
   }

app/edge/views/edge-stacks/editEdgeStackView/editEdgeStackViewController.js

@@ -53,6 +53,10 @@ export class EditEdgeStackViewController {
     };
   }
 
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
+
   async uiCanExit() {
     if (this.formValues.StackFileContent !== this.oldFileContent && this.state.isEditorDirty) {
       return this.ModalService.confirmWebEditorDiscard();

app/kubernetes/views/configurations/create/createConfigurationController.js

@@ -114,6 +114,10 @@ class KubernetesCreateConfigurationController {
   $onInit() {
     return this.$async(this.onInit);
   }
+
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
 }
 
 export default KubernetesCreateConfigurationController;

app/kubernetes/views/configurations/edit/configurationController.js

@@ -289,6 +289,7 @@ class KubernetesConfigurationController {
     if (this.state.currentName !== this.$state.$current.name) {
       this.LocalStorage.storeActiveTab('configuration', 0);
     }
+    this.state.isEditorDirty = false;
   }
 }
 

app/kubernetes/views/deploy/deployController.js

@@ -148,6 +148,10 @@ class KubernetesDeployController {
   $onInit() {
     return this.$async(this.onInit);
   }
+
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
 }
 
 export default KubernetesDeployController;

app/portainer/views/custom-templates/create-custom-template-view/createCustomTemplateViewController.js

@@ -189,6 +189,10 @@ class CreateCustomTemplateViewController {
     };
   }
 
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
+
   async uiCanExit() {
     if (this.state.Method === 'editor' && this.formValues.FileContent && this.state.isEditorDirty) {
       return this.ModalService.confirmWebEditorDiscard();

app/portainer/views/custom-templates/edit-custom-template-view/editCustomTemplateViewController.js

@@ -123,6 +123,10 @@ class EditCustomTemplateViewController {
       }
     };
   }
+
+  $onDestroy() {
+    this.state.isEditorDirty = false;
+  }
 }
 
 export default EditCustomTemplateViewController;

app/portainer/views/stacks/create/createStackController.js

@@ -53,6 +53,10 @@ angular
       }
     };
 
+    $scope.$on('$destroy', function() {
+      $scope.state.isEditorDirty = false;
+    })
+
     $scope.onChangeFormValues = onChangeFormValues;
 
     $scope.addEnvironmentVariable = function () {

app/portainer/views/stacks/edit/stackController.js

@@ -70,6 +70,10 @@ angular.module('portainer.app').controller('StackController', [
       }
     };
 
+    $scope.$on('$destroy', function() {
+      $scope.state.isEditorDirty = false;
+    })
+
     $scope.handleEnvVarChange = handleEnvVarChange;
     function handleEnvVarChange(value) {
       $scope.formValues.Env = value;