From 2ce830eb16896aa3f55c7f403567cd8ae6a6cc0c Mon Sep 17 00:00:00 2001
From: Chaim Lev-Ari <chiptus@gmail.com>
Date: Sun, 28 Oct 2018 10:16:02 +0200
Subject: [PATCH] refactor(webpack): remove empty controllers

---
 .eslintrc.yml                                              | 2 +-
 .../files-datatable/files-datatable-controller.js          | 7 -------
 .../components/host-overview/host-overview-controller.js   | 5 -----
 .../engine-details-panel-controller.js                     | 7 -------
 .../host-details-panel/host-details-panel-controller.js    | 6 ------
 5 files changed, 1 insertion(+), 26 deletions(-)
 delete mode 100644 app/agent/components/files-datatable/files-datatable-controller.js
 delete mode 100644 app/docker/components/host-overview/host-overview-controller.js
 delete mode 100644 app/docker/components/host-view-panels/engine-details-panel/engine-details-panel-controller.js
 delete mode 100644 app/docker/components/host-view-panels/host-details-panel/host-details-panel-controller.js

diff --git a/.eslintrc.yml b/.eslintrc.yml
index b0bf3e361..cf2547092 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -70,7 +70,7 @@ rules:
 #   no-case-declarations: error
 #   no-div-regex: error
 #   no-else-return: off
-#   no-empty-function: off
+  no-empty-function: warn
 #   no-empty-pattern: error
 #   no-eq-null: error
 #   no-eval: error
diff --git a/app/agent/components/files-datatable/files-datatable-controller.js b/app/agent/components/files-datatable/files-datatable-controller.js
deleted file mode 100644
index 581807a3a..000000000
--- a/app/agent/components/files-datatable/files-datatable-controller.js
+++ /dev/null
@@ -1,7 +0,0 @@
-import angular from 'angular';
-
-angular
-  .module('portainer.agent')
-  .controller('FilesDatatableController', [
-    function FilesDatatableController() {}
-  ]);
diff --git a/app/docker/components/host-overview/host-overview-controller.js b/app/docker/components/host-overview/host-overview-controller.js
deleted file mode 100644
index 18cd32718..000000000
--- a/app/docker/components/host-overview/host-overview-controller.js
+++ /dev/null
@@ -1,5 +0,0 @@
-import angular from 'angular';
-
-angular
-  .module('portainer.docker')
-  .controller('HostOverviewController', [function HostOverviewController() {}]);
diff --git a/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel-controller.js b/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel-controller.js
deleted file mode 100644
index bebd3dd40..000000000
--- a/app/docker/components/host-view-panels/engine-details-panel/engine-details-panel-controller.js
+++ /dev/null
@@ -1,7 +0,0 @@
-import angular from 'angular';
-
-angular
-  .module('portainer.docker')
-  .controller('EngineDetailsPanelController', [
-    function EngineDetailsPanelController() {}
-  ]);
diff --git a/app/docker/components/host-view-panels/host-details-panel/host-details-panel-controller.js b/app/docker/components/host-view-panels/host-details-panel/host-details-panel-controller.js
deleted file mode 100644
index 0e1928ab7..000000000
--- a/app/docker/components/host-view-panels/host-details-panel/host-details-panel-controller.js
+++ /dev/null
@@ -1,6 +0,0 @@
-import angular from 'angular';
-
-angular.module('portainer.docker')
-.controller('HostDetailsPanelController', [function HostDetailsPanelController(){
-  
-}]);