github
/
portainer
mirror of https://github.com/portainer/portainer
1
0
Fork 0
Code Issues Releases Wiki Activity

fix(app): Make sure empty tables don't have select all rows checkbox checked (#489)

pull/12074/merge
James Player 2025-03-12 10:34:07 +13:00 committed by GitHub
parent b57855f20d
commit 28b222fffa
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/react/components/datatables/Datatable.test.tsx
View File

@ -155,6 +155,9 @@ describe('Datatable', () => {
); );
expect(screen.getByText('No data available')).toBeInTheDocument(); expect(screen.getByText('No data available')).toBeInTheDocument();
const selectAllCheckbox: HTMLInputElement =
screen.getByLabelText('Select all rows');
expect(selectAllCheckbox.checked).toBe(false);
}); });
it('selects/deselects only page rows when select all is clicked', () => { it('selects/deselects only page rows when select all is clicked', () => {

3
app/react/components/datatables/select-column.tsx
View File

@ -3,7 +3,8 @@ import { ColumnDef, Row, Table } from '@tanstack/react-table';
import { Checkbox } from '@@/form-components/Checkbox'; import { Checkbox } from '@@/form-components/Checkbox';
function allRowsSelected<T>(table: Table<T>) { function allRowsSelected<T>(table: Table<T>) {
return table.getCoreRowModel().rows.every((row) => row.getIsSelected()); const { rows } = table.getCoreRowModel();
return rows.length > 0 && rows.every((row) => row.getIsSelected());
} }
function someRowsSelected<T>(table: Table<T>) { function someRowsSelected<T>(table: Table<T>) {