feat: add setting to change DNS servers (#3511)

* feat: add setting to change DNS servers

* style: fixing codeclimate warning

Looks like conditional was excessive, it works as expected even without
it.

* style: rename 'DNS Server 1/2' to 'Primary/Secondary DNS Server'

Signed-off-by: Kirill K <kovalev.kirill.a@gmail.com>

* style: rename variables in code to match UI naming

* feat: add tooltips on DNS servers input fields

Signed-off-by: Kirill K <kovalev.kirill.a@gmail.com>

* Revert "feat: add tooltips on DNS servers input fields"

This reverts commit b83ef50825.

* style: secondary DNS placeholder

Signed-off-by: Kirill K <kovalev.kirill.a@gmail.com>

app/docker/views/containers/create/createContainerController.js

@@ -21,6 +21,8 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container
     MacAddress: '',
     IPv4: '',
     IPv6: '',
+    DnsPrimary: '',
+    DnsSecondary: '',
     AccessControlData: new AccessControlFormData(),
     CpuLimit: 0,
     MemoryLimit: 0,
@@ -202,19 +204,28 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container
     }
     config.HostConfig.NetworkMode = networkMode;
     config.MacAddress = $scope.formValues.MacAddress;
- 
+
     config.NetworkingConfig.EndpointsConfig[networkMode] = {
       IPAMConfig: {
         IPv4Address: $scope.formValues.IPv4,
         IPv6Address: $scope.formValues.IPv6
       }
     };
-    
+
     if (networkMode && _.get($scope.config.NetworkingConfig.EndpointsConfig[networkMode], 'Aliases')){
       var aliases = $scope.config.NetworkingConfig.EndpointsConfig[networkMode].Aliases;
       config.NetworkingConfig.EndpointsConfig[networkMode].Aliases = _.filter(aliases, (o) => { return !_.startsWith($scope.fromContainer.Id,o)});
     }
 
+    var dnsServers = [];
+    if ($scope.formValues.DnsPrimary) {
+      dnsServers.push($scope.formValues.DnsPrimary);
+    }
+    if ($scope.formValues.DnsSecondary) {
+      dnsServers.push($scope.formValues.DnsSecondary);
+    }
+    config.HostConfig.Dns = dnsServers;
+
     $scope.formValues.ExtraHosts.forEach(function (v) {
     if (v.value) {
         config.HostConfig.ExtraHosts.push(v.value);
@@ -312,7 +323,7 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container
     return config;
   }
 
-  
+
   function loadFromContainerCmd() {
     if ($scope.config.Cmd) {
       $scope.config.Cmd = ContainerHelper.commandArrayToString($scope.config.Cmd);
@@ -387,6 +398,9 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container
     }
     $scope.formValues.MacAddress = d.Config.MacAddress;
 
+    $scope.formValues.DnsPrimary = d.HostConfig.Dns[0];
+    $scope.formValues.DnsSecondary = d.HostConfig.Dns[1];
+
     // ExtraHosts
     if ($scope.config.HostConfig.ExtraHosts) {
       var extraHosts = $scope.config.HostConfig.ExtraHosts;

app/docker/views/containers/create/createcontainer.html

@@ -435,6 +435,22 @@
                 </div>
               </div>
               <!-- !ipv6-input -->
+              <!-- dns-primary-input -->
+              <div class="form-group">
+                <label for="container_dns_primary" class="col-sm-2 col-lg-1 control-label text-left">Primary DNS Server</label>
+                <div class="col-sm-9">
+                  <input type="text" class="form-control" ng-model="formValues.DnsPrimary" id="container_dns_primary" placeholder="e.g. 1.1.1.1">
+                </div>
+              </div>
+              <!-- !dns-primary-input -->
+              <!-- dns-secondary-input -->
+              <div class="form-group">
+                <label for="container_dns_secondary" class="col-sm-2 col-lg-1 control-label text-left">Secondary DNS Server</label>
+                <div class="col-sm-9">
+                  <input type="text" class="form-control" ng-model="formValues.DnsSecondary" id="container_dns_secondary" placeholder="e.g. 1.0.0.1">
+                </div>
+              </div>
+              <!-- !dns-secondary-input -->
               <!-- extra-hosts-variables -->
               <div class="form-group">
                 <div class="col-sm-12" style="margin-top: 5px;">