feat(api): Permissions-Policy header deny all (#1021)

pull/12567/merge
LP B 2025-08-13 22:07:55 +02:00 committed by GitHub
parent 7f167ff2fc
commit 1197b1dd8d
3 changed files with 165 additions and 0 deletions

View File

@ -55,6 +55,10 @@ func (handler *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
} }
} }
if r.RequestURI == "/" || strings.HasSuffix(r.RequestURI, ".html") {
w.Header().Set("Permissions-Policy", strings.Join(permissions, ","))
}
if !isHTML(r.Header["Accept"]) { if !isHTML(r.Header["Accept"]) {
w.Header().Set("Cache-Control", "max-age=31536000") w.Header().Set("Cache-Control", "max-age=31536000")
} else { } else {

View File

@ -0,0 +1,70 @@
package file_test
import (
"net/http"
"net/http/httptest"
"testing"
"github.com/portainer/portainer/api/http/handler/file"
"github.com/stretchr/testify/require"
)
func TestNormalServe(t *testing.T) {
handler := file.NewHandler("", false, func() bool { return false })
require.NotNil(t, handler)
request := func(path string) (*http.Request, *httptest.ResponseRecorder) {
rr := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, path, nil)
handler.ServeHTTP(rr, req)
return req, rr
}
_, rr := request("/timeout.html")
require.Equal(t, http.StatusTemporaryRedirect, rr.Result().StatusCode)
loc, err := rr.Result().Location()
require.NoError(t, err)
require.NotNil(t, loc)
require.Equal(t, "/", loc.Path)
_, rr = request("/")
require.Equal(t, http.StatusOK, rr.Result().StatusCode)
}
func TestPermissionsPolicyHeader(t *testing.T) {
handler := file.NewHandler("", false, func() bool { return false })
require.NotNil(t, handler)
test := func(path string, exist bool) {
rr := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, path, nil)
handler.ServeHTTP(rr, req)
require.Equal(t, exist, rr.Result().Header.Get("Permissions-Policy") != "")
}
test("/", true)
test("/index.html", true)
test("/api", false)
test("/an/image.png", false)
}
func TestRedirectInstanceDisabled(t *testing.T) {
handler := file.NewHandler("", false, func() bool { return true })
require.NotNil(t, handler)
test := func(path string) {
rr := httptest.NewRecorder()
req := httptest.NewRequest(http.MethodGet, path, nil)
handler.ServeHTTP(rr, req)
require.Equal(t, http.StatusTemporaryRedirect, rr.Result().StatusCode)
loc, err := rr.Result().Location()
require.NoError(t, err)
require.NotNil(t, loc)
require.Equal(t, "/timeout.html", loc.Path)
}
test("/")
test("/index.html")
}

View File

@ -0,0 +1,91 @@
package file
var permissions = []string{
"accelerometer=()",
"ambient-light-sensor=()",
"attribution-reporting=()",
"autoplay=()",
"battery=()",
"browsing-topics=()",
"camera=()",
"captured-surface-control=()",
"ch-device-memory=()",
"ch-downlink=()",
"ch-dpr=()",
"ch-ect=()",
"ch-prefers-color-scheme=()",
"ch-prefers-reduced-motion=()",
"ch-prefers-reduced-transparency=()",
"ch-rtt=()",
"ch-save-data=()",
"ch-ua=()",
"ch-ua-arch=()",
"ch-ua-bitness=()",
"ch-ua-form-factors=()",
"ch-ua-full-version=()",
"ch-ua-full-version-list=()",
"ch-ua-mobile=()",
"ch-ua-model=()",
"ch-ua-platform=()",
"ch-ua-platform-version=()",
"ch-ua-wow64=()",
"ch-viewport-height=()",
"ch-viewport-width=()",
"ch-width=()",
"compute-pressure=()",
"conversion-measurement=()",
"cross-origin-isolated=()",
"deferred-fetch=()",
"deferred-fetch-minimal=()",
"display-capture=()",
"document-domain=()",
"encrypted-media=()",
"execution-while-not-rendered=()",
"execution-while-out-of-viewport=()",
"focus-without-user-activation=()",
"fullscreen=()",
"gamepad=()",
"geolocation=()",
"gyroscope=()",
"hid=()",
"identity-credentials-get=()",
"idle-detection=()",
"interest-cohort=()",
"join-ad-interest-group=()",
"keyboard-map=()",
"language-detector=()",
"local-fonts=()",
"magnetometer=()",
"microphone=()",
"midi=()",
"navigation-override=()",
"otp-credentials=()",
"payment=()",
"picture-in-picture=()",
"private-aggregation=()",
"private-state-token-issuance=()",
"private-state-token-redemption=()",
"publickey-credentials-create=()",
"publickey-credentials-get=()",
"rewriter=()",
"run-ad-auction=()",
"screen-wake-lock=()",
"serial=()",
"shared-storage=()",
"shared-storage-select-url=()",
"speaker-selection=()",
"storage-access=()",
"summarizer=()",
"sync-script=()",
"sync-xhr=()",
"translator=()",
"trust-token-redemption=()",
"unload=()",
"usb=()",
"vertical-scroll=()",
"web-share=()",
"window-management=()",
"window-placement=()",
"writer=()",
"xr-spatial-tracking=()",
}