From 117e3500ae12e20283ab80b36ab55c694eaabe73 Mon Sep 17 00:00:00 2001
From: Ali <83188384+testA113@users.noreply.github.com>
Date: Thu, 12 Dec 2024 15:22:19 +1300
Subject: [PATCH] fix(edge-stack): revert useEffect, to call matchRegistry less
 often [BE-11501] (#239)

---
 .../EditEdgeStackForm/PrivateRegistryFieldsetWrapper.tsx  | 6 ------
 app/react/edge/edge-stacks/queries/useParseRegistries.ts  | 8 ++++----
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/app/react/edge/edge-stacks/ItemView/EditEdgeStackForm/PrivateRegistryFieldsetWrapper.tsx b/app/react/edge/edge-stacks/ItemView/EditEdgeStackForm/PrivateRegistryFieldsetWrapper.tsx
index 980108a99..5f5b515de 100644
--- a/app/react/edge/edge-stacks/ItemView/EditEdgeStackForm/PrivateRegistryFieldsetWrapper.tsx
+++ b/app/react/edge/edge-stacks/ItemView/EditEdgeStackForm/PrivateRegistryFieldsetWrapper.tsx
@@ -1,5 +1,4 @@
 import _ from 'lodash';
-import { useEffect } from 'react';
 
 import { notifyError } from '@/portainer/services/notifications';
 import { PrivateRegistryFieldset } from '@/react/edge/edge-stacks/components/PrivateRegistryFieldset';
@@ -32,11 +31,6 @@ export function PrivateRegistryFieldsetWrapper({
 
   const registriesQuery = useRegistries({ hideDefault: true });
 
-  useEffect(() => {
-    matchRegistry(values);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [values.file, values.fileContent]);
-
   if (!registriesQuery.data) {
     return null;
   }
diff --git a/app/react/edge/edge-stacks/queries/useParseRegistries.ts b/app/react/edge/edge-stacks/queries/useParseRegistries.ts
index ef4a1f9c0..e8e251c65 100644
--- a/app/react/edge/edge-stacks/queries/useParseRegistries.ts
+++ b/app/react/edge/edge-stacks/queries/useParseRegistries.ts
@@ -1,6 +1,5 @@
 import { useMutation } from '@tanstack/react-query';
 
-import { withGlobalError } from '@/react-tools/react-query';
 import { RegistryId } from '@/react/portainer/registries/types/registry';
 import axios, {
   json2formData,
@@ -10,9 +9,10 @@ import axios, {
 import { buildUrl } from './buildUrl';
 
 export function useParseRegistries() {
-  return useMutation(parseRegistries, {
-    ...withGlobalError('Failed parsing registries'),
-  });
+  return useMutation(
+    parseRegistries
+    // handle errors in the calling function (notifyError vs setting form errors in validation)
+  );
 }
 
 export async function parseRegistries({