chore(store) EE-1981: Refactor/store/error checking, and other refactoring (#6173)
* use the Store interface IsErrObjectNotFound() to avoid revealing internal errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* what happens when you extract the datastore interfaces into their own package
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* Start renaming Storage methods
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the boltdb specific code from the Portainer storage code (example, the others need the same)
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extract bolt.Tx from datastore code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* minimise imports by putting moving the struct definition into the file that needs the Service imports
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extraction of boltdb.Tx
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the use of bucket.SetSequence
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* almost done - just endpoint.Synchonise :/
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* so, endpoint.Synchonize looks hard, but i can't find where we use it, so 'delete first refactoring'
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix test compile errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* test compile fixes after rebase
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix a mis-remembering I had wrt deserialisation - last time i used AnyData - jsoniter's bindTo looks interesting for the same reason
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* set us up to make the connection an interface
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make the db connection a datastore interface, and separate out our datastore services from the bolt ones
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* rename methods to something less oltdb internals specific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* these errors are not boltdb secific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* start using the db-backend factory method too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* export boltdb raw in case we can't export from the service layer
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add a raw export from boltdb to yaml for broken db's, and an export services to yaml in backup
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add the version info by hand for now
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* actually, the export from services can be fully typed - its the import that needs to do more work
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* redo raw export, and make import capable of using it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add DockerHub
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* migration from anything older than v1.21.0 has been broken for quite a while, deleting the un-tested code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix go test ./... again
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* my goland wasn't setup to gofmt
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the two extremely dubious migration tests down into store, so they can use the test store code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* the migrator is now free of boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* reverse goland overzealous replcement of internal with boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more undo over-zealous goland internal->boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* yay, now bolt is only mentioned inside the api/database/ dir
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* and this might be the last of the boltdb references?
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add todo
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the store code into a separate module too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* don't need the fileService in boltdb anymore
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use IsErrObjectNotFound()
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use a string to select what database backend we use
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make isNew store an ephemeral bool that doesn't stay true after we've initialised it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the import.json wip to a separate file so its more obvious - we'll be using it for testing, emergency fixups, and in the next part of the store work, when we improve migrations and data model lifecycles
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* undo vscode formatting html
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix app templates symbol (#6221)
* feat(webhook) EE-2125 send registry auth haeder when update swarms service via webhook (#6220)
* feat(webhook) EE-2125 add some helpers to registry utils
* feat(webhook) EE-2125 persist registryID when creating a webhook
* feat(webhook) EE-2125 send registry auth header when executing a webhook
* feat(webhook) EE-2125 send registryID to backend when creating a service with webhook
* feat(webhook) EE-2125 use the initial registry ID to create webhook on editing service screen
* feat(webhook) EE-2125 update webhook when update registry
* feat(webhook) EE-2125 add endpoint of update webhook
* feat(webhook) EE-2125 code cleanup
* feat(webhook) EE-2125 fix a typo
* feat(webhook) EE-2125 fix circle import issue with unit test
Co-authored-by: Simon Meng <simon.meng@portainer.io>
* fix(kubeconfig): show kubeconfig download button for non admin users [EE-2123] (#6204)
Co-authored-by: Simon Meng <simon.meng@portainer.io>
* fix data-cy for k8s cluster menu (#6226)
LGTM
* feat(stack): make stack created from app template editable EE-1941 (#6104)
feat(stack): make stack from app template editable
* fix(container):disable Duplicate/Edit button when the container is portainer (#6223)
* fix/ee-1909/show-pull-image-error (#6195)
Co-authored-by: sunportainer <ericsun@SG1.local>
* feat(cy): add data-cy to helm install button (#6241)
* feat(cy): add data-cy to add registry button (#6242)
* refactor(app): convert root folder files to es6 (#4159)
* refactor(app): duplicate constants as es6 exports (#4158)
* fix(docker): provide workaround to save network name variable (#6080)
* fix/EE-1862/unable-to-stop-or-remove-stack workaround for var without default value in yaml file
* fix/EE-1862/unable-to-stop-or-remove-stack check yaml file
* fixed func and var names
* wrapper error and used bool for stringset
* UT case for createNetworkEnvFile
* UT case for %s=%s
* powerful StringSet
* wrapper error for extract network name
* wrapper all the return err
* store more env
* put to env file
* make default value None
* feat: gzip static resources (#6258)
* fix(ssl)//handle --sslcert and --sslkey ee-2106 (#6203)
* fix/ee-2106/handle-sslcert-sslkey
Co-authored-by: sunportainer <ericsun@SG1.local>
* fix(server):support disable https only ee-2068 (#6232)
* fix/ee-2068/disable-forcely-https
* feat(store): implement store tests EE-2112 (#6224)
* add store tests
* add some more tests
* Update missing helm user repo methods
* remove redundant comments
* add webhook export
* update webhooks
* use the Store interface IsErrObjectNotFound() to avoid revealing internal errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* what happens when you extract the datastore interfaces into their own package
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* Start renaming Storage methods
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the boltdb specific code from the Portainer storage code (example, the others need the same)
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extract bolt.Tx from datastore code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* minimise imports by putting moving the struct definition into the file that needs the Service imports
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extraction of boltdb.Tx
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the use of bucket.SetSequence
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* almost done - just endpoint.Synchonise :/
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* so, endpoint.Synchonize looks hard, but i can't find where we use it, so 'delete first refactoring'
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix test compile errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* test compile fixes after rebase
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix a mis-remembering I had wrt deserialisation - last time i used AnyData - jsoniter's bindTo looks interesting for the same reason
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* set us up to make the connection an interface
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make the db connection a datastore interface, and separate out our datastore services from the bolt ones
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* rename methods to something less oltdb internals specific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* these errors are not boltdb secific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* start using the db-backend factory method too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* export boltdb raw in case we can't export from the service layer
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add a raw export from boltdb to yaml for broken db's, and an export services to yaml in backup
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add the version info by hand for now
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* actually, the export from services can be fully typed - its the import that needs to do more work
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* redo raw export, and make import capable of using it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add DockerHub
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* migration from anything older than v1.21.0 has been broken for quite a while, deleting the un-tested code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix go test ./... again
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* my goland wasn't setup to gofmt
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the two extremely dubious migration tests down into store, so they can use the test store code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* the migrator is now free of boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* reverse goland overzealous replcement of internal with boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more undo over-zealous goland internal->boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* yay, now bolt is only mentioned inside the api/database/ dir
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* and this might be the last of the boltdb references?
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add todo
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the store code into a separate module too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* don't need the fileService in boltdb anymore
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use IsErrObjectNotFound()
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use a string to select what database backend we use
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make isNew store an ephemeral bool that doesn't stay true after we've initialised it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the import.json wip to a separate file so its more obvious - we'll be using it for testing, emergency fixups, and in the next part of the store work, when we improve migrations and data model lifecycles
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* undo vscode formatting html
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* Update missing helm user repo methods
* feat(store): implement store tests EE-2112 (#6224)
* add store tests
* add some more tests
* remove redundant comments
* add webhook export
* update webhooks
* fix build issues after rebasing
* move migratorparams
* remove unneeded integer type conversions
* disable the db import/export for now
Co-authored-by: Richard Wei <54336863+WaysonWei@users.noreply.github.com>
Co-authored-by: cong meng <mcpacino@gmail.com>
Co-authored-by: Simon Meng <simon.meng@portainer.io>
Co-authored-by: Marcelo Rydel <marcelorydel26@gmail.com>
Co-authored-by: Hao Zhang <hao.zhang@portainer.io>
Co-authored-by: sunportainer <93502624+sunportainer@users.noreply.github.com>
Co-authored-by: sunportainer <ericsun@SG1.local>
Co-authored-by: wheresolivia <78844659+wheresolivia@users.noreply.github.com>
Co-authored-by: Chaim Lev-Ari <chiptus@users.noreply.github.com>
Co-authored-by: Chao Geng <93526589+chaogeng77977@users.noreply.github.com>
Co-authored-by: Dmitry Salakhov <to@dimasalakhov.com>
Co-authored-by: Matt Hook <hookenz@gmail.com>
2021-12-15 02:26:09 +00:00
|
|
|
package datastore
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"runtime"
|
|
|
|
"strings"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/dchest/uniuri"
|
|
|
|
"github.com/pkg/errors"
|
|
|
|
portainer "github.com/portainer/portainer/api"
|
|
|
|
"github.com/portainer/portainer/api/chisel"
|
|
|
|
"github.com/portainer/portainer/api/crypto"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
)
|
|
|
|
|
|
|
|
const (
|
|
|
|
adminUsername = "admin"
|
|
|
|
adminPassword = "password"
|
|
|
|
standardUsername = "standard"
|
|
|
|
standardPassword = "password"
|
|
|
|
agentOnDockerEnvironmentUrl = "tcp://192.168.167.207:30775"
|
|
|
|
edgeAgentOnKubernetesEnvironmentUrl = "tcp://192.168.167.207"
|
|
|
|
kubernetesLocalEnvironmentUrl = "https://kubernetes.default.svc"
|
|
|
|
)
|
|
|
|
|
|
|
|
// TestStoreFull an eventually comprehensive set of tests for the Store.
|
|
|
|
// The idea is what we write to the store, we should read back.
|
|
|
|
func TestStoreFull(t *testing.T) {
|
2022-09-14 05:59:47 +00:00
|
|
|
_, store, teardown := MustNewTestStore(t, true, true)
|
chore(store) EE-1981: Refactor/store/error checking, and other refactoring (#6173)
* use the Store interface IsErrObjectNotFound() to avoid revealing internal errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* what happens when you extract the datastore interfaces into their own package
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* Start renaming Storage methods
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the boltdb specific code from the Portainer storage code (example, the others need the same)
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extract bolt.Tx from datastore code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* minimise imports by putting moving the struct definition into the file that needs the Service imports
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extraction of boltdb.Tx
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the use of bucket.SetSequence
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* almost done - just endpoint.Synchonise :/
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* so, endpoint.Synchonize looks hard, but i can't find where we use it, so 'delete first refactoring'
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix test compile errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* test compile fixes after rebase
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix a mis-remembering I had wrt deserialisation - last time i used AnyData - jsoniter's bindTo looks interesting for the same reason
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* set us up to make the connection an interface
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make the db connection a datastore interface, and separate out our datastore services from the bolt ones
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* rename methods to something less oltdb internals specific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* these errors are not boltdb secific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* start using the db-backend factory method too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* export boltdb raw in case we can't export from the service layer
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add a raw export from boltdb to yaml for broken db's, and an export services to yaml in backup
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add the version info by hand for now
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* actually, the export from services can be fully typed - its the import that needs to do more work
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* redo raw export, and make import capable of using it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add DockerHub
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* migration from anything older than v1.21.0 has been broken for quite a while, deleting the un-tested code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix go test ./... again
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* my goland wasn't setup to gofmt
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the two extremely dubious migration tests down into store, so they can use the test store code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* the migrator is now free of boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* reverse goland overzealous replcement of internal with boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more undo over-zealous goland internal->boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* yay, now bolt is only mentioned inside the api/database/ dir
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* and this might be the last of the boltdb references?
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add todo
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the store code into a separate module too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* don't need the fileService in boltdb anymore
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use IsErrObjectNotFound()
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use a string to select what database backend we use
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make isNew store an ephemeral bool that doesn't stay true after we've initialised it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the import.json wip to a separate file so its more obvious - we'll be using it for testing, emergency fixups, and in the next part of the store work, when we improve migrations and data model lifecycles
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* undo vscode formatting html
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix app templates symbol (#6221)
* feat(webhook) EE-2125 send registry auth haeder when update swarms service via webhook (#6220)
* feat(webhook) EE-2125 add some helpers to registry utils
* feat(webhook) EE-2125 persist registryID when creating a webhook
* feat(webhook) EE-2125 send registry auth header when executing a webhook
* feat(webhook) EE-2125 send registryID to backend when creating a service with webhook
* feat(webhook) EE-2125 use the initial registry ID to create webhook on editing service screen
* feat(webhook) EE-2125 update webhook when update registry
* feat(webhook) EE-2125 add endpoint of update webhook
* feat(webhook) EE-2125 code cleanup
* feat(webhook) EE-2125 fix a typo
* feat(webhook) EE-2125 fix circle import issue with unit test
Co-authored-by: Simon Meng <simon.meng@portainer.io>
* fix(kubeconfig): show kubeconfig download button for non admin users [EE-2123] (#6204)
Co-authored-by: Simon Meng <simon.meng@portainer.io>
* fix data-cy for k8s cluster menu (#6226)
LGTM
* feat(stack): make stack created from app template editable EE-1941 (#6104)
feat(stack): make stack from app template editable
* fix(container):disable Duplicate/Edit button when the container is portainer (#6223)
* fix/ee-1909/show-pull-image-error (#6195)
Co-authored-by: sunportainer <ericsun@SG1.local>
* feat(cy): add data-cy to helm install button (#6241)
* feat(cy): add data-cy to add registry button (#6242)
* refactor(app): convert root folder files to es6 (#4159)
* refactor(app): duplicate constants as es6 exports (#4158)
* fix(docker): provide workaround to save network name variable (#6080)
* fix/EE-1862/unable-to-stop-or-remove-stack workaround for var without default value in yaml file
* fix/EE-1862/unable-to-stop-or-remove-stack check yaml file
* fixed func and var names
* wrapper error and used bool for stringset
* UT case for createNetworkEnvFile
* UT case for %s=%s
* powerful StringSet
* wrapper error for extract network name
* wrapper all the return err
* store more env
* put to env file
* make default value None
* feat: gzip static resources (#6258)
* fix(ssl)//handle --sslcert and --sslkey ee-2106 (#6203)
* fix/ee-2106/handle-sslcert-sslkey
Co-authored-by: sunportainer <ericsun@SG1.local>
* fix(server):support disable https only ee-2068 (#6232)
* fix/ee-2068/disable-forcely-https
* feat(store): implement store tests EE-2112 (#6224)
* add store tests
* add some more tests
* Update missing helm user repo methods
* remove redundant comments
* add webhook export
* update webhooks
* use the Store interface IsErrObjectNotFound() to avoid revealing internal errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* what happens when you extract the datastore interfaces into their own package
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* Start renaming Storage methods
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the boltdb specific code from the Portainer storage code (example, the others need the same)
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extract bolt.Tx from datastore code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* minimise imports by putting moving the struct definition into the file that needs the Service imports
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more extraction of boltdb.Tx
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the use of bucket.SetSequence
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* almost done - just endpoint.Synchonise :/
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* so, endpoint.Synchonize looks hard, but i can't find where we use it, so 'delete first refactoring'
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix test compile errors
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* test compile fixes after rebase
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix a mis-remembering I had wrt deserialisation - last time i used AnyData - jsoniter's bindTo looks interesting for the same reason
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* set us up to make the connection an interface
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make the db connection a datastore interface, and separate out our datastore services from the bolt ones
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* rename methods to something less oltdb internals specific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* these errors are not boltdb secific
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* start using the db-backend factory method too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* export boltdb raw in case we can't export from the service layer
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add a raw export from boltdb to yaml for broken db's, and an export services to yaml in backup
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add the version info by hand for now
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* actually, the export from services can be fully typed - its the import that needs to do more work
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* redo raw export, and make import capable of using it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add DockerHub
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* migration from anything older than v1.21.0 has been broken for quite a while, deleting the un-tested code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* fix go test ./... again
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* my goland wasn't setup to gofmt
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the two extremely dubious migration tests down into store, so they can use the test store code
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* the migrator is now free of boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* reverse goland overzealous replcement of internal with boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* more undo over-zealous goland internal->boltdb
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* yay, now bolt is only mentioned inside the api/database/ dir
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* and this might be the last of the boltdb references?
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* add todo
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* extract the store code into a separate module too
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* don't need the fileService in boltdb anymore
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use IsErrObjectNotFound()
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* use a string to select what database backend we use
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* make isNew store an ephemeral bool that doesn't stay true after we've initialised it
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* move the import.json wip to a separate file so its more obvious - we'll be using it for testing, emergency fixups, and in the next part of the store work, when we improve migrations and data model lifecycles
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* undo vscode formatting html
Signed-off-by: Sven Dowideit <sven.dowideit@portainer.io>
* Update missing helm user repo methods
* feat(store): implement store tests EE-2112 (#6224)
* add store tests
* add some more tests
* remove redundant comments
* add webhook export
* update webhooks
* fix build issues after rebasing
* move migratorparams
* remove unneeded integer type conversions
* disable the db import/export for now
Co-authored-by: Richard Wei <54336863+WaysonWei@users.noreply.github.com>
Co-authored-by: cong meng <mcpacino@gmail.com>
Co-authored-by: Simon Meng <simon.meng@portainer.io>
Co-authored-by: Marcelo Rydel <marcelorydel26@gmail.com>
Co-authored-by: Hao Zhang <hao.zhang@portainer.io>
Co-authored-by: sunportainer <93502624+sunportainer@users.noreply.github.com>
Co-authored-by: sunportainer <ericsun@SG1.local>
Co-authored-by: wheresolivia <78844659+wheresolivia@users.noreply.github.com>
Co-authored-by: Chaim Lev-Ari <chiptus@users.noreply.github.com>
Co-authored-by: Chao Geng <93526589+chaogeng77977@users.noreply.github.com>
Co-authored-by: Dmitry Salakhov <to@dimasalakhov.com>
Co-authored-by: Matt Hook <hookenz@gmail.com>
2021-12-15 02:26:09 +00:00
|
|
|
defer teardown()
|
|
|
|
|
|
|
|
testCases := map[string]func(t *testing.T){
|
|
|
|
"User Accounts": func(t *testing.T) {
|
|
|
|
store.testUserAccounts(t)
|
|
|
|
},
|
|
|
|
"Environments": func(t *testing.T) {
|
|
|
|
store.testEnvironments(t)
|
|
|
|
},
|
|
|
|
"Settings": func(t *testing.T) {
|
|
|
|
store.testSettings(t)
|
|
|
|
},
|
|
|
|
"SSL Settings": func(t *testing.T) {
|
|
|
|
store.testSSLSettings(t)
|
|
|
|
},
|
|
|
|
"Tunnel Server": func(t *testing.T) {
|
|
|
|
store.testTunnelServer(t)
|
|
|
|
},
|
|
|
|
"Custom Templates": func(t *testing.T) {
|
|
|
|
store.testCustomTemplates(t)
|
|
|
|
},
|
|
|
|
"Registries": func(t *testing.T) {
|
|
|
|
store.testRegistries(t)
|
|
|
|
},
|
|
|
|
"Resource Control": func(t *testing.T) {
|
|
|
|
store.testResourceControl(t)
|
|
|
|
},
|
|
|
|
"Schedules": func(t *testing.T) {
|
|
|
|
store.testSchedules(t)
|
|
|
|
},
|
|
|
|
"Tags": func(t *testing.T) {
|
|
|
|
store.testTags(t)
|
|
|
|
},
|
|
|
|
|
|
|
|
// "Test Title": func(t *testing.T) {
|
|
|
|
// },
|
|
|
|
}
|
|
|
|
|
|
|
|
for name, test := range testCases {
|
|
|
|
t.Run(name, test)
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testEnvironments(t *testing.T) {
|
|
|
|
id := store.CreateEndpoint(t, "local", portainer.KubernetesLocalEnvironment, "", true)
|
|
|
|
store.CreateEndpointRelation(id)
|
|
|
|
|
|
|
|
id = store.CreateEndpoint(t, "agent", portainer.AgentOnDockerEnvironment, agentOnDockerEnvironmentUrl, true)
|
|
|
|
store.CreateEndpointRelation(id)
|
|
|
|
|
|
|
|
id = store.CreateEndpoint(t, "edge", portainer.EdgeAgentOnKubernetesEnvironment, edgeAgentOnKubernetesEnvironmentUrl, true)
|
|
|
|
store.CreateEndpointRelation(id)
|
|
|
|
}
|
|
|
|
|
|
|
|
func newEndpoint(endpointType portainer.EndpointType, id portainer.EndpointID, name, URL string, TLS bool) *portainer.Endpoint {
|
|
|
|
endpoint := &portainer.Endpoint{
|
|
|
|
ID: id,
|
|
|
|
Name: name,
|
|
|
|
URL: URL,
|
|
|
|
Type: endpointType,
|
|
|
|
GroupID: portainer.EndpointGroupID(1),
|
|
|
|
PublicURL: "",
|
|
|
|
TLSConfig: portainer.TLSConfiguration{
|
|
|
|
TLS: false,
|
|
|
|
},
|
|
|
|
UserAccessPolicies: portainer.UserAccessPolicies{},
|
|
|
|
TeamAccessPolicies: portainer.TeamAccessPolicies{},
|
|
|
|
TagIDs: []portainer.TagID{},
|
|
|
|
Status: portainer.EndpointStatusUp,
|
|
|
|
Snapshots: []portainer.DockerSnapshot{},
|
|
|
|
Kubernetes: portainer.KubernetesDefault(),
|
|
|
|
}
|
|
|
|
|
|
|
|
if TLS {
|
|
|
|
endpoint.TLSConfig = portainer.TLSConfiguration{
|
|
|
|
TLS: true,
|
|
|
|
TLSSkipVerify: true,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return endpoint
|
|
|
|
}
|
|
|
|
|
|
|
|
func setEndpointAuthorizations(endpoint *portainer.Endpoint) {
|
|
|
|
endpoint.SecuritySettings = portainer.EndpointSecuritySettings{
|
|
|
|
AllowVolumeBrowserForRegularUsers: false,
|
|
|
|
EnableHostManagementFeatures: false,
|
|
|
|
|
|
|
|
AllowSysctlSettingForRegularUsers: true,
|
|
|
|
AllowBindMountsForRegularUsers: true,
|
|
|
|
AllowPrivilegedModeForRegularUsers: true,
|
|
|
|
AllowHostNamespaceForRegularUsers: true,
|
|
|
|
AllowContainerCapabilitiesForRegularUsers: true,
|
|
|
|
AllowDeviceMappingForRegularUsers: true,
|
|
|
|
AllowStackManagementForRegularUsers: true,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) CreateEndpoint(t *testing.T, name string, endpointType portainer.EndpointType, URL string, tls bool) portainer.EndpointID {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
var expectedEndpoint *portainer.Endpoint
|
|
|
|
id := portainer.EndpointID(store.Endpoint().GetNextIdentifier())
|
|
|
|
|
|
|
|
switch endpointType {
|
|
|
|
case portainer.DockerEnvironment:
|
|
|
|
if URL == "" {
|
|
|
|
URL = "unix:///var/run/docker.sock"
|
|
|
|
if runtime.GOOS == "windows" {
|
|
|
|
URL = "npipe:////./pipe/docker_engine"
|
|
|
|
}
|
|
|
|
}
|
|
|
|
expectedEndpoint = newEndpoint(endpointType, id, name, URL, tls)
|
|
|
|
|
|
|
|
case portainer.AgentOnDockerEnvironment:
|
|
|
|
expectedEndpoint = newEndpoint(endpointType, id, name, URL, tls)
|
|
|
|
|
|
|
|
case portainer.AgentOnKubernetesEnvironment:
|
|
|
|
URL = strings.TrimPrefix(URL, "tcp://")
|
|
|
|
expectedEndpoint = newEndpoint(endpointType, id, name, URL, tls)
|
|
|
|
|
|
|
|
case portainer.EdgeAgentOnKubernetesEnvironment:
|
|
|
|
cs := chisel.NewService(store, nil)
|
|
|
|
expectedEndpoint = newEndpoint(endpointType, id, name, URL, tls)
|
|
|
|
edgeKey := cs.GenerateEdgeKey(URL, "", int(id))
|
|
|
|
expectedEndpoint.EdgeKey = edgeKey
|
|
|
|
store.testTunnelServer(t)
|
|
|
|
|
|
|
|
case portainer.KubernetesLocalEnvironment:
|
|
|
|
if URL == "" {
|
|
|
|
URL = kubernetesLocalEnvironmentUrl
|
|
|
|
}
|
|
|
|
expectedEndpoint = newEndpoint(endpointType, id, name, URL, tls)
|
|
|
|
}
|
|
|
|
|
|
|
|
setEndpointAuthorizations(expectedEndpoint)
|
|
|
|
store.Endpoint().Create(expectedEndpoint)
|
|
|
|
|
|
|
|
endpoint, err := store.Endpoint().Endpoint(id)
|
|
|
|
is.NoError(err, "Endpoint() should not return an error")
|
|
|
|
is.Equal(expectedEndpoint, endpoint, "endpoint should be the same")
|
|
|
|
|
|
|
|
return endpoint.ID
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) CreateEndpointRelation(id portainer.EndpointID) {
|
|
|
|
relation := &portainer.EndpointRelation{
|
|
|
|
EndpointID: id,
|
|
|
|
EdgeStacks: map[portainer.EdgeStackID]bool{},
|
|
|
|
}
|
|
|
|
|
|
|
|
store.EndpointRelation().Create(relation)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testSSLSettings(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
ssl := &portainer.SSLSettings{
|
|
|
|
CertPath: "/data/certs/cert.pem",
|
|
|
|
HTTPEnabled: true,
|
|
|
|
KeyPath: "/data/certs/key.pem",
|
|
|
|
SelfSigned: true,
|
|
|
|
}
|
|
|
|
|
|
|
|
store.SSLSettings().UpdateSettings(ssl)
|
|
|
|
|
|
|
|
settings, err := store.SSLSettings().Settings()
|
|
|
|
is.NoError(err, "Get sslsettings should succeed")
|
|
|
|
is.Equal(ssl, settings, "Stored SSLSettings should be the same as what is read out")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testTunnelServer(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
expectPrivateKeySeed := uniuri.NewLen(16)
|
|
|
|
|
|
|
|
err := store.TunnelServer().UpdateInfo(&portainer.TunnelServerInfo{PrivateKeySeed: expectPrivateKeySeed})
|
|
|
|
is.NoError(err, "UpdateInfo should have succeeded")
|
|
|
|
|
|
|
|
serverInfo, err := store.TunnelServer().Info()
|
|
|
|
is.NoError(err, "Info should have succeeded")
|
|
|
|
|
|
|
|
is.Equal(expectPrivateKeySeed, serverInfo.PrivateKeySeed, "hashed passwords should not differ")
|
|
|
|
}
|
|
|
|
|
|
|
|
// add users, read them back and check the details are unchanged
|
|
|
|
func (store *Store) testUserAccounts(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
err := store.createAccount(adminUsername, adminPassword, portainer.AdministratorRole)
|
|
|
|
is.NoError(err, "CreateAccount should succeed")
|
|
|
|
store.checkAccount(adminUsername, adminPassword, portainer.AdministratorRole)
|
|
|
|
is.NoError(err, "Account failure")
|
|
|
|
|
|
|
|
err = store.createAccount(standardUsername, standardPassword, portainer.StandardUserRole)
|
|
|
|
is.NoError(err, "CreateAccount should succeed")
|
|
|
|
store.checkAccount(standardUsername, standardPassword, portainer.StandardUserRole)
|
|
|
|
is.NoError(err, "Account failure")
|
|
|
|
}
|
|
|
|
|
|
|
|
// create an account with the provided details
|
|
|
|
func (store *Store) createAccount(username, password string, role portainer.UserRole) error {
|
|
|
|
var err error
|
|
|
|
user := &portainer.User{Username: username, Role: role}
|
|
|
|
|
|
|
|
// encrypt the password
|
|
|
|
cs := &crypto.Service{}
|
|
|
|
user.Password, err = cs.Hash(password)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
err = store.User().Create(user)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) checkAccount(username, expectPassword string, expectRole portainer.UserRole) error {
|
|
|
|
// Read the account for username. Check password and role is what we expect
|
|
|
|
|
|
|
|
user, err := store.User().UserByUsername(username)
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrap(err, "failed to find user")
|
|
|
|
}
|
|
|
|
|
|
|
|
if user.Username != username || user.Role != expectRole {
|
|
|
|
return fmt.Errorf("%s user details do not match", user.Username)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check the password
|
|
|
|
cs := &crypto.Service{}
|
|
|
|
expectPasswordHash, err := cs.Hash(expectPassword)
|
|
|
|
if err != nil {
|
|
|
|
return errors.Wrap(err, "hash failed")
|
|
|
|
}
|
|
|
|
|
|
|
|
if user.Password != expectPasswordHash {
|
|
|
|
return fmt.Errorf("%s user password hash failure", user.Username)
|
|
|
|
}
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testSettings(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
// since many settings are default and basically nil, I'm going to update some and read them back
|
|
|
|
expectedSettings, err := store.Settings().Settings()
|
|
|
|
is.NoError(err, "Settings() should not return an error")
|
|
|
|
expectedSettings.TemplatesURL = "http://portainer.io/application-templates"
|
|
|
|
expectedSettings.HelmRepositoryURL = "http://portainer.io/helm-repository"
|
|
|
|
expectedSettings.EdgeAgentCheckinInterval = 60
|
|
|
|
expectedSettings.AuthenticationMethod = portainer.AuthenticationLDAP
|
|
|
|
expectedSettings.LDAPSettings = portainer.LDAPSettings{
|
|
|
|
AnonymousMode: true,
|
|
|
|
StartTLS: true,
|
|
|
|
AutoCreateUsers: true,
|
|
|
|
Password: "random",
|
|
|
|
}
|
|
|
|
expectedSettings.SnapshotInterval = "10m"
|
|
|
|
|
|
|
|
err = store.Settings().UpdateSettings(expectedSettings)
|
|
|
|
is.NoError(err, "UpdateSettings() should succeed")
|
|
|
|
|
|
|
|
settings, err := store.Settings().Settings()
|
|
|
|
is.NoError(err, "Settings() should not return an error")
|
|
|
|
is.Equal(expectedSettings, settings, "stored settings should match")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testCustomTemplates(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
customTemplate := store.CustomTemplate()
|
|
|
|
is.NotNil(customTemplate, "customTemplate Service shouldn't be nil")
|
|
|
|
|
|
|
|
expectedTemplate := &portainer.CustomTemplate{
|
|
|
|
ID: portainer.CustomTemplateID(customTemplate.GetNextIdentifier()),
|
|
|
|
Title: "Custom Title",
|
|
|
|
Description: "Custom Template Description",
|
|
|
|
ProjectPath: "/data/custom_template/1",
|
|
|
|
Note: "A note about this custom template",
|
|
|
|
EntryPoint: "docker-compose.yaml",
|
|
|
|
CreatedByUserID: 10,
|
|
|
|
}
|
|
|
|
|
|
|
|
customTemplate.Create(expectedTemplate)
|
|
|
|
|
|
|
|
actualTemplate, err := customTemplate.CustomTemplate(expectedTemplate.ID)
|
|
|
|
is.NoError(err, "CustomTemplate should not return an error")
|
|
|
|
is.Equal(expectedTemplate, actualTemplate, "expected and actual template do not match")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testRegistries(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
regService := store.RegistryService
|
|
|
|
is.NotNil(regService, "RegistryService shouldn't be nil")
|
|
|
|
|
|
|
|
reg1 := &portainer.Registry{
|
|
|
|
ID: 1,
|
|
|
|
Type: portainer.DockerHubRegistry,
|
|
|
|
Name: "Dockerhub Registry Test",
|
|
|
|
}
|
|
|
|
|
|
|
|
reg2 := &portainer.Registry{
|
|
|
|
ID: 2,
|
|
|
|
Type: portainer.GitlabRegistry,
|
|
|
|
Name: "Gitlab Registry Test",
|
|
|
|
Gitlab: portainer.GitlabRegistryData{
|
|
|
|
ProjectID: 12345,
|
|
|
|
InstanceURL: "http://gitlab.com/12345",
|
|
|
|
ProjectPath: "mytestproject",
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
err := regService.Create(reg1)
|
|
|
|
is.NoError(err)
|
|
|
|
|
|
|
|
err = regService.Create(reg2)
|
|
|
|
is.NoError(err)
|
|
|
|
|
|
|
|
actualReg1, err := regService.Registry(reg1.ID)
|
|
|
|
is.NoError(err)
|
|
|
|
is.Equal(reg1, actualReg1, "registries differ")
|
|
|
|
|
|
|
|
actualReg2, err := regService.Registry(reg2.ID)
|
|
|
|
is.NoError(err)
|
|
|
|
is.Equal(reg2, actualReg2, "registries differ")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testResourceControl(t *testing.T) {
|
|
|
|
// is := assert.New(t)
|
|
|
|
// resControl := store.ResourceControl()
|
|
|
|
// ctrl := &portainer.ResourceControl{
|
|
|
|
// }
|
|
|
|
// resControl().Create()
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testSchedules(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
schedule := store.ScheduleService
|
|
|
|
s := &portainer.Schedule{
|
|
|
|
ID: portainer.ScheduleID(schedule.GetNextIdentifier()),
|
|
|
|
Name: "My Custom Schedule 1",
|
|
|
|
CronExpression: "*/5 * * * * portainer /bin/sh -c echo 'hello world'",
|
|
|
|
}
|
|
|
|
|
|
|
|
err := schedule.CreateSchedule(s)
|
|
|
|
is.NoError(err, "CreateSchedule should succeed")
|
|
|
|
|
|
|
|
actual, err := schedule.Schedule(s.ID)
|
|
|
|
is.NoError(err, "schedule should be found")
|
|
|
|
is.Equal(s, actual, "schedules differ")
|
|
|
|
}
|
|
|
|
|
|
|
|
func (store *Store) testTags(t *testing.T) {
|
|
|
|
is := assert.New(t)
|
|
|
|
|
|
|
|
tags := store.TagService
|
|
|
|
|
|
|
|
tag1 := &portainer.Tag{
|
|
|
|
ID: 1,
|
|
|
|
Name: "Tag 1",
|
|
|
|
}
|
|
|
|
|
|
|
|
tag2 := &portainer.Tag{
|
|
|
|
ID: 2,
|
|
|
|
Name: "Tag 1",
|
|
|
|
}
|
|
|
|
|
|
|
|
err := tags.Create(tag1)
|
|
|
|
is.NoError(err, "Tags.Create should succeed")
|
|
|
|
|
|
|
|
err = tags.Create(tag2)
|
|
|
|
is.NoError(err, "Tags.Create should succeed")
|
|
|
|
|
|
|
|
actual, err := tags.Tag(tag1.ID)
|
|
|
|
is.NoError(err, "tag1 should be found")
|
|
|
|
is.Equal(tag1, actual, "tags differ")
|
|
|
|
|
|
|
|
actual, err = tags.Tag(tag2.ID)
|
|
|
|
is.NoError(err, "tag2 should be found")
|
|
|
|
is.Equal(tag2, actual, "tags differ")
|
|
|
|
}
|