github
/
openvpn-gui
mirror of https://github.com/OpenVPN/openvpn-gui
1
0
Fork 0
Code Issues Releases Wiki Activity

escape \ and " in user input to management itf

pull/1/head
Heiko Hund 2012-10-16 18:54:54 +02:00
parent 66fe4edb01
commit 976b08312b
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
misc.c
View File

@ -83,10 +83,26 @@ ManagementCommandFromInput(connection_t *c, LPCSTR fmt, HWND hDlg, int id)
{ {
BOOL retval = FALSE; BOOL retval = FALSE;
LPSTR input, cmd; LPSTR input, cmd;
int input_len, cmd_len; int input_len, cmd_len, pos;
GetDlgItemTextUtf8(hDlg, id, &input, &input_len); GetDlgItemTextUtf8(hDlg, id, &input, &input_len);
/* Escape input if needed */
for (pos = 0; pos < input_len; ++pos)
{
if (input[pos] == '\\' || input[pos] == '"')
{
LPSTR buf = realloc(input, ++input_len + 1);
if (buf == NULL)
goto out;
input = buf;
memmove(input + pos + 1, input + pos, input_len - pos + 1);
input[pos] = '\\';
pos += 1;
}
}
cmd_len = input_len + strlen(fmt); cmd_len = input_len + strlen(fmt);
cmd = malloc(cmd_len); cmd = malloc(cmd_len);
if (cmd) if (cmd)
@ -96,10 +112,11 @@ ManagementCommandFromInput(connection_t *c, LPCSTR fmt, HWND hDlg, int id)
free(cmd); free(cmd);
} }
out:
/* Clear buffers with potentially secret content */ /* Clear buffers with potentially secret content */
if (input_len) if (input_len)
{ {
memset(input, 'x', input_len - 1); memset(input, 'x', input_len);
SetDlgItemTextA(hDlg, id, input); SetDlgItemTextA(hDlg, id, input);
free(input); free(input);
} }