github
/
openvpn-gui
mirror of https://github.com/OpenVPN/openvpn-gui
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove restriction of num_configs related to management_port_offset 

Since we started finding a free port dynamically, management_port_offset
is used only for making an initial hint. The limit applied to num_configs
base don this does not make sense any longer.

Also the current code does not work as expected as we allow changing of
management_port_offset from the settings menu.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
pull/589/head
Selva Nair 2023-01-14 10:34:04 -05:00
parent 724a2409f9
commit 8a4fec9d13
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
openvpn_config.c
View File

@ -414,7 +414,6 @@ BuildFileList()
int recurse_depth = 20; /* maximum number of levels below config_dir to recurse into */
int flags = 0;
static int root_gp, system_gp, persistent_gp;
int max_configs = (1<<16) - o.mgmt_port_offset;
if (o.silent_connection)
issue_warnings = false;
@ -465,14 +464,6 @@ BuildFileList()
if (o.num_configs == 0 && issue_warnings)
ShowLocalizedMsg(IDS_NFO_NO_CONFIGS, o.config_dir, o.global_config_dir);
/* More than max_configs are ignored in the menu listing */
if (o.num_configs > max_configs)
{
if (issue_warnings)
ShowLocalizedMsg(IDS_ERR_MANY_CONFIGS, max_configs);
o.num_configs = max_configs; /* management-port cant handle more -- ignore the rest */
}
ActivateConfigGroups();
issue_warnings = false;