Commit Graph

1962 Commits (10f6ff6c1fa3d0bcf594d03c572e5cb8444cf9a3)

Author SHA1 Message Date
Don HO 10f6ff6c1f
Fix a crash (regression) due to "new-less" of NppParameters
The commit 'Make NppParameters singleton "new-less"' make NppParameters instantiate in the stack instead of allocating in the heap:
3dbb2c4b8e

It makes Notepad++ crash:
https://community.notepad-plus-plus.org/topic/18316/notepad-7-8-release-candidate-3/4

The crash is on following code:

  vector<MacroShortcut> & vShortcuts = NppParameters::getInstance().getMacroList();
  size_t nbItems = vShortcuts.size();
  for (size_t itemIndex2 = 0; itemIndex2 < nbItems; ++itemIndex2)
  {
  ...

vShortcuts.size() here return a random large number, which makes crash.

The explanation about vector::size() unexpected behaviour:
https://stackoverflow.com/questions/30548944/c-vector-size-is-wrong-and-higher-than-the-number-of-elements

Obviously the stack size is not large enough to contain NppParameters singleton in 64 bits.
2019-10-03 14:05:50 +02:00
Don HO fcaef73769
Fix macro playback crash issue
The crash issue is due to a mutex locked twice which should be a dead lock but a "device or resource busy" exception is lauched:
https://stackoverflow.com/questions/16664375/why-locking-a-stdmutex-doesnt-block-the-thread

From 7.8 the standard mutex is used, that changes the behaviour.
2019-10-02 03:18:31 +02:00
Oirfeodent c92b3ca578
BaanC Add keyword lists and respective langs & styler xml tags
PR #6081 added the required keyword sets for BaanC.
Continuation of #5807 and the last change to enable all available scintilla keyword sets.

Close #6128
2019-09-25 09:53:25 +02:00
Don HO 53d2ca4dd9
Add a good geek joke 2019-09-15 23:34:35 +02:00
Scott Sumner 797fdc340d
Fix File-Rename failing when new name is on a different drive
Fix #1978, close #6111
2019-09-02 23:39:41 +02:00
Don HO 581aff630a
Use standard C++11 mutex
And remove unecessary files

Close #6093
2019-08-25 23:34:30 +02:00
Don HO 3439071c3c
Remove ATL (part two)
Use std::lock_guard instead of CComCritSecLock<CComAutoCriticalSection>

 Close #4320
2019-08-25 02:09:17 +02:00
Don HO ec5fa6d2c4
Remove ATL (part one)
Use std::wstring instead of CStringW
2019-08-25 00:14:42 +02:00
Oirfeodent d5c0ef2c77
Increase Keyword Set for the adaptation of new updated Scintilla
This will enable languages having more than 7 keyword sets to use it.

"You can set up to 9 lists of keywords for use by the current lexer. keyWordSet can be 0 to 8" :
https://www.scintilla.org/ScintillaDoc.html#SCI_SETKEYWORDS

Fix #6020, close #6081
2019-08-23 11:29:45 +02:00
Scott Sumner e102ecb919
Fix find 2 occurrences in original/clonned doccuments issue
Fix for Find-All-in-All-Opened-Documents searching a cloned document two times, and reporting same results two times.

Fix #6704, close #6705
2019-08-22 12:53:43 +02:00
Don HO ab46fe0806
Code enhancement: remove duplicated code 2019-08-22 01:19:22 +02:00
luisffranca 0d87d37d35
Handle Ctrl+A keyboard shortcut in MD5/SHA256 Generators
Added new window procedures for the HASH_PATH_EDIT/HASH_RESULT_EDIT
and HASH_TEXT_EDIT/HASH_RESULT_FOMTEXT_EDIT controls, where Ctrl+A
is now processed.

Fix #3863, close #3898, close #6034, close #6059
2019-08-22 00:50:13 +02:00
Oirfeodent 025236be6b
Enhance BaanC language support
Changes for BaanC based on new Scintilla Version.

Close #5807
2019-08-20 12:56:03 +02:00
Scott Sumner 132441867e
Bookmark all lines of multiline match
Fix #6018, close #6040
2019-08-20 00:51:01 +02:00
Scott Sumner f6d6e42ac1
Fix "clear all marks in find dialog also removes bookmarks" issue
Fix partially "clear all marks in find dialog also removes bookmarks" issue:
* Bookmark line unticked: Clear all marks button press clears only all redmarking
* Bookmark line ticked: Clear all marks button press clears all redmarking and all bookmarks

Fix #3546, close #6042
2019-08-19 12:50:51 +02:00
Don HO 93a9962fde
Code enhancement: Use C++11 =default & =delete for the constructor & destructor 2019-08-19 02:05:21 +02:00
Rajendra Singh 3a1244177c
Code enhancement: Function arguments pass by reference
Close #6063
2019-08-18 01:16:23 +02:00
Nikita Kolotov 0bf3eea08a
Code enhancement: add std qualificator
Fixed build failure caused by use of function std::make_pair without qualificator.

Fix #6051, close #6052
2019-08-17 10:24:58 +02:00
Nikita Kolotov e74cb34e22
Code enhancement: remove use of deprecated function std::bind2nd
Fixed use of deprecated function std::bind2nd.
2019-08-17 10:20:17 +02:00
Nikita Kolotov d38559b339
Code enhancement: add base class template qualifier
Fixed build failure with "/permissive-" option caused by use of members of dependent base class template without qualifier.
2019-08-17 10:13:08 +02:00
Don HO 66fc977304
Pass VS Toolset from v140_xp to v141 2019-08-17 03:41:59 +02:00
Don HO 77da706207
Code enhancement: remove goto label
Close #6053, close #6054
2019-08-16 12:34:39 +02:00
Nikita Kolotov 67305b978c
Remove unecessary qualification
Remove extra qualification present on ShortcutMapper class members declarations

Close #6045, close #6046
2019-08-15 00:35:41 +02:00
Don HO 06db9ee338
Code improvement for NppParameters 2019-08-14 22:13:24 +02:00
Don HO bbc55d06f2
Code improvement for WcharMbcsConvertor 2019-08-14 01:54:56 +02:00
Don HO 2c764d7221
Code improvement for FileManager 2019-08-14 01:32:01 +02:00
Don HO 48f83a9d0f
Code improvement for EncodingMapper 2019-08-14 01:15:08 +02:00
Don HO f80b0ed293
Add Npp Pugin List update capacity (in progress) 2019-08-13 23:51:05 +02:00
Rajendra Singh 938dae9b2a
Improve singleton
Close #6036
2019-08-13 12:48:05 +02:00
Don HO 3643a1875b
Make 2 singleton "new-less"
Make WcharMbcsConvertor & FileManager "new-less"
2019-08-11 01:17:53 +02:00
Don HO 3dbb2c4b8e
Make NppParameters singleton "new-less" 2019-08-10 23:53:59 +02:00
wjx0912 fc9dfc86fc
Make EncodingMapper singleton "new-less"
Use the modern way to code Singleton to get rid of the allocation memory.

Close #6031, close #6019
2019-08-10 19:32:57 +02:00
Scott Sumner 0922512eb3
Make "Remove Consecutive Duplicate Lines" to be macro recordable
Fix #6023, close #6024
2019-08-10 13:29:00 +02:00
Waldi Ravens 2a7a35a4a3
Make "Command Argument Help" MessageBox modal
Fix #4067, close #6027
2019-08-10 13:21:46 +02:00
grisha vanika ab4cf88336
Fix Folder as Workspace crash and "queue overflow" issues
Fix crash of Folder as Workspace when too many directory changes happen:
Remove limit for amount of queued directory changes: use auto-reset Event instead of Semaphore.

Fix #6005, fix #5907, fix #3740, close #6005
2019-08-07 14:14:59 +02:00
Scott Sumner 9d79d6c017
Fix "preventing Find All Curr Doc working in macro" issue
Fix #5973, close #6006
2019-08-07 09:37:34 +02:00
Scott Sumner cd9f761293
Make backward-dir checkbox be shown on Find window's Mark tab
Fix #5974, close #6016
2019-08-07 09:27:27 +02:00
Don HO c35a2b5708
Make Combobox font monospace in Find dialog
Close #5920, fix #3361, close #6001
2019-08-05 02:45:01 +02:00
Cyrillev 053823e8ca
Fix check sign in Encoding menu not shown issue
Fix #3737, close #3738
2019-08-05 00:00:22 +02:00
Berner Martin d901c73f7d
Add PL/SQL to FunctionList
Close #3741
2019-08-04 12:40:55 +02:00
Simon Sobisch a5ec6be8a9
Enhance COBOL language support - function list & auto-completion
COBOL support in function list - new entries in functionList.xml (note: defaults to fixed-form reference format, manual switch to free-form reference-format possible in association for langID 50)

COBOL support in auto-completion - new file APIs/cobol.xml
COBOL syntax highlighter - recreated list

note: list of statements, functions and reserved words token from GnuCOBOL 3.0 (COBOL85,2002,2014 + extensions from IBM/MF/RM/ACUCOBOL), please report back if any words are missing

Close #4004
2019-08-04 00:54:18 +02:00
Scott Sumner 61abf06bf3
Make 'Clear all marks' and 'Inverse Bookmark' macroable
Fix #1948, close #5995
2019-08-03 16:26:25 +02:00
Micha Wiedenmann b3a6638b93
'-nosession' must not overwrite config.xml (Fix #3938)
When `-nosession` is given as a command line parameter the attribute
`isSnapshotMode` in `config.xml` is overwritten with `no` regardless of
its original value.

    <GUIConfig name="Backup" action="0" useCustumDir="no"
               dir="" isSnapshotMode="yes" snapshotBackupTiming="7000" />

Change this to keep the original value.

Fix #3938, close #5845
2019-08-03 01:10:49 +02:00
Don HO fb7785eeaa
Disambiguate 5 entries regarding encoding
Remove "Encode" word to avoid the confusion with "Convert".

Close #5951
2019-07-30 20:24:59 +02:00
Don HO e50236f559
Remove redundant information in File Summary dialog
Update Chinese & French binary translation as well.
2019-07-27 11:03:14 +02:00
Christian Grasser 418d03acfe
Add capabilty to translate file summary dialog info
Close #5594, fix #1487
2019-07-27 10:33:51 +02:00
Don HO 4a80a125c0
Fix the crash due to NPPM_DESTROYSCINTILLAHANDLE message
Destroying allocated Scintilla makes Notepad++ crash because created Scintilla view's pointer is added into _referees of Buffer object automatically.
The deallocated scintilla view in _referees is used in Buffer::nextUntitledNewNumber().

So we do nothing here and let Notepad++ destroys allocated Scintilla while it exit and we keep this message for the sake of compability withe the existing plugins.

Fix #4487, close #1500, close #5949
2019-07-26 09:39:52 +02:00
Don HO cfcca9f54a
UI position tuning
Close #5935
2019-07-23 01:59:30 +02:00
Don HO 4c7e18fd58
Fix PowerEditor compiling error 2019-07-22 13:45:31 +02:00
luisffranca 69da7a765d
Make context menu key work in Project Panel
Fix #3868, close #3871
2019-07-22 13:00:52 +02:00