Use the _isFolding flag to fix several overlooked edge case hangs. This pull request fixes additional hangs I found after #4867 when working with deeply-nested fully-folded files. The hangs are easy to reproduce by following these steps: Download the sample file https://raw.githubusercontent.com/notepad-plus-plus/notepad-plus-plus/master/PowerEditor/src/Parameters.cpp Open the downloaded file by itself in NPP and fold it using Alt-0 Create a new empty tab and remain focused on it Perform the six actions below, each of which will produce a hang as NPP tries to change focus back to the first tab. On my machine, each hang lasts about 30 seconds. After control returns, refocus the empty tab again and try the next action. Use File>>Open to reopen the downloaded file, even though it is already open Drag and drop the downloaded file onto NPP to reopen it Double-click the downloaded file to reopen it Right-click the downloaded file and select Edit with Notepad++ in the context menu Open the downloaded file from the command line: C:\Program Files (x86)\Notepad++\notepad++.exe" .\Parameters.cpp Click the red [X] in the upper right corner to close NPP After applying the patch, none of the hangs should happen any more. Close #4999pull/4947/head^2
parent
6cdac077f2
commit
fd51703ad8
Loading…
Reference in new issue