From e8ed195aac85f3273ce242a363dc8aab92e0e8c1 Mon Sep 17 00:00:00 2001 From: Don Ho Date: Mon, 27 Jun 2022 22:23:30 +0200 Subject: [PATCH] Exclude an unstable version of one plugin from the installer Ref: https://community.notepad-plus-plus.org/topic/23100/notepad-8-4-2-64-bit-suddenly-closes-for-no-reason --- .../installer/nsisInclude/mainSectionFuncs.nsh | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh b/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh index 48d2f5d0f..fdc6523c1 100644 --- a/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh +++ b/PowerEditor/installer/nsisInclude/mainSectionFuncs.nsh @@ -298,9 +298,19 @@ XMLToolsTestEnd64: MessageBox MB_OK "Due to NppTaskList plugin's incompatibility issue in version $R0, NppTaskList.dll will be deleted. Use Plugins Admin to add back (the latest version of) NppTaskList." /SD IDOK Rename "$INSTDIR\plugins\NppTaskList\NppTaskList.dll" "$INSTDIR\plugins\disabled\NppTaskList.dll" Delete "$INSTDIR\plugins\NppTaskList\NppTaskList.dll" - NppTaskListTestEnd64: + ; jN makes Notepad++ x64 crash. "2.2.185.7" is its 1st version which contains the fix + IfFileExists "$INSTDIR\plugins\jN\jN.dll" 0 jN64 + ${GetFileVersion} "$INSTDIR\plugins\jN\jN.dll" $R0 + ${VersionCompare} $R0 "2.2.185.7" $R1 ; 0: equal to 2.2.185.7 1: $R0 is newer 2: 2.4 is newer + StrCmp $R1 "0" +5 0 ; if equal skip all & go to end, else go to next + StrCmp $R1 "1" +4 0 ; if newer skip all & go to end, else older (2) then go to next + MessageBox MB_OK "Due to jN plugin's incompatibility issue in version $R0, jN.dll will be deleted. Use Plugins Admin to add back (the latest version of) jN." /SD IDOK + Rename "$INSTDIR\plugins\jN\jN.dll" "$INSTDIR\plugins\disabled\jN.dll" + Delete "$INSTDIR\plugins\jN\jN.dll" +jN64: + IfFileExists "$INSTDIR\plugins\NppQCP\NppQCP.dll" 0 NppQCPTestEnd64 MessageBox MB_OK "Due to NppQCP plugin's crash issue on Notepad++ x64 binary, NppQCP.dll will be removed." /SD IDOK