github
/
notepad-plus-plus
mirror of https://github.com/notepad-plus-plus/notepad-plus-plus
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Make NPPN_FILEBEFORERENAME notification more efficient

pull/15314/head
Don Ho 2024-06-16 23:55:42 +02:00
parent 5b36e097c2
commit 9a27df8f13
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
PowerEditor/src/NppIO.cpp
View File

@ -1874,7 +1874,6 @@ bool Notepad_plus::fileRename(BufferID id)
scnN.nmhdr.code = NPPN_FILEBEFORERENAME;
scnN.nmhdr.hwndFrom = _pPublicInterface->getHSelf();
scnN.nmhdr.idFrom = (uptr_t)bufferID;
_pluginsManager.notify(&scnN);
bool success = false;
bool isFileExisting = PathFileExists(buf->getFullPathName()) != FALSE;
@ -1893,7 +1892,12 @@ bool Notepad_plus::fileRename(BufferID id)
std::wstring fn = fDlg.doSaveDlg();
if (!fn.empty())
{
_pluginsManager.notify(&scnN);
success = MainFileManager.moveFile(bufferID, fn.c_str());
scnN.nmhdr.code = success ? NPPN_FILERENAMED : NPPN_FILERENAMECANCEL;
_pluginsManager.notify(&scnN);
}
}
else
{
@ -1941,8 +1945,13 @@ bool Notepad_plus::fileRename(BufferID id)
}
else
{
success = true;
_pluginsManager.notify(&scnN);
buf->setFileName(tabNewNameStr.c_str());
scnN.nmhdr.code = NPPN_FILERENAMED;
_pluginsManager.notify(&scnN);
success = true;
bool isSnapshotMode = NppParameters::getInstance().getNppGUI().isSnapshotMode();
if (isSnapshotMode)
{
@ -1963,9 +1972,6 @@ bool Notepad_plus::fileRename(BufferID id)
}
}
scnN.nmhdr.code = success ? NPPN_FILERENAMED : NPPN_FILERENAMECANCEL;
_pluginsManager.notify(&scnN);
return success;
}