github
/
notepad-plus-plus
mirror of https://github.com/notepad-plus-plus/notepad-plus-plus
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix "Save As" command cannot be used as "Save" issue 

If user tries to save a existing file as file itself by using "Save As" command,
then he/she chooses the same file from the Save As file dialog,
* old wrong behaviour: "Save As" action is rejected with the message "The file is already opened in Notepad++".
* new correct behaviour: "Save As" action is allowed.

Fix #10965, close #11008
pull/11013/head
Don Ho 2022-01-07 19:13:16 +01:00
parent 9be4eeb4e6
commit 44c9a0561b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
PowerEditor/src/NppIO.cpp
View File

@ -1708,10 +1708,10 @@ bool Notepad_plus::fileSaveAs(BufferID id, bool isSaveCopy)
if (other == BUFFER_INVALID)
other = _pNonDocTab->findBufferByName(fn.c_str());
if (other == BUFFER_INVALID) //can save, as both (same and other) view don't contain buffer
if (other == BUFFER_INVALID // both (current and other) views don't contain the same file (path), "Save As" action is allowed.
|| other->getID() == bufferID->getID()) // or if user saves the file by using "Save As" instead of "Save" (ie. in "Save As" dialog to chooses the same file), then it's still legit.
{
bool res = doSave(bufferID, fn.c_str(), isSaveCopy);
//buf->setNeedsLexing(true); //commented to fix wrapping being removed after save as (due to SCI_CLEARSTYLE or something, seems to be Scintilla bug)
//Changing lexer after save seems to work properly
if (!wasUntitled && !isSaveCopy)
{