Make sure we cleanup the sys fixtures before unpacking to avoid obsolete
files and conflicts from sticking around.
Signed-off-by: Ben Kochie <superq@gmail.com>
The all target should abort on incorrectly formatted code, instead of
formatting it. The CI pipeline should fail and not silently accept
wrong code.
Signed-off-by: Tobias Schmidt <tobidt@gmail.com>
* cpu: Add a 2nd label 'package' to metric node_cpu_core_throttles_total
This commit fixes the node_cpu_core_throttles_total metrics on
multi-socket systems as the core_ids are the same for each package.
I.e. we need to count them seperately.
Rename the node_package_throttles_total metric label `node` to `package`.
Reorganize the sys.ttar archive and use the same symlinks as the Linux
kernel. Also, the new fixtures now use a dual-socket dual-core cpu w/o
HT/SMT (node0: cpu0+1, node1: cpu2+3) as well as processor-less
(memory-only) NUMA node 'node2' (this is a very rare case).
Signed-off-by: Karsten Weiss <knweiss@gmail.com>
* cpu: Use the direct /sys path to the cpu files.
Use the direct path /sys/devices/system/cpu/cpu[0-9]* (without symlinks)
instead of /sys/bus/cpu/devices/cpu[0-9]*.
The latter path also does not exist e.g. on RHEL 6.9's kernel.
Signed-off-by: Karsten Weiss <knweiss@gmail.com>
* cpu: Reverse core+package throttle processing order
Signed-off-by: Karsten Weiss <knweiss@gmail.com>
* cpu: Add documentation URLs
Signed-off-by: Karsten Weiss <knweiss@gmail.com>
Without this change, running 'gmake' as the documentation does not finish the
build process to produce the binary.
Signed-off-by: Zach Leslie <xaque208@gmail.com>
Netstat is 40% of the metrics on my laptop, many of which
are highly detailed information about IP internals in the kernel.
~300 such metrics on every machine in your fleet is excessive,
so focus on key metrics by default, overridable by the user.
Fixes#515
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Vmstat has over 100 fields, most of which are highly
detailed debug information. Trim this down to only
essential fields by default, configurable by flag.
Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
* Add example LaunchCtl-file for MacOS
Signed-off-by: Morten Siebuhr <sbhr@sbhr.dk>
* Rewrite program location in launctctl file
This seem to be the way most plist files does it.
Signed-off-by: Morten Siebuhr <sbhr@sbhr.dk>
* Make launct-agent run as nobody/nobody
Signed-off-by: Morten Siebuhr <sbhr@sbhr.dk>
* Rename plist per general naming scheme
Signed-off-by: Morten Siebuhr <sbhr@sbhr.dk>
* Pass arguments-file when launched through launchctl
Signed-off-by: Morten Siebuhr <sbhr@sbhr.dk>
* Only report core throttles per core, not per cpu
* Add topology/core_id to the cpu sysfs fixtures
* Add new cpu fixtures to ttar file
* Merge core_id reading and thermal throttle accounting
* Declare core_id
Ben Kochie