Browse Source

Make filesystem collector more robust.

Current behaviour throws away all stats on any Statfs error. In practice
this is not useful. This turns such errors into debug log messages -
though silently ignoring them seems even more valid to me.
pull/143/head
Kevin Lyda 9 years ago
parent
commit
36291d456e
  1. 4
      collector/filesystem_linux.go

4
collector/filesystem_linux.go

@ -17,7 +17,6 @@ package collector
import ( import (
"bufio" "bufio"
"fmt"
"os" "os"
"strings" "strings"
"syscall" "syscall"
@ -54,8 +53,9 @@ func (c *filesystemCollector) GetStats() (stats []filesystemStats, err error) {
buf := new(syscall.Statfs_t) buf := new(syscall.Statfs_t)
err := syscall.Statfs(mpd.mountPoint, buf) err := syscall.Statfs(mpd.mountPoint, buf)
if err != nil { if err != nil {
return nil, fmt.Errorf("Statfs on %s returned %s", log.Debugf("Statfs on %s returned %s",
mpd.mountPoint, err) mpd.mountPoint, err)
continue
} }
labelValues := []string{mpd.device, mpd.mountPoint, mpd.fsType} labelValues := []string{mpd.device, mpd.mountPoint, mpd.fsType}

Loading…
Cancel
Save