Browse Source

Merge pull request #481 from prometheus/grobie/goreportcard

Add goreportcard
pull/482/head
Tobias Schmidt 8 years ago committed by GitHub
parent
commit
1a76b5e861
  1. 4
      README.md
  2. 2
      collector/mountstats_linux.go
  3. 6
      collector/nfs_linux.go
  4. 8
      collector/systemd_linux_test.go

4
README.md

@ -3,11 +3,12 @@
[![CircleCI](https://circleci.com/gh/prometheus/node_exporter/tree/master.svg?style=shield)][circleci]
[![Docker Repository on Quay](https://quay.io/repository/prometheus/node-exporter/status)][quay]
[![Docker Pulls](https://img.shields.io/docker/pulls/prom/node-exporter.svg?maxAge=604800)][hub]
[![Go Report Card](https://goreportcard.com/badge/github.com/prometheus/node_exporter)][goreportcard]
Prometheus exporter for hardware and OS metrics exposed by \*NIX kernels, written
in Go with pluggable metric collectors.
The [WMI exporter](https://github.com/martinlindhe/wmi_exporter) is recommended for Windows users.
The [WMI exporter](https://github.com/martinlindhe/wmi_exporter) is recommended for Windows users.
## Collectors
@ -135,3 +136,4 @@ Be aware though that the mountpoint label in various metrics will now have
[hub]: https://hub.docker.com/r/prom/node-exporter/
[circleci]: https://circleci.com/gh/prometheus/node_exporter
[quay]: https://quay.io/repository/prometheus/node-exporter
[goreportcard]: https://goreportcard.com/report/github.com/prometheus/node_exporter

2
collector/mountstats_linux.go

@ -419,7 +419,7 @@ func NewMountStatsCollector() (Collector, error) {
NFSEventVFSLockTotal: prometheus.NewDesc(
prometheus.BuildFQName(Namespace, subsystem, "event_vfs_lock_total"),
"Number of times locking has been attemped on a file.",
"Number of times locking has been attempted on a file.",
labels,
nil,
),

6
collector/nfs_linux.go

@ -31,20 +31,20 @@ var (
procLineRE = regexp.MustCompile(`^proc(\d+) \d+ (\d+( \d+)*)$`)
nfsProcedures = map[string][]string{
"2": []string{
"2": {
"null", "getattr", "setattr", "root", "lookup",
"readlink", "read", "writecache", "write", "create",
"remove", "rename", "link", "symlink", "mkdir",
"rmdir", "readdir", "statfs",
},
"3": []string{
"3": {
"null", "getattr", "setattr", "lookup", "access",
"readlink", "read", "write", "create", "mkdir",
"symlink", "mknod", "remove", "rmdir", "rename",
"link", "readdir", "readdirplus", "fsstat", "fsinfo",
"pathconf", "commit",
},
"4": []string{
"4": {
"null", "read", "write", "commit", "open",
"open_confirm", "open_noattr", "open_downgrade",
"close", "setattr", "fsinfo", "renew", "setclientid",

8
collector/systemd_linux_test.go

@ -24,7 +24,7 @@ import (
// Creates mock UnitLists
func getUnitListFixtures() [][]dbus.UnitStatus {
fixture1 := []dbus.UnitStatus{
dbus.UnitStatus{
{
Name: "foo",
Description: "foo desc",
LoadState: "loaded",
@ -36,7 +36,7 @@ func getUnitListFixtures() [][]dbus.UnitStatus {
JobType: "",
JobPath: "/",
},
dbus.UnitStatus{
{
Name: "bar",
Description: "bar desc",
LoadState: "not-found",
@ -48,7 +48,7 @@ func getUnitListFixtures() [][]dbus.UnitStatus {
JobType: "",
JobPath: "/",
},
dbus.UnitStatus{
{
Name: "foobar",
Description: "bar desc",
LoadState: "not-found",
@ -60,7 +60,7 @@ func getUnitListFixtures() [][]dbus.UnitStatus {
JobType: "",
JobPath: "/",
},
dbus.UnitStatus{
{
Name: "baz",
Description: "bar desc",
LoadState: "not-found",

Loading…
Cancel
Save