Browse Source

Fix typo on description of read_time_seconds_total (#1057)

Fix typo on unit description of metric `*read_time_seconds_total` from milliseconds to seconds.

Signed-off-by: Marco Tulio R Braga <marco.tulio@mtulio.eng.br>
pull/1234/head
Marco Tulio R Braga 6 years ago committed by Ben Kochie
parent
commit
05e55bddad
  1. 2
      collector/diskstats_linux.go
  2. 2
      collector/fixtures/e2e-64k-page-output.txt
  3. 2
      collector/fixtures/e2e-output.txt

2
collector/diskstats_linux.go

@ -96,7 +96,7 @@ func NewDiskstatsCollector() (Collector, error) {
{
desc: prometheus.NewDesc(
prometheus.BuildFQName(namespace, diskSubsystem, "read_time_seconds_total"),
"The total number of milliseconds spent by all reads.",
"The total number of seconds spent by all reads.",
diskLabelNames,
nil,
), valueType: prometheus.CounterValue,

2
collector/fixtures/e2e-64k-page-output.txt

@ -350,7 +350,7 @@ node_disk_read_bytes_total{device="nvme0n1"} 2.377714176e+09
node_disk_read_bytes_total{device="sda"} 5.13713216512e+11
node_disk_read_bytes_total{device="sr0"} 0
node_disk_read_bytes_total{device="vda"} 1.6727491584e+10
# HELP node_disk_read_time_seconds_total The total number of milliseconds spent by all reads.
# HELP node_disk_read_time_seconds_total The total number of seconds spent by all reads.
# TYPE node_disk_read_time_seconds_total counter
node_disk_read_time_seconds_total{device="dm-0"} 46229.572
node_disk_read_time_seconds_total{device="dm-1"} 0.084

2
collector/fixtures/e2e-output.txt

@ -350,7 +350,7 @@ node_disk_read_bytes_total{device="nvme0n1"} 2.377714176e+09
node_disk_read_bytes_total{device="sda"} 5.13713216512e+11
node_disk_read_bytes_total{device="sr0"} 0
node_disk_read_bytes_total{device="vda"} 1.6727491584e+10
# HELP node_disk_read_time_seconds_total The total number of milliseconds spent by all reads.
# HELP node_disk_read_time_seconds_total The total number of seconds spent by all reads.
# TYPE node_disk_read_time_seconds_total counter
node_disk_read_time_seconds_total{device="dm-0"} 46229.572
node_disk_read_time_seconds_total{device="dm-1"} 0.084

Loading…
Cancel
Save