k3s/proxy at fe465cc83253fbc9139418f8a2a6254d24af1888 - k3s

History

Brad Davidson 11072e2516 Fix occasional "TLS handshake error" in apiserver network proxy. We should be reading from the hijacked bufio.ReaderWriter instead of directly from the net.Conn. There is a race condition where the underlying http handler may consume bytes from the hijacked request stream, if it comes in the same packet as the CONNECT header. These bytes are left in the buffered reader, which we were not using. This was causing us to occasionally drop a few bytes from the start of the tunneled connection's client data stream. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>	2 years ago
..
proxy.go	Fix occasional "TLS handshake error" in apiserver network proxy.	2 years ago

Brad Davidson 11072e2516 Fix occasional "TLS handshake error" in apiserver network proxy.

We should be reading from the hijacked bufio.ReaderWriter instead of
directly from the net.Conn. There is a race condition where the
underlying http handler may consume bytes from the hijacked request
stream, if it comes in the same packet as the CONNECT header. These
bytes are left in the buffered reader, which we were not using. This was
causing us to occasionally drop a few bytes from the start of the
tunneled connection's client data stream.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>

proxy.go

Fix occasional "TLS handshake error" in apiserver network proxy.