k3s/pkg
Kubernetes Submit Queue 0820d4c3d0
Merge pull request #57991 from karataliu/azure_lb_exists
Automatic merge from submit-queue (batch tested with PRs 57991, 57789). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix exists status for azure GetLoadBalancer

**What this PR does / why we need it**:

We see a lot of log indicating load balancer not found in azure:
```
E0109 07:00:31.126306       1 service_controller.go:776] Failed to process service kube-system/heapster. Retrying in 5m0s: error getting LB for service kube-system/heapster: Service(kube-system/heapster) - Loadbalancer not found
I0109 07:00:31.126384       1 event.go:218] Event(v1.ObjectReference{Kind:"Service", Namespace:"kube-system", Name:"heapster", UID:"400266e7-f507-11e7-bbc2-000d3af86f66", APIVersion:"v1", ResourceVersion:"450", FieldPath:""}): type: 'Warning' reason: 'CreatingLoadBalancerFailed' Error creating load balancer (will retry): error getting LB for service kube-system/heapster: Service(kube-system/heapster) - Loadbalancer not found
I0109 07:00:31.158858       1 azure_backoff.go:177] LoadBalancerClient.List(name) - backoff: success
E0109 07:00:31.158930       1 service_controller.go:776] Failed to process service kube-system/kubernetes-dashboard. Retrying in 5m0s: error getting LB for service kube-system/kubernetes-dashboard: Service(kube-system/kubernetes-dashboard) - Loadbalancer not found
I0109 07:00:31.158988       1 event.go:218] Event(v1.ObjectReference{Kind:"Service", Namespace:"kube-system", Name:"kubernetes-dashboard", UID:"4052f12b-f507-11e7-bbc2-000d3af86f66", APIVersion:"v1", ResourceVersion:"498", FieldPath:""}): type: 'Warning' reason: 'CreatingLoadBalancerFailed' Error creating load balancer (will retry): error getting LB for service kube-system/kubernetes-dashboard: Service(kube-system/kubernetes-dashboard) - Loadbalancer not found
```

It's interesting that those service does not need loadbalancer, and caller is just checking whether one loadbalancer exists.
009701f181/pkg/controller/service/service_controller.go (L287)

And in we can see when err is not nil, it will not check exists value. Thus we should not return error when exists=false.

This was changed in:
edfb2ad552 (diff-c901394068476b4ccb003a6c6efad57cR63)

The PR removes the error when exists=false.

**Which issue(s) this PR fixes**

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```
2018-01-09 07:31:31 -08:00
..
api Merge pull request #56680 from weekface/weekface/tiny-fix 2018-01-03 09:22:22 -08:00
apis Merge pull request #57170 from jiayingz/validation 2018-01-05 16:01:33 -08:00
auth Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
bootstrap/api Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
capabilities Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
client Update generated files 2018-01-02 22:13:19 -08:00
cloudprovider Merge pull request #57991 from karataliu/azure_lb_exists 2018-01-09 07:31:31 -08:00
controller Merge pull request #57930 from zhangxiaoyu-zidif/refactor-service-with-sets 2018-01-08 13:54:33 -08:00
credentialprovider Merge pull request #57179 from chrislovecnm/aws-creds-owners 2018-01-07 09:08:31 -08:00
features Merge pull request #56939 from derekwaynecarr/hugepages-graduate 2018-01-05 17:52:38 -08:00
fieldpath Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
generated generated 2017-11-22 18:40:09 +00:00
kubeapiserver Merge pull request #56608 from hzxuzhonghu/fix-typo 2018-01-04 15:28:05 -08:00
kubectl Merge pull request #55576 from miaoyq/using-sort.slice 2018-01-07 12:06:04 -08:00
kubelet Merge pull request #57734 from stewart-yu/removeGetBuggyHostportChain 2018-01-08 22:40:22 -08:00
kubemark Move ungated 'alpha' KubeletConfiguration fields and self-registration fields to KubeletFlags 2017-11-15 17:47:10 -08:00
master Use race="off" mode instead of disabling race feature 2017-12-23 13:13:09 -08:00
printers Merge pull request #56680 from weekface/weekface/tiny-fix 2018-01-03 09:22:22 -08:00
probe Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
proxy Merge pull request #57317 from m1093782566/notfound 2018-01-05 17:52:41 -08:00
quota Merge pull request #57027 from CaoShuFeng/resourcequota_validation_pod 2018-01-02 13:15:47 -08:00
registry Regenerate all generated code 2018-01-02 00:21:07 -08:00
routes Update Dashboard add-on to version 1.8.0 2017-11-28 17:53:02 +01:00
scheduler Refactor HostIP predicate algorithm 2018-01-08 17:10:21 -08:00
security Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
securitycontext Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
serviceaccount typo wrong, not "namespace", but "secretName" 2017-12-15 09:27:52 +08:00
ssh Autogenerate BUILD files 2017-12-23 13:12:11 -08:00
util Merge pull request #57317 from m1093782566/notfound 2018-01-05 17:52:41 -08:00
version Capture git export-subst strings in version.sh for 'git archive' use. 2017-11-09 16:36:27 -08:00
volume Merge pull request #56651 from sbezverk/block_rbd_volume_plugin 2018-01-08 09:12:49 -08:00
watch
.import-restrictions
BUILD Fix scheduler refs in BUILD files. 2018-01-05 15:05:01 -08:00
OWNERS