mirror of https://github.com/k3s-io/k3s
![]() Automatic merge from submit-queue (batch tested with PRs 45033, 44961, 45021, 45097, 44938) Cleanup orphan logging that goes on in the sync loop. **What this PR does / why we need it**: Fixes #44937 **Before this PR** The older logs were like this: ``` E0426 00:06:33.763347 21247 kubelet_volumes.go:114] Orphaned pod "35c4a858-2a12-11e7-910c-42010af00003" found, but volume paths are still present on disk. E0426 00:06:33.763400 21247 kubelet_volumes.go:114] Orphaned pod "e7676365-1580-11e7-8c27-42010af00003" found, but volume paths are still present on disk. ``` The problem being that, all the volumes were spammed w/ no summary info. **After this PR** the logs look like this: ``` E0426 01:32:27.295568 22261 kubelet_volumes.go:129] Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. : There were a total of 2 errors similar to this. Turn up verbosity to see them. E0426 01:32:29.295515 22261 kubelet_volumes.go:129] Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. : There were a total of 2 errors similar to this. Turn up verbosity to see them. E0426 01:32:31.293180 22261 kubelet_volumes.go:129] Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. : There were a total of 2 errors similar to this. Turn up verbosity to see them. ``` And with logging turned up, the extra info logs are shown with details: ``` E0426 01:34:21.933983 26010 kubelet_volumes.go:129] Orphaned pod "1c565800-2a20-11e7-bbc2-42010af00003" found, but volume paths are still present on disk. : There were a total of 3 errors similar to this. Turn up verbosity to see them. I0426 01:34:21.934010 26010 kubelet_volumes.go:131] Orphan pod: Orphaned pod "1c565800-2a20-11e7-bbc2-42010af00003" found, but volume paths are still present on disk. I0426 01:34:21.934015 26010 kubelet_volumes.go:131] Orphan pod: Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. I0426 01:34:21.934019 26010 kubelet_volumes.go:131] Orphan pod: Orphaned pod "e7676365-1580-11e7-8c27-42010af00003" found, but volume paths are still present on disk. ``` **Release note** ```release-note Roll up volume error messages in the kubelet sync loop. ``` |
||
---|---|---|
.. | ||
api | ||
cadvisor | ||
certificate | ||
client | ||
cm | ||
config | ||
container | ||
custommetrics | ||
dockershim | ||
dockertools | ||
envvars | ||
events | ||
eviction | ||
gpu | ||
images | ||
kuberuntime | ||
leaky | ||
lifecycle | ||
metrics | ||
network | ||
pleg | ||
pod | ||
preemption | ||
prober | ||
qos | ||
remote | ||
rkt | ||
rktshim | ||
secret | ||
server | ||
status | ||
sysctl | ||
types | ||
util | ||
volumemanager | ||
BUILD | ||
OWNERS | ||
active_deadline.go | ||
active_deadline_test.go | ||
disk_manager.go | ||
disk_manager_test.go | ||
doc.go | ||
kubelet.go | ||
kubelet_cadvisor.go | ||
kubelet_cadvisor_test.go | ||
kubelet_getters.go | ||
kubelet_getters_test.go | ||
kubelet_network.go | ||
kubelet_network_test.go | ||
kubelet_node_status.go | ||
kubelet_node_status_test.go | ||
kubelet_pods.go | ||
kubelet_pods_test.go | ||
kubelet_pods_windows_test.go | ||
kubelet_resources.go | ||
kubelet_resources_test.go | ||
kubelet_test.go | ||
kubelet_volumes.go | ||
kubelet_volumes_test.go | ||
networks.go | ||
oom_watcher.go | ||
oom_watcher_test.go | ||
pod_container_deletor.go | ||
pod_container_deletor_test.go | ||
pod_workers.go | ||
pod_workers_test.go | ||
reason_cache.go | ||
reason_cache_test.go | ||
runonce.go | ||
runonce_test.go | ||
runtime.go | ||
util.go | ||
volume_host.go |