k3s/pkg/kubelet
Kubernetes Submit Queue e06fc087e0 Merge pull request #44938 from jayunit100/cleanup-orphan-logging
Automatic merge from submit-queue (batch tested with PRs 45033, 44961, 45021, 45097, 44938)

Cleanup orphan logging that goes on in the sync loop.

**What this PR does / why we need it**:

Fixes #44937  

**Before this PR** The older logs were like this:

```
E0426 00:06:33.763347   21247 kubelet_volumes.go:114] Orphaned pod "35c4a858-2a12-11e7-910c-42010af00003" found, but volume paths are still present on disk.
E0426 00:06:33.763400   21247 kubelet_volumes.go:114] Orphaned pod "e7676365-1580-11e7-8c27-42010af00003" found, but volume paths are still present on disk.
```

The problem being that, all the volumes were spammed w/ no summary info.   

**After this PR** the logs look like this:

```
E0426 01:32:27.295568   22261 kubelet_volumes.go:129] Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. : There were a total of 2 errors similar to this.  Turn up verbosity to see them.
E0426 01:32:29.295515   22261 kubelet_volumes.go:129] Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. : There were a total of 2 errors similar to this.  Turn up verbosity to see them.
E0426 01:32:31.293180   22261 kubelet_volumes.go:129] Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk. : There were a total of 2 errors similar to this.  Turn up verbosity to see them.
```

And with logging turned up, the extra info logs are shown with details:

```
E0426 01:34:21.933983   26010 kubelet_volumes.go:129] Orphaned pod "1c565800-2a20-11e7-bbc2-42010af00003" found, but volume paths are still present on disk. : There were a total of 3 errors similar to this.  Turn up verbosity to see them.
I0426 01:34:21.934010   26010 kubelet_volumes.go:131] Orphan pod: Orphaned pod "1c565800-2a20-11e7-bbc2-42010af00003" found, but volume paths are still present on disk.
I0426 01:34:21.934015   26010 kubelet_volumes.go:131] Orphan pod: Orphaned pod "408b060e-2a1d-11e7-90e8-42010af00003" found, but volume paths are still present on disk.
I0426 01:34:21.934019   26010 kubelet_volumes.go:131] Orphan pod: Orphaned pod "e7676365-1580-11e7-8c27-42010af00003" found, but volume paths are still present on disk.
```

**Release note**

```release-note
Roll up volume error messages in the kubelet sync loop.
```
2017-04-28 13:16:47 -07:00
..
api autogenerated 2017-04-14 10:40:57 -07:00
cadvisor autogenerated 2017-04-14 10:40:57 -07:00
certificate Add bootstrap support to certificate manager. 2017-04-20 16:27:32 -07:00
client autogenerated 2017-04-14 10:40:57 -07:00
cm Registered node before other initialization. 2017-04-18 10:43:56 +08:00
config autogenerated 2017-04-14 10:40:57 -07:00
container move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod 2017-04-17 11:38:11 -07:00
custommetrics Merge pull request #44469 from siggy/siggy/custom-metrics-comment 2017-04-17 19:59:16 -07:00
dockershim move pkg/api/v1/helpers.go to subpackage 2017-04-14 14:25:11 -07:00
dockertools don't HandleError on container start failure 2017-04-26 23:00:39 -05:00
envvars move pkg/api/v1/helpers.go to subpackage 2017-04-14 14:25:11 -07:00
events autogenerated 2017-04-14 10:40:57 -07:00
eviction still consider quantity reclaimed even when errors are returned 2017-04-26 17:40:30 -07:00
gpu autogenerated 2017-04-14 10:40:57 -07:00
images autogenerated 2017-04-14 10:40:57 -07:00
kuberuntime move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod 2017-04-17 11:38:11 -07:00
leaky Enable auto-generating sources rules 2017-01-05 14:14:13 -08:00
lifecycle autogenerated 2017-04-14 10:40:57 -07:00
metrics autogenerated 2017-04-14 10:40:57 -07:00
network Merge pull request #44642 from supereagle/fix-comment-error 2017-04-21 11:52:07 -07:00
pleg autogenerated 2017-04-14 10:40:57 -07:00
pod autogenerated 2017-04-14 10:40:57 -07:00
preemption move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod 2017-04-17 11:38:11 -07:00
prober Merge pull request #42085 from cblecker/gofmt-fix 2017-04-17 15:39:07 -07:00
qos autogenerated 2017-04-14 10:40:57 -07:00
remote Fix StopContainer timeout 2017-04-26 15:48:12 -07:00
rkt Merge pull request #44467 from JulienBalestra/fix-rkt-host-path-volume 2017-04-17 20:06:59 -07:00
rktshim Merge pull request #39158 from feiskyer/cri-proto3 2017-01-20 08:28:49 -08:00
secret autogenerated 2017-04-14 10:40:57 -07:00
server bazel 2017-04-27 09:41:53 -07:00
status move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod 2017-04-17 11:38:11 -07:00
sysctl move pkg/api/v1/helpers.go to subpackage 2017-04-14 14:25:11 -07:00
types Improved code coverage for /pkg/kubelet/types 2017-04-25 06:25:21 +08:00
util autogenerated 2017-04-14 10:40:57 -07:00
volumemanager find and add active pods for dswp 2017-04-18 11:21:37 +08:00
BUILD move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod 2017-04-17 11:38:11 -07:00
OWNERS Small fix in kubelet owner file. 2017-01-19 11:04:57 -08:00
active_deadline.go move client/record 2017-01-31 19:14:13 -05:00
active_deadline_test.go move client/record 2017-01-31 19:14:13 -05:00
disk_manager.go
disk_manager_test.go
doc.go
kubelet.go Registered node before other initialization. 2017-04-18 10:43:56 +08:00
kubelet_cadvisor.go start the apimachinery repo 2017-01-11 09:09:48 -05:00
kubelet_cadvisor_test.go Use the assert/require package in kubelet unit tests 2017-03-16 10:21:44 -07:00
kubelet_getters.go kubelet: Fix ConfigMap on Windows. 2017-01-24 18:40:49 +00:00
kubelet_getters_test.go Use the assert/require package in kubelet unit tests 2017-03-16 10:21:44 -07:00
kubelet_network.go Fixed forming of pod's Search line in resolv.conf: 2017-01-17 13:18:26 +00:00
kubelet_network_test.go Use the assert/require package in kubelet unit tests 2017-03-16 10:21:44 -07:00
kubelet_node_status.go move pkg/api/v1/helpers.go to subpackage 2017-04-14 14:25:11 -07:00
kubelet_node_status_test.go Use the assert/require package in kubelet unit tests 2017-03-16 10:21:44 -07:00
kubelet_pods.go extract content-generation concern from `ensureHostsFile` 2017-04-24 12:33:45 -07:00
kubelet_pods_test.go extract content-generation concern from `ensureHostsFile` 2017-04-24 12:33:45 -07:00
kubelet_pods_windows_test.go kubelet: Fix ConfigMap on Windows. 2017-01-24 18:40:49 +00:00
kubelet_resources.go move pkg/api/v1/ref.go and pkg/api/v1/resource.go to subpackages. move some functions in resource.go to pkg/api/v1/node and pkg/api/v1/pod 2017-04-17 11:38:11 -07:00
kubelet_resources_test.go add support for node allocatable phase 2 to kubelet 2017-02-27 21:24:44 -08:00
kubelet_test.go call GetHostIP from makeEnvironment 2017-03-28 20:20:21 -04:00
kubelet_volumes.go Cleanup orphan logging that goes on in the sync loop. 2017-04-25 21:16:22 -04:00
kubelet_volumes_test.go Use the assert/require package in kubelet unit tests 2017-03-16 10:21:44 -07:00
networks.go add portmapping getter into network host 2017-02-08 09:35:04 -08:00
oom_watcher.go switch kubelet to use external (client-go) object references for events 2017-01-31 19:15:33 -05:00
oom_watcher_test.go Use the assert/require package in kubelet unit tests 2017-03-16 10:21:44 -07:00
pod_container_deletor.go start the apimachinery repo 2017-01-11 09:09:48 -05:00
pod_container_deletor_test.go
pod_workers.go increase timeout 2017-02-27 10:59:24 -08:00
pod_workers_test.go move client/record 2017-01-31 19:14:13 -05:00
reason_cache.go start the apimachinery repo 2017-01-11 09:09:48 -05:00
reason_cache_test.go start the apimachinery repo 2017-01-11 09:09:48 -05:00
runonce.go
runonce_test.go Revert "Merge pull request #41202 from dashpole/revert-41095-deletion_pod_lifecycle" 2017-02-15 08:44:03 -08:00
runtime.go Check the health of PLEG when updating the node status 2017-01-10 16:34:00 -08:00
util.go
volume_host.go SecretVolume using secret manager 2017-01-23 16:10:01 +01:00