k3s/pkg/storage
Kubernetes Submit Queue 331eb83585 Merge pull request #33376 from luxas/fix_arm_atomics_2
Automatic merge from submit-queue

Move HighWaterMark to the top of the struct in order to fix arm, second time

ref: #33117

Sorry for not fixing everyone at once, but I seriously wasn't prepared for that quick LGTM 😄, so here's the other half.

@lavalamp 

> lgtm, but seriously, this is terrible, we probably have this bug all over. And what if someone embeds the etcdWatcher struct in something else not at the top? We need the compiler to enforce things like this, it just can't be done manually. Can you file or link a golang issue for this?

I totally agree! There isn't currently a way of programmatically detecting this unfortunately.
I guess @davecheney or @minux can explain better to you why it's so hard.

This is noted in https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/multi-platform.md as a corner case indeed.

@pwittrock This should be cherrypicked toghether with #33117
2016-09-23 12:05:09 -07:00
..
etcd Move HighWaterMark to the top of the struct in order to fix 32-bit platforms 2016-09-20 22:44:56 +03:00
etcd3 Dereference the UID pointer for a readable error message. 2016-09-22 20:34:06 -07:00
storagebackend Revert "Revert "Enable v3 Client as the default on UTs"" 2016-09-14 07:27:21 -05:00
testing Update generated files due to dependency shift. 2016-08-09 10:41:09 -05:00
OWNERS Create pkg/storage/OWNERS 2016-05-25 21:13:10 -07:00
cacher.go Move HighWaterMark to the top of the struct in order to fix arm, second time 2016-09-23 20:58:28 +03:00
cacher_test.go pkg/storage: cleanup Codec() from interface 2016-08-15 20:46:13 -07:00
doc.go Use Go canonical import paths 2016-07-16 13:48:21 -04:00
errors.go Modify IsInvalidObj name and description 2016-08-12 11:17:08 +08:00
interfaces.go Merge pull request #30664 from hongchaodeng/r3 2016-08-17 00:56:05 -07:00
util.go Log water mark for incoming queue in cacher 2016-09-09 11:35:05 +02:00
util_test.go Log water mark for incoming queue in cacher 2016-09-09 11:35:05 +02:00
watch_cache.go Refactor util clock into it's own pkg 2016-07-28 02:29:04 -04:00
watch_cache_test.go Refactor util clock into it's own pkg 2016-07-28 02:29:04 -04:00