mirror of https://github.com/k3s-io/k3s
![]() Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "add node shutdown taint" Reverts kubernetes/kubernetes#59323 Node becomes unready, but is never removed. I've found the following in [kube-controller-manager.log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-autoscaling/6055/artifacts/bootstrap-e2e-master/cluster-autoscaler.log) from test run for one such node: `E0216 01:14:27.084923 1 node_lifecycle_controller.go:686] Error determining if node bootstrap-e2e-minion-group-01b1 shutdown in cloud: failed to get instance ID from cloud provider: instance not found` This goes on for the rest of the run (~6h). Looks like the node is stuck in Unready state because of this check: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L684. Previously, there was no such check and the node was removed. Reverting as this would affect all users attempting to resize their node groups on GCE. ```release-note NONE ``` |
||
---|---|---|
.. | ||
BUILD | ||
OWNERS | ||
aws.go | ||
aws_fakes.go | ||
aws_instancegroups.go | ||
aws_loadbalancer.go | ||
aws_loadbalancer_test.go | ||
aws_metrics.go | ||
aws_routes.go | ||
aws_test.go | ||
aws_utils.go | ||
device_allocator.go | ||
device_allocator_test.go | ||
instances.go | ||
instances_test.go | ||
log_handler.go | ||
regions.go | ||
regions_test.go | ||
retry_handler.go | ||
retry_handler_test.go | ||
sets_ippermissions.go | ||
tags.go | ||
tags_test.go | ||
volumes.go |