mirror of https://github.com/k3s-io/k3s
1ba9202cd8
Automatic merge from submit-queue Conversionlint **What this PR does / why we need it**: This PR adds a comment placeholder for the exported or public functions in conversion generator files. Such functions without a comment results into golint failure in various generated files. The changes in this patch takes care of about 36 related lint failures. Given below is an example lint error, zz_generated.conversion.go:91:1: exported function Convert_v1alpha1_Binding_To_servicecatalog_Binding should have comment or be unexported **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Considering minor changes no issue is created. **Special notes for your reviewer**: Hello, I am trying to fix golint failures as we see them in the kubernetes-incubator/service-catalog project. I have separate PRs opened for lint issues related to other generator code which are in separate libraries like gengo. Thanks! **Release note**: ```release-note ``` |
||
|---|---|---|
| .. | ||
| annotations | ||
| endpoints | ||
| errors | ||
| events | ||
| helper | ||
| install | ||
| meta | ||
| pod | ||
| resource | ||
| service | ||
| testapi | ||
| testing | ||
| unversioned | ||
| util | ||
| v1 | ||
| validation | ||
| BUILD | ||
| OWNERS | ||
| annotation_key_constants.go | ||
| conversion_test.go | ||
| copy_test.go | ||
| deep_copy_test.go | ||
| defaulting_test.go | ||
| defaults.go | ||
| doc.go | ||
| field_constants.go | ||
| json.go | ||
| meta_test.go | ||
| methods.go | ||
| methods_test.go | ||
| node_example.json | ||
| ref.go | ||
| ref_test.go | ||
| register.go | ||
| replication_controller_example.json | ||
| resource_helpers.go | ||
| resource_helpers_test.go | ||
| serialization_proto_test.go | ||
| serialization_test.go | ||
| types.go | ||
| unstructured_test.go | ||
| zz_generated.deepcopy.go | ||