mirror of https://github.com/k3s-io/k3s
c19569f03f
Automatic merge from submit-queue Improvements to CLI usability and maintainability Improves `kubectl` from an usability perspective by 1. Fixing how we handle terminal width in help. Some sections like the flags use the entire available width, while others like long descriptions breaks lines but don't follow a well established max width (screenshot below). This PR adds a new responsive writer that will adjust to terminal width and set 80, 100, or 120 columns as the max width, but not more than that given POSIX best practices and recommendations for better readability.  2. Adds our own normalizers for long descriptions and cmd examples which allows us better control about how things like lists, paragraphs, line breaks, etc are printed. Features markdown support. Looks like `templates.LongDesc` and `templates.Examples` instead of `dedent.Dedend`. 3. Allows simple reordering and reuse of help and usage sections. 3. Adds `verify-cli-conventions.sh` which intends to run tests to make sure cmd developers are using what we propose as [kubectl conventions](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/kubectl-conventions.md). Just a couple simple tests for now but the framework is there and it's easy to extend. 4. Update [kubectl conventions](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/kubectl-conventions.md) to use our own normalizers instead of `dedent.Dedent`. **Release note**: <!-- Steps to write your release note: 1. Use the release-note-* labels to set the release note state (if you have access) 2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. --> ```release-note Improves how 'kubectl' uses the terminal size when printing help and usage. ``` @kubernetes/kubectl |
||
|---|---|---|
| .. | ||
| cmd | ||
| metricsutil | ||
| resource | ||
| testing | ||
| OWNERS | ||
| apply.go | ||
| autoscale.go | ||
| bash_comp_utils.go | ||
| configmap.go | ||
| configmap_test.go | ||
| custom_column_printer.go | ||
| custom_column_printer_test.go | ||
| deployment.go | ||
| deployment_test.go | ||
| describe.go | ||
| describe_test.go | ||
| doc.go | ||
| explain.go | ||
| generate.go | ||
| generate_test.go | ||
| history.go | ||
| interfaces.go | ||
| kubectl.go | ||
| kubectl_test.go | ||
| namespace.go | ||
| namespace_test.go | ||
| proxy_server.go | ||
| proxy_server_test.go | ||
| quota.go | ||
| quota_test.go | ||
| resource_filter.go | ||
| resource_printer.go | ||
| resource_printer_test.go | ||
| rollback.go | ||
| rolling_updater.go | ||
| rolling_updater_test.go | ||
| rollout_status.go | ||
| rollout_status_test.go | ||
| run.go | ||
| run_test.go | ||
| scale.go | ||
| scale_test.go | ||
| secret.go | ||
| secret_for_docker_registry.go | ||
| secret_for_docker_registry_test.go | ||
| secret_for_tls.go | ||
| secret_for_tls_test.go | ||
| secret_test.go | ||
| service.go | ||
| service_basic.go | ||
| service_basic_test.go | ||
| service_test.go | ||
| serviceaccount.go | ||
| serviceaccount_test.go | ||
| sorted_resource_name_list.go | ||
| sorted_resource_name_list_test.go | ||
| sorting_printer.go | ||
| sorting_printer_test.go | ||
| stop.go | ||
| stop_test.go | ||
| version.go | ||
