github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
k3s/pkg/controller
History
k8s-merge-robot 707cc2bbb8 Merge pull request #26493 from caesarxuchao/fix-gc-flake 
Automatic merge from submit-queue

Fixes 25890 flake. Let GC convert ListOptions to v1 before passing it to the dynamic client

GC's ListWatcher directly passed the api.ListOptions to the dynamic client, but the parameter codec of dynamic client converts the options to queries based on the tags in the struct, which are not present in api.ListOptions, so the queries are not sent to the server. As a result, the Watch request was sent without a resourceVersion, causing missed events. Flake #25890 is caused by the missed deletion events.

This PR converts the api.ListOptions to v1.ListOptions before the GC passes it to the dynamic codec. The flaky test has successfully passed 79 times ([log](https://00e9e64bacd064560a027fbee9c5a373a1614f3a56e652ae40-apidata.googleusercontent.com/download/storage/v1_internal/b/kubernetes-jenkins/o/pr-logs%2Fpull%2F25923%2Fkubernetes-pull-test-unit-integration%2F28364%2Fbuild-log.txt?qk=AD5uMEv72OjSUqDyk5i-ZLurcmM4i7gket1c7WaqR7yuIYz7WhPYT7ewVBafijV0ymnPTYqxRYt1kp6S9YQv7chPwC-3UtrKetKfhYnvAFrPGXAIBxHytTmpFohRAYgsARN1B6j1f9vyK5lM-8jyzRGhCK3sCRsAPnbDBWIWFlbH4b1n3vUET3P71QamHrF5itYyaqRU5pMZV3Cwwr81X8q7h5hCzm3Ip78RpMzfjEqTG0RcM2TLGccUrlkWVBLh4hn0NFpUIkzVFugFA5ooJffo-0AdJnO3mGWEOnXNVFWftJbK8cKnTns0DISrYFOyH_PlOe_YHCxgIXIT-dW8G-nbqoUjn5SBqunr36rcpaYCIwe2va4W_AcLCT43xiEAezRER_U9AuIqi_22KMd6SuHTyljhmWFPvPk8-gpjthLWXhcE7LPO5dV41hnZHnbI4n_9eI1nSVm7q9XdSvX1sWKV1GCwn8oj017AnxVvl9bScultko_0dTC747UqJ6UTFakLuFcHFe-F5Tz7ItDWlBVPoXeC7gTpyuicFKLsdqGlW9F5X6kIwNrBRj9uRsS-QuzSER-fVkQCn4dUTcokttRH_0bYvyfr9oqiDXmywMgOp-L0sKayk8JOVynh2q0Tju9sdkvFr0PxoAjhofomfIC1SZ_JkOzwAT1TUW8dLjPHluMct34xW_-qna1AmkoxM4bZQLhllap96NTC-0IdtzeKDrTul8p7u3WXSJjjEMSijibTNMlnkB0AluT1_RNO94OnzuFv4YlcV24FPhJzchhbyKREkOb_wzgcnSbRwGHjIcfRgkX-IzoXHVBcMYFUrPmsXrnRcfad4XwjkUOgvivkURW2_EwnzgrLDh-IKek51_0FpT1MnFCSG0gQbVSs_iMVPr6UXNAw62LGbKVtl3ZMXyapEpcO8azNbn6Wvd550R704JXxYlU)).

@lavalamp @krousey @smarterclayton
 		2016-06-04 01:52:31 -07:00
..
daemon daemonset handle DeletedFinalStateUnknown 2016-05-19 17:16:34 -04:00
deployment List RSes only once when getting old+new RSes in deployment controller 2016-06-02 11:24:43 -07:00
endpoint Endpoints controller respects unready service annotation 2016-05-10 14:20:10 -07:00
framework Attach detach controller business logic added 2016-05-24 23:01:16 -07:00
garbagecollector Let the dynamic client take a customized parameter codec for List, Watch, and DeleteCollection. 2016-06-03 11:22:51 -07:00
gc implement AddIndexers for SharedIndexInformer 2016-05-06 21:23:18 +08:00
job implement AddIndexers for SharedIndexInformer 2016-05-06 21:23:18 +08:00
namespace Merge pull request #25662 from deads2k/prevent-hotloop 2016-05-28 01:30:51 -07:00
node AllocateOrOccupyCIDR returs quickly 2016-05-31 09:11:42 +02:00
persistentvolume Merge pull request #25865 from jsafrane/devel/pv-convert-from-12 2016-06-03 23:27:13 -07:00
petset Update use of Quantity in other classes 2016-05-19 08:41:43 -04:00
podautoscaler Use Metrics API in HPA 2016-05-20 19:50:56 +02:00
replicaset add namespace index to rc and pod 2016-05-06 17:12:36 +08:00
replication Explicitly enqueue controllers on failures and increase resync period 2016-05-16 08:52:01 +02:00
resourcequota Have quota controller use a rate limiter to avoid hot-loops 2016-05-17 11:09:30 -04:00
route Improve logging in routecontroller 2016-06-03 12:05:12 +02:00
service promote sourceRange into service spec 2016-05-26 10:42:30 -07:00
serviceaccount Generated clients can return their RESTClients, RESTClient can return its RateLimiter 2016-04-27 22:15:10 +02:00
volume Attach/Detach Controller Kubelet Changes 2016-06-02 16:47:11 -07:00
OWNERS Remove myself from a bunch of OWNERS files, as I am too overloaded 2016-05-11 13:34:51 -07:00
controller_utils.go Adding logs in deployment for debugging 2016-05-31 15:59:46 -07:00
controller_utils_test.go Fix the rest of the code 2016-04-29 17:12:10 -04:00
doc.go Refactor package controller 2015-07-29 09:54:35 -07:00
lookup_cache.go bugfix:lookupcache's Get method can not be called concurrently 2016-06-04 02:21:25 +08:00