mirror of https://github.com/k3s-io/k3s
252 lines
7.8 KiB
Go
252 lines
7.8 KiB
Go
/*
|
|
Copyright 2018 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package persistentvolume
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"k8s.io/apimachinery/pkg/util/diff"
|
|
utilfeature "k8s.io/apiserver/pkg/util/feature"
|
|
utilfeaturetesting "k8s.io/apiserver/pkg/util/feature/testing"
|
|
api "k8s.io/kubernetes/pkg/apis/core"
|
|
"k8s.io/kubernetes/pkg/features"
|
|
)
|
|
|
|
func TestDropDisabledFields(t *testing.T) {
|
|
specWithCSI := func() *api.PersistentVolumeSpec {
|
|
return &api.PersistentVolumeSpec{PersistentVolumeSource: api.PersistentVolumeSource{CSI: &api.CSIPersistentVolumeSource{}}}
|
|
}
|
|
specWithoutCSI := func() *api.PersistentVolumeSpec {
|
|
return &api.PersistentVolumeSpec{PersistentVolumeSource: api.PersistentVolumeSource{CSI: nil}}
|
|
}
|
|
specWithMode := func(mode *api.PersistentVolumeMode) *api.PersistentVolumeSpec {
|
|
return &api.PersistentVolumeSpec{VolumeMode: mode}
|
|
}
|
|
|
|
modeBlock := api.PersistentVolumeBlock
|
|
|
|
tests := map[string]struct {
|
|
oldSpec *api.PersistentVolumeSpec
|
|
newSpec *api.PersistentVolumeSpec
|
|
expectOldSpec *api.PersistentVolumeSpec
|
|
expectNewSpec *api.PersistentVolumeSpec
|
|
csiEnabled bool
|
|
blockEnabled bool
|
|
}{
|
|
"disabled csi clears new": {
|
|
csiEnabled: false,
|
|
newSpec: specWithCSI(),
|
|
expectNewSpec: specWithoutCSI(),
|
|
oldSpec: nil,
|
|
expectOldSpec: nil,
|
|
},
|
|
"disabled csi clears update when old pv did not use csi": {
|
|
csiEnabled: false,
|
|
newSpec: specWithCSI(),
|
|
expectNewSpec: specWithoutCSI(),
|
|
oldSpec: specWithoutCSI(),
|
|
expectOldSpec: specWithoutCSI(),
|
|
},
|
|
"disabled csi preserves update when old pv did use csi": {
|
|
csiEnabled: false,
|
|
newSpec: specWithCSI(),
|
|
expectNewSpec: specWithCSI(),
|
|
oldSpec: specWithCSI(),
|
|
expectOldSpec: specWithCSI(),
|
|
},
|
|
|
|
"enabled csi preserves new": {
|
|
csiEnabled: true,
|
|
newSpec: specWithCSI(),
|
|
expectNewSpec: specWithCSI(),
|
|
oldSpec: nil,
|
|
expectOldSpec: nil,
|
|
},
|
|
"enabled csi preserves update when old pv did not use csi": {
|
|
csiEnabled: true,
|
|
newSpec: specWithCSI(),
|
|
expectNewSpec: specWithCSI(),
|
|
oldSpec: specWithoutCSI(),
|
|
expectOldSpec: specWithoutCSI(),
|
|
},
|
|
"enabled csi preserves update when old pv did use csi": {
|
|
csiEnabled: true,
|
|
newSpec: specWithCSI(),
|
|
expectNewSpec: specWithCSI(),
|
|
oldSpec: specWithCSI(),
|
|
expectOldSpec: specWithCSI(),
|
|
},
|
|
|
|
"disabled block clears new": {
|
|
blockEnabled: false,
|
|
newSpec: specWithMode(&modeBlock),
|
|
expectNewSpec: specWithMode(nil),
|
|
oldSpec: nil,
|
|
expectOldSpec: nil,
|
|
},
|
|
"disabled block clears update when old pv did not use block": {
|
|
blockEnabled: false,
|
|
newSpec: specWithMode(&modeBlock),
|
|
expectNewSpec: specWithMode(nil),
|
|
oldSpec: specWithMode(nil),
|
|
expectOldSpec: specWithMode(nil),
|
|
},
|
|
"disabled block does not clear new on update when old pv did use block": {
|
|
blockEnabled: false,
|
|
newSpec: specWithMode(&modeBlock),
|
|
expectNewSpec: specWithMode(&modeBlock),
|
|
oldSpec: specWithMode(&modeBlock),
|
|
expectOldSpec: specWithMode(&modeBlock),
|
|
},
|
|
|
|
"enabled block preserves new": {
|
|
blockEnabled: true,
|
|
newSpec: specWithMode(&modeBlock),
|
|
expectNewSpec: specWithMode(&modeBlock),
|
|
oldSpec: nil,
|
|
expectOldSpec: nil,
|
|
},
|
|
"enabled block preserves update when old pv did not use block": {
|
|
blockEnabled: true,
|
|
newSpec: specWithMode(&modeBlock),
|
|
expectNewSpec: specWithMode(&modeBlock),
|
|
oldSpec: specWithMode(nil),
|
|
expectOldSpec: specWithMode(nil),
|
|
},
|
|
"enabled block preserves update when old pv did use block": {
|
|
blockEnabled: true,
|
|
newSpec: specWithMode(&modeBlock),
|
|
expectNewSpec: specWithMode(&modeBlock),
|
|
oldSpec: specWithMode(&modeBlock),
|
|
expectOldSpec: specWithMode(&modeBlock),
|
|
},
|
|
}
|
|
|
|
for name, tc := range tests {
|
|
t.Run(name, func(t *testing.T) {
|
|
defer utilfeaturetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.CSIPersistentVolume, tc.csiEnabled)()
|
|
defer utilfeaturetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.BlockVolume, tc.blockEnabled)()
|
|
|
|
DropDisabledFields(tc.newSpec, tc.oldSpec)
|
|
if !reflect.DeepEqual(tc.newSpec, tc.expectNewSpec) {
|
|
t.Error(diff.ObjectReflectDiff(tc.newSpec, tc.expectNewSpec))
|
|
}
|
|
if !reflect.DeepEqual(tc.oldSpec, tc.expectOldSpec) {
|
|
t.Error(diff.ObjectReflectDiff(tc.oldSpec, tc.expectOldSpec))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestDropDisabledFieldsPersistentLocalVolume(t *testing.T) {
|
|
pvWithoutLocalVolume := func() *api.PersistentVolume {
|
|
return &api.PersistentVolume{
|
|
Spec: api.PersistentVolumeSpec{
|
|
PersistentVolumeSource: api.PersistentVolumeSource{
|
|
Local: nil,
|
|
},
|
|
},
|
|
}
|
|
}
|
|
pvWithLocalVolume := func() *api.PersistentVolume {
|
|
fsType := "ext4"
|
|
return &api.PersistentVolume{
|
|
Spec: api.PersistentVolumeSpec{
|
|
PersistentVolumeSource: api.PersistentVolumeSource{
|
|
Local: &api.LocalVolumeSource{
|
|
Path: "/a/b/c",
|
|
FSType: &fsType,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
pvInfo := []struct {
|
|
description string
|
|
hasLocalVolume bool
|
|
pv func() *api.PersistentVolume
|
|
}{
|
|
{
|
|
description: "pv without LocalVolume",
|
|
hasLocalVolume: false,
|
|
pv: pvWithoutLocalVolume,
|
|
},
|
|
{
|
|
description: "pv with LocalVolume",
|
|
hasLocalVolume: true,
|
|
pv: pvWithLocalVolume,
|
|
},
|
|
{
|
|
description: "is nil",
|
|
hasLocalVolume: false,
|
|
pv: func() *api.PersistentVolume { return nil },
|
|
},
|
|
}
|
|
|
|
for _, enabled := range []bool{true, false} {
|
|
for _, oldpvInfo := range pvInfo {
|
|
for _, newpvInfo := range pvInfo {
|
|
oldpvHasLocalVolume, oldpv := oldpvInfo.hasLocalVolume, oldpvInfo.pv()
|
|
newpvHasLocalVolume, newpv := newpvInfo.hasLocalVolume, newpvInfo.pv()
|
|
if newpv == nil {
|
|
continue
|
|
}
|
|
|
|
t.Run(fmt.Sprintf("feature enabled=%v, old pvc %v, new pvc %v", enabled, oldpvInfo.description, newpvInfo.description), func(t *testing.T) {
|
|
defer utilfeaturetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.PersistentLocalVolumes, enabled)()
|
|
|
|
var oldpvSpec *api.PersistentVolumeSpec
|
|
if oldpv != nil {
|
|
oldpvSpec = &oldpv.Spec
|
|
}
|
|
DropDisabledFields(&newpv.Spec, oldpvSpec)
|
|
|
|
// old pv should never be changed
|
|
if !reflect.DeepEqual(oldpv, oldpvInfo.pv()) {
|
|
t.Errorf("old pv changed: %v", diff.ObjectReflectDiff(oldpv, oldpvInfo.pv()))
|
|
}
|
|
|
|
switch {
|
|
case enabled || oldpvHasLocalVolume:
|
|
// new pv should not be changed if the feature is enabled, or if the old pv had LocalVolume source
|
|
if !reflect.DeepEqual(newpv, newpvInfo.pv()) {
|
|
t.Errorf("new pv changed: %v", diff.ObjectReflectDiff(newpv, newpvInfo.pv()))
|
|
}
|
|
case newpvHasLocalVolume:
|
|
// new pv should be changed
|
|
if reflect.DeepEqual(newpv, newpvInfo.pv()) {
|
|
t.Errorf("new pv was not changed")
|
|
}
|
|
// new pv should not have LocalVolume
|
|
if !reflect.DeepEqual(newpv, pvWithoutLocalVolume()) {
|
|
t.Errorf("new pv had LocalVolume source: %v", diff.ObjectReflectDiff(newpv, pvWithoutLocalVolume()))
|
|
}
|
|
default:
|
|
// new pv should not need to be changed
|
|
if !reflect.DeepEqual(newpv, newpvInfo.pv()) {
|
|
t.Errorf("new pv changed: %v", diff.ObjectReflectDiff(newpv, newpvInfo.pv()))
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
}
|
|
}
|