mirror of https://github.com/k3s-io/k3s
![]() Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. Implement semantic comparison of VolumeNodeAffinity for unit tests **What this PR does / why we need it**: Implements a semantic comparison function for VolumeNodeAffinity that is not sensitive to ordering of various members. Previous reflect.DeepEqual was sensitive to ordering causing it to be flaky. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # https://github.com/kubernetes/kubernetes/issues/67852 **Special notes for your reviewer**: We want to able to successfully match `VolumeNodeAffinity{Required:&NodeSelector{NodeSelectorTerms:[{[{a In [1]} {b In [2 3]}] []}],},}` and `VolumeNodeAffinity{Required:&NodeSelector{NodeSelectorTerms:[{[{b In [3 2]} {a In [1]}] []}],},}` without being sensitive to the ordering of requirements with key `a` and `b` or the order of values with key `b`. This fix enables such semantic comparison of VolumeNodeAffinity We can move `volumeNodeAffinitiesEqual` to volume/utils post code freeze **Release note**: ```release-note NONE ``` /sig storage cc @msau42 |
||
---|---|---|
.. | ||
apis/config | ||
bootstrap | ||
certificates | ||
cloud | ||
clusterroleaggregation | ||
cronjob | ||
daemon | ||
deployment | ||
disruption | ||
endpoint | ||
garbagecollector | ||
history | ||
job | ||
namespace | ||
nodeipam | ||
nodelifecycle | ||
podautoscaler | ||
podgc | ||
replicaset | ||
replication | ||
resourcequota | ||
route | ||
service | ||
serviceaccount | ||
statefulset | ||
testutil | ||
ttl | ||
ttlafterfinished | ||
util/node | ||
volume | ||
.import-restrictions | ||
BUILD | ||
OWNERS | ||
client_builder.go | ||
controller_ref_manager.go | ||
controller_ref_manager_test.go | ||
controller_utils.go | ||
controller_utils_test.go | ||
doc.go | ||
lookup_cache.go |