k3s/pkg/volume
Kubernetes Submit Queue 494ffa4650 Merge pull request #48457 from cofyc/rbd_error
Automatic merge from submit-queue (batch tested with PRs 48425, 41680, 48457, 48619, 48635)

"rbd: image xxx is locked by other nodes" is misleading

**What this PR does / why we need it**:

For RWO PV, RBD plugin tries to fence it first, but there are many situations which may cause lock to fail, e.g.

- userSecret is incorrect
- monitor addresses are incorrect or node cannot access ceph cluster temporarily
- image is locked by other nodes
- maybe more...

So, original "image xxx is locked by other nodes" is incorrect in some cases and misleading in diagnosis.

This PR change the error to be correct and not misleading first. We may add detail error descriptions later.

**Special notes for your reviewer**:

New FailedMount event example if RBD plugin cannot lock image:

```
...		FailedMount		MountVolume.SetUp failed for volume "pvc-ee37a9c8-608e-11e7-b3a7-000c291fbe71" : rbd: failed to lock image kubernetes-dynamic-pvc-ee3b9911-608e-11e7-97b6-000c291fbe71 (maybe locked by other nodes), error exit status 22
```

**Release note**:

```release-note
NONE
```
2017-07-12 10:57:17 -07:00
..
aws_ebs
azure_dd
azure_file
cephfs
cinder
configmap
downwardapi
empty_dir
fc
flexvolume
flocker
gce_pd
git_repo
glusterfs
host_path
iscsi
local
nfs
photon_pd
portworx
projected
quobyte
rbd
scaleio
secret
storageos
testing
util
validation
vsphere_volume
BUILD
OWNERS
doc.go
metrics_cached.go
metrics_du.go
metrics_du_test.go
metrics_errors.go
metrics_nil.go
metrics_nil_test.go
metrics_statfs.go
metrics_statfs_test.go
plugins.go
plugins_test.go
util.go
util_test.go
volume.go
volume_linux.go
volume_unsupported.go