github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
k3s/federation
History
Kubernetes Submit Queue 8eab275cce Merge pull request #53482 from shashidharatd/kubefed-fix-image-name 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix the defaultServerImage name of hyperkube in kubefed

**What this PR does / why we need it**:
Fixes the issue mentioned in https://github.com/kubernetes/kubernetes/issues/53430

Docker images cannot contain special characters like '+' in the tags. So while uploading the federation container images we replace '+' character by '_'. This should have been taken care by kubefed too while consuming the federation container image.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53430

**Special notes for your reviewer**:
This PR fixes the "invalid reference format" issue for the docker image. But am not sure if the version of hyperkube image is available in registry. The version is got from `version.Get()`. So if a user has built the kubefed from source it may be possible that the hyperkube version referenced by that commit is not available in registry. Ideally this issue should not arise on released versions of kubefed.

We need to cherry-pick this fix to all previous supported k8s versions too.

**Release note**:
```release-note
NONE
```

/cc @kubernetes/sig-multicluster-bugs
 		2017-10-09 05:28:20 -07:00
..
apis Autogen 2017-10-05 15:01:52 -07:00
client Update generated files 2017-10-06 12:36:51 +02:00
cluster Remove unnecessarily included scripts in federation deployment scripts 2017-09-26 10:41:18 +05:30
cmd Fix the defaultServerImage name of hyperkube in kubefed 2017-10-05 08:49:18 +05:30
deploy
…
develop Use buildozer to delete licenses() rules except under third_party/ 2017-08-11 09:32:39 -07:00
docs/api-reference Merge pull request #49205 from dixudx/fix_api_type_typos 2017-10-03 20:17:43 -07:00
pkg Merge pull request #52950 from liggitt/persist-rbac-v1 2017-10-03 00:24:31 -07:00
plugin/pkg/admission/schedulingpolicy Use buildozer to delete licenses() rules except under third_party/ 2017-08-11 09:32:39 -07:00
registry/cluster Allow watch cache to be disabled per type 2017-09-08 13:42:28 -04:00
test Auto generated build files 2017-09-28 11:43:35 +05:30
BUILD Auto generated build files 2017-09-28 11:43:35 +05:30
Makefile
…
OWNERS Add irfanurrehman as approver for federation. 2017-08-07 12:55:28 -07:00
README.md fix bad url 2017-08-22 08:28:37 +08:00

README.md

Cluster Federation

Kubernetes Cluster Federation enables users to federate multiple Kubernetes clusters. Please see the user guide and the admin guide for more details about setting up and using the Cluster Federation.

Building Kubernetes Cluster Federation

Please see the Kubernetes Development Guide for initial setup. Once you have the development environment setup as explained in that guide, you also need to install jq

Building cluster federation artifacts should be as simple as running:

make build

You can specify the docker registry to tag the image using the KUBE_REGISTRY environment variable. Please make sure that you use the same value in all the subsequent commands.

To push the built docker images to the registry, run:

make push

To initialize the deployment run:

(This pulls the installer images)

make init

To deploy the clusters and install the federation components, edit the ${KUBE_ROOT}/_output/federation/config.json file to describe your clusters and run:

make deploy

To turn down the federation components and tear down the clusters run:

make destroy

Ideas for improvement

  1. Continue with destroy phase even in the face of errors.

    The bash script sets set -e errexit which causes the script to exit at the very first error. This should be the default mode for deploying components but not for destroying/cleanup.

Analytics