github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
k3s/federation
History
Kubernetes Submit Queue 1ba9202cd8 Merge pull request #42781 from spzala/conversionlint 
Automatic merge from submit-queue

Conversionlint

**What this PR does / why we need it**:
This PR adds a comment placeholder for the exported or public functions in conversion generator files. Such functions without a comment results into golint failure in various generated files. The changes in this patch takes care of about 36 related lint failures. 
Given below is an example lint error, 
zz_generated.conversion.go:91:1: exported function Convert_v1alpha1_Binding_To_servicecatalog_Binding should have comment or be unexported

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
Considering minor changes no issue is created. 

**Special notes for your reviewer**:
Hello, I am trying to fix golint failures as we see them in the kubernetes-incubator/service-catalog project. I have separate PRs opened for lint issues related to other generator code which are in separate libraries like gengo. Thanks! 

**Release note**:

```release-note
```
 		2017-04-12 03:02:26 -07:00
..
apis Merge pull request #42781 from spzala/conversionlint 2017-04-12 03:02:26 -07:00
client Update client 2017-02-28 15:34:34 +01:00
cluster Merge pull request #42748 from dcbw/cfssl-localup 2017-04-10 14:27:11 -07:00
cmd auto generated bazel build file 2017-04-10 23:17:08 +05:30
deploy
…
develop Move push-federation-images.sh to federation and implement similar functionality in jenkins build directory for presubmits. 2017-02-27 17:54:37 -08:00
docs/api-reference add singular resource names to discovery 2017-03-21 11:04:08 -04:00
manifests Release 3.0.17 etcd image 2017-02-27 16:23:44 +01:00
pkg move helpers.go to helper 2017-04-11 15:49:11 -07:00
registry/cluster Updating the registry to return whether the resource was immediately deleted 2017-02-21 11:00:35 -08:00
BUILD fed: Add integration test for secrets 2017-03-30 12:58:39 -07:00
Makefile
…
OWNERS fed: Add marun as reviewer 2017-02-09 09:50:57 -08:00
README.md
…

README.md

Cluster Federation

Kubernetes Cluster Federation enables users to federate multiple Kubernetes clusters. Please see the user guide and the admin guide for more details about setting up and using the Cluster Federation.

Building Kubernetes Cluster Federation

Please see the Kubernetes Development Guide for initial setup. Once you have the development environment setup as explained in that guide, you also need to install jq

Building cluster federation artifacts should be as simple as running:

make build

You can specify the docker registry to tag the image using the KUBE_REGISTRY environment variable. Please make sure that you use the same value in all the subsequent commands.

To push the built docker images to the registry, run:

make push

To initialize the deployment run:

(This pulls the installer images)

make init

To deploy the clusters and install the federation components, edit the ${KUBE_ROOT}/_output/federation/config.json file to describe your clusters and run:

make deploy

To turn down the federation components and tear down the clusters run:

make destroy

Ideas for improvement

  1. Continue with destroy phase even in the face of errors.

    The bash script sets set -e errexit which causes the script to exit at the very first error. This should be the default mode for deploying components but not for destroying/cleanup.

Analytics