k3s/pkg/kubelet/dockertools
k8s-merge-robot d37e6ad332 Merge pull request #24126 from Random-Liu/fix-pull-image
Automatic merge from submit-queue

Fix PullImage and add corresponding node e2e test

Fixes #24101. This is a bug introduced by #23506, since ref #23563.

The root cause of #24101 is described [here](https://github.com/kubernetes/kubernetes/issues/24101#issuecomment-208547623).

This PR
1) Fixes #24101 by decoding the messages returned during pulling image, and return error if any of the messages contains error.
2) Add the node e2e test to detect this kind of failure.
3) Get present check out of `ConformanceImage.Remove()` and `ConformanceImage.Pull()`. Because sometimes we may expect error to occur in `PullImage()` and `RemoveImage()`, but even that doesn't happen, the `Present()` check will still return error and let the test pass.

@yujuhong @freehan @liangchenye 

Also /cc @resouer, because he is doing the image related functions refactoring.
2016-04-18 07:05:44 -07:00
..
container_gc.go Refactor StartContainer, StopContainer and RemoveContainer. 2016-04-14 17:05:46 -07:00
container_gc_test.go Refactor InspectContainer. 2016-04-14 17:05:46 -07:00
convert.go Refactr ListContainers. 2016-04-14 17:05:05 -07:00
convert_test.go Refactr ListContainers. 2016-04-14 17:05:05 -07:00
docker.go Merge pull request #23699 from Random-Liu/container-related-functions 2016-04-16 21:41:19 -07:00
docker_test.go Merge pull request #23699 from Random-Liu/container-related-functions 2016-04-16 21:41:19 -07:00
exec.go Refactor InspectContainer. 2016-04-14 17:05:46 -07:00
fake_docker_client.go Refactor StartContainer, StopContainer and RemoveContainer. 2016-04-14 17:05:46 -07:00
fake_manager.go Disable the version cache to fix #24298. 2016-04-17 03:14:03 -07:00
instrumented_docker.go Refactor StartContainer, StopContainer and RemoveContainer. 2016-04-14 17:05:46 -07:00
kube_docker_client.go Merge pull request #24126 from Random-Liu/fix-pull-image 2016-04-18 07:05:44 -07:00
labels.go Set Docker custom metric label for cAdvisor if custom metric volume is mounted 2016-02-05 12:00:02 +01:00
labels_test.go Set Docker custom metric label for cAdvisor if custom metric volume is mounted 2016-02-05 12:00:02 +01:00
manager.go Merge pull request #24384 from Random-Liu/disable-version-cache 2016-04-17 04:48:07 -07:00
manager_test.go Refactor CreateContainer. 2016-04-14 17:05:46 -07:00