k3s/pkg/quota
k8s-merge-robot 32121e344b Merge pull request #24514 from derekwaynecarr/pod_quota_fix
Automatic merge from submit-queue

Quota ignores pod compute resources on updates

Scenario:

1. define a quota Q that tracks memory and cpu
2. create pod P that uses memory=100Mi, cpu=100m
3. update pod P to use memory=50Mi,cpu=10m

Expected Results:
Step 3 should fail with validation error.
Quota Q should not have changed.

Actual Results:
Step 3 fails validation, but quota Q is decremented to have memory usage down 50Mi and cpu usage down 40m.  This is because the quota was getting updated even though the pod was going to fail validation.

Fix:
Quota should only support modifying pod compute resources when pods themselves support modifying their compute resources.

This also fixes https://github.com/kubernetes/kubernetes/issues/24352

/cc @smarterclayton - this is what we discussed.

fyi: @kubernetes/rh-cluster-infra
2016-04-27 06:27:51 -07:00
..
evaluator/core Merge pull request #24514 from derekwaynecarr/pod_quota_fix 2016-04-27 06:27:51 -07:00
generic minor comment and code fixes 2016-04-16 10:18:43 -04:00
install Add quota evaluator framework 2016-02-26 20:34:14 -05:00
interfaces.go Add quota evaluator framework 2016-02-26 20:34:14 -05:00
resources.go Add quota evaluator framework 2016-02-26 20:34:14 -05:00
resources_test.go Fixing several (but not all) go vet errors. Most are around string formatting, or unreachable code. 2016-03-22 17:26:50 -07:00