github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
k3s/pkg/kubectl
History
Kubernetes Submit Queue 5f92042610
Merge pull request #56483 from dixudx/fix_cli_attach_format 
Automatic merge from submit-queue (batch tested with PRs 57127, 57011, 56754, 56601, 56483). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix bad output format for attaching pods

**What this PR does / why we need it**:
If the user wants to attach stdin, wants a TTY, and `o.In` is a terminal, `t.Raw` is set to true, which is causing bad format like #56450.

We should avoid print extra logs in `SafeFunc`. Move it outer.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #56450

**Special notes for your reviewer**:
/assign @thockin @kubernetes/sig-cli-bugs  

**Release note**:

```release-note
None
```
 		2017-12-17 06:26:01 -08:00
..
apply Support retainkeys strategy in new apply merge code 2017-11-02 10:00:56 -07:00
apps Add support for CronJob to kind_visitor 2017-11-10 04:22:57 +00:00
categories Move category expander out of kubectl/resource 2017-11-14 17:38:16 -05:00
cmd Merge pull request #56483 from dixudx/fix_cli_attach_format 2017-12-17 06:26:01 -08:00
explain Merge pull request #56746 from xuri/patch 2017-12-16 06:39:42 -08:00
metricsutil Update generated files 2017-11-09 12:14:08 +01:00
plugins Simple code and typo fixed. 2017-12-02 21:12:39 +08:00
proxy update BUILD files 2017-10-15 18:18:13 -07:00
resource check for empty label before assigning 2017-12-11 12:52:29 -05:00
scheme remove reference to v1alpha1 2017-11-21 13:00:40 -08:00
testing Update generated code 2017-11-10 18:26:46 +01:00
util switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
validation update BUILD files 2017-10-15 18:18:13 -07:00
.import-restrictions Add import restriction 2017-11-21 23:19:44 -08:00
BUILD Merge pull request #56676 from shiywang/remove_dead_code 2017-12-16 18:53:05 -08:00
OWNERS
…
apply.go remove internal version api from apply 2017-12-11 13:49:39 +05:30
autoscale.go refactor kubectl autoscale to use the new generator 2017-11-20 14:12:20 +08:00
autoscale_test.go refactor kubectl autoscale to use the new generator 2017-11-20 14:12:20 +08:00
bash_comp_utils.go
…
clusterrolebinding.go
…
clusterrolebinding_test.go
…
configmap.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
configmap_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
delete.go pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
delete_test.go pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
deployment.go
…
deployment_test.go
…
doc.go
…
env_file.go
…
env_file_test.go
…
generate.go
…
generate_test.go
…
history.go Add support for CronJob to kind_visitor 2017-11-10 04:22:57 +00:00
history_test.go Refactor HistoryViewerFor to use Visitor design pattern 2017-11-09 08:11:19 +00:00
interfaces.go
…
kubectl.go
…
namespace.go Remove kubectl create namespace dependencies on kubernetes/pkg/api 2017-10-25 20:26:11 +08:00
namespace_test.go Remove kubectl create namespace dependencies on kubernetes/pkg/api 2017-10-25 20:26:11 +08:00
pdb.go Print type representation on errors when checking parameter types 2017-11-01 10:36:17 +01:00
pdb_test.go Print type representation on errors when checking parameter types 2017-11-01 10:36:17 +01:00
priorityclass.go add create subcommand for priorityclass 2017-11-07 15:03:01 +08:00
priorityclass_test.go add create subcommand for priorityclass 2017-11-07 15:03:01 +08:00
quota.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
quota_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
resource_filter.go Builder should allow moving between unstructured / versioned easily 2017-11-19 19:16:49 -05:00
resource_filter_test.go pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
rolebinding.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
rolebinding_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
rollback.go Trying to make error message similar to what is expected in tests 2017-11-22 06:17:44 +00:00
rollback_test.go Replace type switches in Rollback with Visitor pattern 2017-11-19 17:46:57 +00:00
rolling_updater.go pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
rolling_updater_test.go pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
rollout_status.go use extensions client with explicit version 2017-11-22 21:18:14 +08:00
rollout_status_test.go Replace some occurances of kubernetes internal api types in kubectl 2017-11-08 18:27:45 +01:00
run.go Merge pull request #54554 from zjj2wry/set-dep 2017-11-11 12:44:30 -08:00
run_test.go
…
scale.go pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
scale_test.go Use Error with no value format and fix typo error messages 2017-11-11 15:00:43 +08:00
secret.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
secret_for_docker_registry.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
secret_for_docker_registry_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
secret_for_tls.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
secret_for_tls_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
secret_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
service.go remove dependency from service generator 2017-10-31 15:35:36 +08:00
service_basic.go Make sure the ports is valid when parsing portString 2017-11-13 20:46:05 +08:00
service_basic_test.go Make sure the ports is valid when parsing portString 2017-11-13 20:46:05 +08:00
service_test.go remove dependency from service generator 2017-10-31 15:35:36 +08:00
serviceaccount.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
serviceaccount_test.go switch some commands to use its own scheme 2017-10-27 18:31:42 -07:00
sorting_printer.go
…
sorting_printer_test.go pkg/api/legacyscheme: fixup imports 2017-10-18 17:23:55 +02:00