mirror of https://github.com/k3s-io/k3s
da601bc72a
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. pkg: kubelet: do not assume anything about images names This patch fixes a regression introduced by https://github.com/kubernetes/kubernetes/pull/51751 in the CRI interface. That commit actually changed a unit test where we were previously *not* assuming anything about an image name. Before that commit, if you send the image "busybox" through the CRI, the container runtime receives "busybox". After that patch the container runtime gets "docker.io/library/busybox". While that may be correct for the internal kube dockershim, in the CRI we must not assume anything about image names. The ImageSpec is not providing any spec around the image so the container runtime should just get the raw image name from the pod spec. Every container runtime can handle image names the way it wants. The "docker.io" namespace is not at all "standard", CRI-O is not following what the docker UI say since that's the docker UI. We should not focus the CRI on wrong UI design, especially around a default namespace. Image name normalization is a Docker implementation detail around short images names, not the CRI. ImageSpec is not standardized yet: https://github.com/kubernetes/kubernetes/issues/46255 and https://github.com/kubernetes/kubernetes/issues/7203 This is something which should land in 1.9 as well since the regression is from 1.8. Signed-off-by: Antonio Murdaca <runcom@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note Fix regression in the CRI: do not add a default hostname on short image names ``` |
||
|---|---|---|
| .. | ||
| apis | ||
| cadvisor | ||
| certificate | ||
| checkpoint | ||
| client | ||
| cm | ||
| config | ||
| configmap | ||
| container | ||
| custommetrics | ||
| dockershim | ||
| envvars | ||
| events | ||
| eviction | ||
| gpu | ||
| images | ||
| kubeletconfig | ||
| kuberuntime | ||
| leaky | ||
| lifecycle | ||
| metrics | ||
| mountpod | ||
| network | ||
| pleg | ||
| pod | ||
| preemption | ||
| prober | ||
| qos | ||
| remote | ||
| rkt | ||
| secret | ||
| server | ||
| stats | ||
| status | ||
| sysctl | ||
| types | ||
| util | ||
| volumemanager | ||
| winstats | ||
| BUILD | ||
| OWNERS | ||
| active_deadline.go | ||
| active_deadline_test.go | ||
| doc.go | ||
| kubelet.go | ||
| kubelet_getters.go | ||
| kubelet_getters_test.go | ||
| kubelet_network.go | ||
| kubelet_network_test.go | ||
| kubelet_node_status.go | ||
| kubelet_node_status_test.go | ||
| kubelet_pods.go | ||
| kubelet_pods_test.go | ||
| kubelet_pods_windows_test.go | ||
| kubelet_resources.go | ||
| kubelet_resources_test.go | ||
| kubelet_test.go | ||
| kubelet_volumes.go | ||
| kubelet_volumes_test.go | ||
| oom_watcher.go | ||
| oom_watcher_test.go | ||
| pod_container_deletor.go | ||
| pod_container_deletor_test.go | ||
| pod_workers.go | ||
| pod_workers_test.go | ||
| reason_cache.go | ||
| reason_cache_test.go | ||
| runonce.go | ||
| runonce_test.go | ||
| runtime.go | ||
| util.go | ||
| volume_host.go | ||