github
/
k3s
mirror of https://github.com/k3s-io/k3s
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
k3s/pkg/apis
History
Kubernetes Submit Queue 865d3cf409
Merge pull request #62018 from andyzhangx/local-windows-path-fix 
Automatic merge from submit-queue (batch tested with PRs 61147, 62236, 62018). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix local volume absolute path issue on Windows

**What this PR does / why we need it**:
remove IsAbs validation on local volume since it does not work on windows cluster, Windows absolute path `D:` is not allowed in local volume, the [validation](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/validation/validation.go#L1386) happens on both master and agent node, while for windows cluster, the master is Linux and agent is Windows, so `path.IsAbs()` func will not work all in both nodes. 
**Instead**, this PR use `MakeAbsolutePath` func to convert `local.path` value in kubelet, it supports both linux and windows styple. 

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #62016

**Special notes for your reviewer**:

**Release note**:

```
fix local volume absolute path issue on Windows
```
/sig storage
/sig windows
 		2018-04-10 05:31:20 -07:00
..
abac regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
admission regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
admissionregistration regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
apps regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
authentication regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
authorization regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
autoscaling regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
batch regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
certificates regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
componentconfig Set leader-elect for kube-scheduler to true 2018-03-30 10:52:01 -04:00
core Merge pull request #62018 from andyzhangx/local-windows-path-fix 2018-04-10 05:31:20 -07:00
events regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
extensions Merge pull request #60792 from php-coder/psp_tiny_godoc_fix 2018-03-21 14:15:21 -07:00
imagepolicy regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
networking Merge pull request #60452 from danwinship/networkpolicy-pod-plus-ns 2018-03-24 13:34:27 -07:00
policy regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
rbac regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
scheduling Merge pull request #60519 from bsalamat/auto_prio_class 2018-03-26 23:20:05 -07:00
settings regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
storage regenerated all files and remove all YEAR fields 2018-03-08 17:52:48 +08:00
OWNERS Remove myself (timothysc) from OWNERS files on areas that I do not 2018-02-12 18:56:41 -06:00