/* Copyright 2015 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package iscsi import ( "errors" "fmt" "os" "path/filepath" "reflect" "testing" "k8s.io/kubernetes/pkg/util/mount" "k8s.io/kubernetes/pkg/volume" ) func TestGetDevicePrefixRefCount(t *testing.T) { fm := &mount.FakeMounter{ MountPoints: []mount.MountPoint{ {Device: "/dev/sdb", Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0"}, {Device: "/dev/sdb", Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-1"}, {Device: "/dev/sdb", Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-2"}, {Device: "/dev/sdb", Path: "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-3"}, }, } tests := []struct { devicePrefix string expectedRefs int }{ { "/127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00", 4, }, } for i, test := range tests { if refs, err := getDevicePrefixRefCount(fm, test.devicePrefix); err != nil || test.expectedRefs != refs { t.Errorf("%d. GetDevicePrefixRefCount(%s) = %d, %v; expected %d, nil", i, test.devicePrefix, refs, err, test.expectedRefs) } } } func TestExtractDeviceAndPrefix(t *testing.T) { devicePath := "127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00" mountPrefix := "/var/lib/kubelet/plugins/kubernetes.io/iscsi/iface-default/" + devicePath lun := "-lun-0" device, prefix, err := extractDeviceAndPrefix(mountPrefix + lun) if err != nil || device != (devicePath+lun) || prefix != mountPrefix { t.Errorf("extractDeviceAndPrefix: expected %s and %s, got %v %s and %s", devicePath+lun, mountPrefix, err, device, prefix) } } func TestExtractIface(t *testing.T) { ifaceName := "default" devicePath := "127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0" iface, found := extractIface("/var/lib/kubelet/plugins/kubernetes.io/iscsi/iface-" + ifaceName + "/" + devicePath) if !found || iface != ifaceName { t.Errorf("extractIface: expected %s and %t, got %s and %t", ifaceName, true, iface, found) } iface, found = extractIface("/var/lib/kubelet/plugins/kubernetes.io/iscsi/" + devicePath) if found || iface != "" { t.Errorf("extractIface: expected %s and %t, got %s and %t", "", false, iface, found) } } func TestExtractPortalAndIqn(t *testing.T) { devicePath := "127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0" portal, iqn, err := extractPortalAndIqn(devicePath) if err != nil || portal != "127.0.0.1:3260" || iqn != "iqn.2014-12.com.example:test.tgt00" { t.Errorf("extractPortalAndIqn: got %v %s %s", err, portal, iqn) } devicePath = "127.0.0.1:3260-eui.02004567A425678D-lun-0" portal, iqn, err = extractPortalAndIqn(devicePath) if err != nil || portal != "127.0.0.1:3260" || iqn != "eui.02004567A425678D" { t.Errorf("extractPortalAndIqn: got %v %s %s", err, portal, iqn) } } func TestRemoveDuplicate(t *testing.T) { dupPortals := []string{"127.0.0.1:3260", "127.0.0.1:3260", "127.0.0.100:3260"} portals := removeDuplicate(dupPortals) want := []string{"127.0.0.1:3260", "127.0.0.100:3260"} if reflect.DeepEqual(portals, want) == false { t.Errorf("removeDuplicate: want: %s, got: %s", want, portals) } } func fakeOsStat(devicePath string) (fi os.FileInfo, err error) { var cmd os.FileInfo return cmd, nil } func fakeFilepathGlob(devicePath string) (globs []string, err error) { return []string{devicePath}, nil } func fakeFilepathGlob2(devicePath string) (globs []string, err error) { return []string{ "/dev/disk/by-path/pci-0000:00:00.0-ip-127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0", }, nil } func TestExtractTransportname(t *testing.T) { fakeIscsiadmOutput := []string{ "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = default\n" + "iface.transport_name = tcp\n" + "iface.initiatorname = \n" + "# END RECORD", "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = default\n" + "iface.transport_name = cxgb4i\n" + "iface.initiatorname = \n" + "# END RECORD", "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = default\n" + "iface.transport_name = \n" + "iface.initiatorname = \n" + "# END RECORD", "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = default\n" + "iface.initiatorname = \n" + "# END RECORD"} transportName := extractTransportname(fakeIscsiadmOutput[0]) if transportName != "tcp" { t.Errorf("extractTransportname: Could not extract correct iface.transport_name 'tcp', got %s", transportName) } transportName = extractTransportname(fakeIscsiadmOutput[1]) if transportName != "cxgb4i" { t.Errorf("extractTransportname: Could not extract correct iface.transport_name 'cxgb4i', got %s", transportName) } transportName = extractTransportname(fakeIscsiadmOutput[2]) if transportName != "tcp" { t.Errorf("extractTransportname: Could not extract correct iface.transport_name 'tcp', got %s", transportName) } transportName = extractTransportname(fakeIscsiadmOutput[3]) if transportName != "" { t.Errorf("extractTransportname: Could not extract correct iface.transport_name '', got %s", transportName) } } func TestWaitForPathToExist(t *testing.T) { devicePath := []string{"/dev/disk/by-path/ip-127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0", "/dev/disk/by-path/pci-*-ip-127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0"} fpath := "/dev/disk/by-path/pci-0000:00:00.0-ip-127.0.0.1:3260-iqn.2014-12.com.example:test.tgt00-lun-0" exist := waitForPathToExistInternal(&devicePath[0], 1, "tcp", fakeOsStat, filepath.Glob) if exist == false { t.Errorf("waitForPathToExist: could not find path %s", devicePath[0]) } exist = waitForPathToExistInternal(&devicePath[0], 1, "fake_iface", fakeOsStat, filepath.Glob) if exist != false { t.Errorf("waitForPathToExist: wrong code path called for %s", devicePath[0]) } exist = waitForPathToExistInternal(&devicePath[1], 1, "fake_iface", os.Stat, fakeFilepathGlob) if exist == false { t.Errorf("waitForPathToExist: could not find path %s", devicePath[1]) } exist = waitForPathToExistInternal(&devicePath[1], 1, "tcp", os.Stat, fakeFilepathGlob) if exist != false { t.Errorf("waitForPathToExist: wrong code path called for %s", devicePath[1]) } exist = waitForPathToExistInternal(&devicePath[1], 1, "fake_iface", os.Stat, fakeFilepathGlob2) if devicePath[1] != fpath { t.Errorf("waitForPathToExist: wrong code path called for %s", devicePath[1]) } } func TestParseIscsiadmShow(t *testing.T) { fakeIscsiadmOutput1 := "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = default\n" + "iface.transport_name = tcp\n" + "iface.initiatorname = \n" + "iface.mtu = 0\n" + "# END RECORD" fakeIscsiadmOutput2 := "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = default\n" + "iface.transport_name = cxgb4i\n" + "iface.initiatorname = \n" + "iface.mtu = 0\n" + "# END RECORD" fakeIscsiadmOutput3 := "# BEGIN RECORD 2.0-873\n" + "iface.iscsi_ifacename = custom\n" + "iface.transport_name = \n" + "iface.initiatorname = \n" + "iface.mtu = 0\n" + "# END RECORD" fakeIscsiadmOutput4 := "iface.iscsi_ifacename=error" fakeIscsiadmOutput5 := "iface.iscsi_ifacename + error" expectedIscsiadmOutput1 := map[string]string{ "iface.transport_name": "tcp", "iface.mtu": "0"} expectedIscsiadmOutput2 := map[string]string{ "iface.transport_name": "cxgb4i", "iface.mtu": "0"} expectedIscsiadmOutput3 := map[string]string{ "iface.mtu": "0"} params, _ := parseIscsiadmShow(fakeIscsiadmOutput1) if !reflect.DeepEqual(params, expectedIscsiadmOutput1) { t.Errorf("parseIscsiadmShow: Fail to parse iface record: %s", params) } params, _ = parseIscsiadmShow(fakeIscsiadmOutput2) if !reflect.DeepEqual(params, expectedIscsiadmOutput2) { t.Errorf("parseIscsiadmShow: Fail to parse iface record: %s", params) } params, _ = parseIscsiadmShow(fakeIscsiadmOutput3) if !reflect.DeepEqual(params, expectedIscsiadmOutput3) { t.Errorf("parseIscsiadmShow: Fail to parse iface record: %s", params) } _, err := parseIscsiadmShow(fakeIscsiadmOutput4) if err == nil { t.Errorf("parseIscsiadmShow: Fail to handle invalid record: iface %s", fakeIscsiadmOutput4) } _, err = parseIscsiadmShow(fakeIscsiadmOutput5) if err == nil { t.Errorf("parseIscsiadmShow: Fail to handle invalid record: iface %s", fakeIscsiadmOutput5) } } func TestClonedIface(t *testing.T) { cmdCount := 0 fakeExec := mount.NewFakeExec(func(cmd string, args ...string) ([]byte, error) { cmdCount++ if cmd != "iscsiadm" { t.Errorf("iscsiadm command expected, got %q", cmd) } switch cmdCount { case 1: // iscsiadm -m iface -I -o show return []byte("iface.ipaddress = \niface.transport_name = tcp\niface.initiatorname = \n"), nil case 2: // iscsiadm -m iface -I -o new return []byte("New interface 192.168.1.10:pv0001 added"), nil case 3: // iscsiadm -m iface -I -o update -n -v return []byte(""), nil case 4: return []byte(""), nil } return nil, fmt.Errorf("Unexpected exec call nr %d: %s", cmdCount, cmd) }) plugins := []volume.VolumePlugin{ &iscsiPlugin{ host: nil, }, } plugin := plugins[0] fakeMounter := iscsiDiskMounter{ iscsiDisk: &iscsiDisk{ plugin: plugin.(*iscsiPlugin)}, exec: fakeExec, } newIface := "192.168.1.10:pv0001" cloneIface(fakeMounter, newIface) if cmdCount != 4 { t.Errorf("expected 4 CombinedOutput() calls, got %d", cmdCount) } } func TestClonedIfaceShowError(t *testing.T) { cmdCount := 0 fakeExec := mount.NewFakeExec(func(cmd string, args ...string) ([]byte, error) { cmdCount++ if cmd != "iscsiadm" { t.Errorf("iscsiadm command expected, got %q", cmd) } // iscsiadm -m iface -I -o show, return test error return []byte(""), errors.New("test error") }) plugins := []volume.VolumePlugin{ &iscsiPlugin{ host: nil, }, } plugin := plugins[0] fakeMounter := iscsiDiskMounter{ iscsiDisk: &iscsiDisk{ plugin: plugin.(*iscsiPlugin)}, exec: fakeExec, } newIface := "192.168.1.10:pv0001" cloneIface(fakeMounter, newIface) if cmdCount != 1 { t.Errorf("expected 1 CombinedOutput() calls, got %d", cmdCount) } } func TestClonedIfaceUpdateError(t *testing.T) { cmdCount := 0 fakeExec := mount.NewFakeExec(func(cmd string, args ...string) ([]byte, error) { cmdCount++ if cmd != "iscsiadm" { t.Errorf("iscsiadm command expected, got %q", cmd) } switch cmdCount { case 1: // iscsiadm -m iface -I -o show return []byte("iface.ipaddress = \niface.transport_name = tcp\niface.initiatorname = \n"), nil case 2: // iscsiadm -m iface -I -o new return []byte("New interface 192.168.1.10:pv0001 added"), nil case 3: // iscsiadm -m iface -I -o update -n -v return []byte(""), nil case 4: return []byte(""), errors.New("test error") case 5: // iscsiadm -m iface -I -o delete return []byte(""), nil } return nil, fmt.Errorf("Unexpected exec call nr %d: %s", cmdCount, cmd) }) plugins := []volume.VolumePlugin{ &iscsiPlugin{ host: nil, }, } plugin := plugins[0] fakeMounter := iscsiDiskMounter{ iscsiDisk: &iscsiDisk{ plugin: plugin.(*iscsiPlugin)}, exec: fakeExec, } newIface := "192.168.1.10:pv0001" cloneIface(fakeMounter, newIface) if cmdCount != 5 { t.Errorf("expected 5 CombinedOutput() calls, got %d", cmdCount) } }