/* Copyright 2014 The Kubernetes Authors All rights reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package resourcequota import ( "strconv" "testing" "k8s.io/kubernetes/pkg/admission" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/api/resource" "k8s.io/kubernetes/pkg/api/unversioned" "k8s.io/kubernetes/pkg/client/cache" "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/fake" resourcequotacontroller "k8s.io/kubernetes/pkg/controller/resourcequota" "k8s.io/kubernetes/pkg/runtime" ) func getResourceList(cpu, memory string) api.ResourceList { res := api.ResourceList{} if cpu != "" { res[api.ResourceCPU] = resource.MustParse(cpu) } if memory != "" { res[api.ResourceMemory] = resource.MustParse(memory) } return res } func getResourceRequirements(requests, limits api.ResourceList) api.ResourceRequirements { res := api.ResourceRequirements{} res.Requests = requests res.Limits = limits return res } func validPod(name string, numContainers int, resources api.ResourceRequirements) *api.Pod { pod := &api.Pod{ ObjectMeta: api.ObjectMeta{Name: name, Namespace: "test"}, Spec: api.PodSpec{}, } pod.Spec.Containers = make([]api.Container, 0, numContainers) for i := 0; i < numContainers; i++ { pod.Spec.Containers = append(pod.Spec.Containers, api.Container{ Image: "foo:V" + strconv.Itoa(i), Resources: resources, }) } return pod } func TestAdmissionIgnoresDelete(t *testing.T) { namespace := "default" handler := createResourceQuota(&fake.Clientset{}, nil) err := handler.Admit(admission.NewAttributesRecord(nil, api.Kind("Pod"), namespace, "name", api.Resource("pods"), "", admission.Delete, nil)) if err != nil { t.Errorf("ResourceQuota should admit all deletes: %v", err) } } func TestAdmissionIgnoresSubresources(t *testing.T) { indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{"namespace": cache.MetaNamespaceIndexFunc}) handler := createResourceQuota(&fake.Clientset{}, indexer) quota := &api.ResourceQuota{} quota.Name = "quota" quota.Namespace = "test" quota.Status = api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } quota.Status.Hard[api.ResourceMemory] = resource.MustParse("2Gi") quota.Status.Used[api.ResourceMemory] = resource.MustParse("1Gi") indexer.Add(quota) newPod := validPod("123", 1, getResourceRequirements(getResourceList("100m", "2Gi"), getResourceList("", ""))) err := handler.Admit(admission.NewAttributesRecord(newPod, api.Kind("Pod"), newPod.Namespace, newPod.Name, api.Resource("pods"), "", admission.Create, nil)) if err == nil { t.Errorf("Expected an error because the pod exceeded allowed quota") } err = handler.Admit(admission.NewAttributesRecord(newPod, api.Kind("Pod"), newPod.Namespace, newPod.Name, api.Resource("pods"), "subresource", admission.Create, nil)) if err != nil { t.Errorf("Did not expect an error because the action went to a subresource: %v", err) } } func TestIncrementUsagePodResources(t *testing.T) { type testCase struct { testName string existing *api.Pod input *api.Pod resourceName api.ResourceName hard resource.Quantity expectedUsage resource.Quantity expectedError bool } testCases := []testCase{ { testName: "memory-allowed", existing: validPod("a", 1, getResourceRequirements(getResourceList("", "100Mi"), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("", "100Mi"), getResourceList("", ""))), resourceName: api.ResourceMemory, hard: resource.MustParse("500Mi"), expectedUsage: resource.MustParse("200Mi"), expectedError: false, }, { testName: "memory-not-allowed", existing: validPod("a", 1, getResourceRequirements(getResourceList("", "100Mi"), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("", "450Mi"), getResourceList("", ""))), resourceName: api.ResourceMemory, hard: resource.MustParse("500Mi"), expectedError: true, }, { testName: "memory-not-allowed-with-different-format", existing: validPod("a", 1, getResourceRequirements(getResourceList("", "100M"), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("", "450Mi"), getResourceList("", ""))), resourceName: api.ResourceMemory, hard: resource.MustParse("500Mi"), expectedError: true, }, { testName: "memory-no-request", existing: validPod("a", 1, getResourceRequirements(getResourceList("", "100Mi"), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("", ""), getResourceList("", ""))), resourceName: api.ResourceMemory, hard: resource.MustParse("500Mi"), expectedError: true, }, { testName: "cpu-allowed", existing: validPod("a", 1, getResourceRequirements(getResourceList("1", ""), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("1", ""), getResourceList("", ""))), resourceName: api.ResourceCPU, hard: resource.MustParse("2"), expectedUsage: resource.MustParse("2"), expectedError: false, }, { testName: "cpu-not-allowed", existing: validPod("a", 1, getResourceRequirements(getResourceList("1", ""), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("600m", ""), getResourceList("", ""))), resourceName: api.ResourceCPU, hard: resource.MustParse("1500m"), expectedError: true, }, { testName: "cpu-no-request", existing: validPod("a", 1, getResourceRequirements(getResourceList("1", ""), getResourceList("", ""))), input: validPod("b", 1, getResourceRequirements(getResourceList("", ""), getResourceList("", ""))), resourceName: api.ResourceCPU, hard: resource.MustParse("1500m"), expectedError: true, }, } for _, item := range testCases { podList := &api.PodList{Items: []api.Pod{*item.existing}} client := fake.NewSimpleClientset(podList) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } used, err := resourcequotacontroller.PodRequests(item.existing, item.resourceName) if err != nil { t.Errorf("Test %s, unexpected error %v", item.testName, err) } status.Hard[item.resourceName] = item.hard status.Used[item.resourceName] = *used dirty, err := IncrementUsage(admission.NewAttributesRecord(item.input, api.Kind("Pod"), item.input.Namespace, item.input.Name, api.Resource("pods"), "", admission.Create, nil), status, client) if err == nil && item.expectedError { t.Errorf("Test %s, expected error", item.testName) } if err != nil && !item.expectedError { t.Errorf("Test %s, unexpected error", err) } if !item.expectedError { if !dirty { t.Errorf("Test %s, expected the quota to be dirty", item.testName) } quantity := status.Used[item.resourceName] if quantity.String() != item.expectedUsage.String() { t.Errorf("Test %s, expected usage %s, actual usage %s", item.testName, item.expectedUsage.String(), quantity.String()) } } } } func TestIncrementUsagePods(t *testing.T) { pod := validPod("123", 1, getResourceRequirements(getResourceList("100m", "1Gi"), getResourceList("", ""))) podList := &api.PodList{Items: []api.Pod{*pod}} client := fake.NewSimpleClientset(podList) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourcePods status.Hard[r] = resource.MustParse("2") status.Used[r] = resource.MustParse("1") dirty, err := IncrementUsage(admission.NewAttributesRecord(&api.Pod{}, api.Kind("Pod"), pod.Namespace, "new-pod", api.Resource("pods"), "", admission.Create, nil), status, client) if err != nil { t.Errorf("Unexpected error: %v", err) } if !dirty { t.Errorf("Expected the status to get incremented, therefore should have been dirty") } quantity := status.Used[r] if quantity.Value() != int64(2) { t.Errorf("Expected new item count to be 2, but was %s", quantity.String()) } } func TestExceedUsagePods(t *testing.T) { pod := validPod("123", 1, getResourceRequirements(getResourceList("100m", "1Gi"), getResourceList("", ""))) podList := &api.PodList{Items: []api.Pod{*pod}} client := fake.NewSimpleClientset(podList) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourcePods status.Hard[r] = resource.MustParse("1") status.Used[r] = resource.MustParse("1") _, err := IncrementUsage(admission.NewAttributesRecord(&api.Pod{}, api.Kind("Pod"), pod.Namespace, "name", api.Resource("pods"), "", admission.Create, nil), status, client) if err == nil { t.Errorf("Expected error because this would exceed your quota") } } func TestIncrementUsageServices(t *testing.T) { namespace := "default" client := fake.NewSimpleClientset(&api.ServiceList{ Items: []api.Service{ { ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, }, }, }) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourceServices status.Hard[r] = resource.MustParse("2") status.Used[r] = resource.MustParse("1") dirty, err := IncrementUsage(admission.NewAttributesRecord(&api.Service{}, api.Kind("Service"), namespace, "name", api.Resource("services"), "", admission.Create, nil), status, client) if err != nil { t.Errorf("Unexpected error: %v", err) } if !dirty { t.Errorf("Expected the status to get incremented, therefore should have been dirty") } quantity := status.Used[r] if quantity.Value() != int64(2) { t.Errorf("Expected new item count to be 2, but was %s", quantity.String()) } } func TestExceedUsageServices(t *testing.T) { namespace := "default" client := fake.NewSimpleClientset(&api.ServiceList{ Items: []api.Service{ { ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, }, }, }) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourceServices status.Hard[r] = resource.MustParse("1") status.Used[r] = resource.MustParse("1") _, err := IncrementUsage(admission.NewAttributesRecord(&api.Service{}, api.Kind("Service"), namespace, "name", api.Resource("services"), "", admission.Create, nil), status, client) if err == nil { t.Errorf("Expected error because this would exceed usage") } } func TestIncrementUsageReplicationControllers(t *testing.T) { namespace := "default" client := fake.NewSimpleClientset(&api.ReplicationControllerList{ Items: []api.ReplicationController{ { ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, }, }, }) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourceReplicationControllers status.Hard[r] = resource.MustParse("2") status.Used[r] = resource.MustParse("1") dirty, err := IncrementUsage(admission.NewAttributesRecord(&api.ReplicationController{}, api.Kind("ReplicationController"), namespace, "name", api.Resource("replicationcontrollers"), "", admission.Create, nil), status, client) if err != nil { t.Errorf("Unexpected error: %v", err) } if !dirty { t.Errorf("Expected the status to get incremented, therefore should have been dirty") } quantity := status.Used[r] if quantity.Value() != int64(2) { t.Errorf("Expected new item count to be 2, but was %s", quantity.String()) } } func TestExceedUsageReplicationControllers(t *testing.T) { namespace := "default" client := fake.NewSimpleClientset(&api.ReplicationControllerList{ Items: []api.ReplicationController{ { ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, }, }, }) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourceReplicationControllers status.Hard[r] = resource.MustParse("1") status.Used[r] = resource.MustParse("1") _, err := IncrementUsage(admission.NewAttributesRecord(&api.ReplicationController{}, api.Kind("ReplicationController"), namespace, "name", api.Resource("replicationcontrollers"), "", admission.Create, nil), status, client) if err == nil { t.Errorf("Expected error for exceeding hard limits") } } func TestExceedUsageSecrets(t *testing.T) { namespace := "default" client := fake.NewSimpleClientset(&api.SecretList{ Items: []api.Secret{ { ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, }, }, }) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourceSecrets status.Hard[r] = resource.MustParse("1") status.Used[r] = resource.MustParse("1") _, err := IncrementUsage(admission.NewAttributesRecord(&api.Secret{}, api.Kind("Secret"), namespace, "name", api.Resource("secrets"), "", admission.Create, nil), status, client) if err == nil { t.Errorf("Expected error for exceeding hard limits") } } func TestExceedUsagePersistentVolumeClaims(t *testing.T) { namespace := "default" client := fake.NewSimpleClientset(&api.PersistentVolumeClaimList{ Items: []api.PersistentVolumeClaim{ { ObjectMeta: api.ObjectMeta{Name: "123", Namespace: namespace}, }, }, }) status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := api.ResourcePersistentVolumeClaims status.Hard[r] = resource.MustParse("1") status.Used[r] = resource.MustParse("1") _, err := IncrementUsage(admission.NewAttributesRecord(&api.PersistentVolumeClaim{}, api.Kind("PersistentVolumeClaim"), namespace, "name", api.Resource("persistentvolumeclaims"), "", admission.Create, nil), status, client) if err == nil { t.Errorf("Expected error for exceeding hard limits") } } func TestIncrementUsageOnUpdateIgnoresNonPodResources(t *testing.T) { testCase := []struct { kind unversioned.GroupKind resource unversioned.GroupResource subresource string object runtime.Object }{ { kind: api.Kind("Service"), resource: api.Resource("services"), object: &api.Service{}, }, { kind: api.Kind("ReplicationController"), resource: api.Resource("replicationcontrollers"), object: &api.ReplicationController{}, }, { kind: api.Kind("ResourceQuota"), resource: api.Resource("resourcequotas"), object: &api.ResourceQuota{}, }, { kind: api.Kind("Secret"), resource: api.Resource("secrets"), object: &api.Secret{}, }, { kind: api.Kind("PersistentVolumeClaim"), resource: api.Resource("persistentvolumeclaims"), object: &api.PersistentVolumeClaim{}, }, } for _, testCase := range testCase { client := fake.NewSimpleClientset() status := &api.ResourceQuotaStatus{ Hard: api.ResourceList{}, Used: api.ResourceList{}, } r := resourceToResourceName[testCase.resource] status.Hard[r] = resource.MustParse("2") status.Used[r] = resource.MustParse("1") attributesRecord := admission.NewAttributesRecord(testCase.object, testCase.kind, "my-ns", "new-thing", testCase.resource, testCase.subresource, admission.Update, nil) dirty, err := IncrementUsage(attributesRecord, status, client) if err != nil { t.Errorf("Increment usage of resource %v had unexpected error: %v", testCase.resource, err) } if dirty { t.Errorf("Increment usage of resource %v should not result in a dirty quota on update", testCase.resource) } } }