Fabio Yeon
68ced25022
Merge pull request #20041 from quinton-hoole/2016-01-22-writing-good-e2e
...
Add document on writing good e2e tests.
2016-02-26 15:39:16 -08:00
Fabio Yeon
465934f67b
Merge pull request #21772 from matthughes/patch-1
...
Make sure etcd2 actually gets started
2016-02-26 14:36:43 -08:00
Quinton Hoole
c8bd3b886b
Add document on writing good e2e tests.
2016-02-26 14:15:31 -08:00
Fabio Yeon
c94a0856a0
Fix docs for read-only PDs.
2016-02-26 13:39:13 -08:00
Fabio Yeon
fedca86c75
Merge pull request #21884 from swagiaal/remove-be-formatted
...
Remove 'be formatted' from VolumeSource docs
2016-02-26 13:06:01 -08:00
k8s-merge-robot
a53bf86f40
Merge pull request #21946 from pwittrock/node-e2e-images
...
Auto commit by PR queue bot
2016-02-26 12:18:03 -08:00
Avesh Agarwal
f77bdeb75c
Fix hpa-php-apache.yaml.
2016-02-26 15:05:28 -05:00
Fabio Yeon
3dab166da4
Merge pull request #21776 from erictune/job-sel-gen
...
Selector generation for batch/v1 Job
2016-02-26 11:58:21 -08:00
Phillip Wittrock
a11489e0ff
Node e2e documentations and minor features
...
- Add README.md for node e2e tests
- Add support for --cleanup=false to leave test files on remote hosts and temporary instances for debugging
- Add ubuntu trusty instances for docker 1.8 and docker 1.9 to jenkins pr builder
- Disable coreos-beta for jenkins ci since it is failing - need to investigate
2016-02-26 10:58:48 -08:00
Steve Kuznetsov
e5b696ee43
added 'kubectl create sa' to create serviceaccounts
2016-02-26 10:27:37 -05:00
k8s-merge-robot
766657cd19
Merge pull request #21504 from luxas/fix_certs_for_hyperkube
...
Auto commit by PR queue bot
2016-02-26 06:53:29 -08:00
k8s-merge-robot
085d7cbbb8
Merge pull request #21072 from MikeSpreitzer/issue/20292
...
Auto commit by PR queue bot
2016-02-26 03:13:29 -08:00
Sami Wagiaalla
d7c6eb92d9
Remove 'be formatted' from VolumeSource docs
...
Volumes do not need to be formatted as we now have the
SafeFormatAndMount utility which formats volumes when needed.
2016-02-25 16:19:35 -05:00
Lucas Käldström
e9af6c34af
Update the DNS template from cluster/addons/dns and combine into one file. Make DNS working on docker and docker-multinode
2016-02-25 21:59:07 +02:00
Eric Tune
095a85e76e
Update docs and examples to batch/v1 Job
...
Documented manualSelector field.
Documented that you do not need to provide a selector
or unique labels with batch/v1 Job.
Updated all Job examples to apiVersion: batch/v1
Updated all Job examples to use generated selectors.
2016-02-25 09:28:07 -08:00
Eric Tune
2afcc7d165
Regenerate
2016-02-25 09:28:07 -08:00
k8s-merge-robot
fab42f5c26
Merge pull request #21354 from erictune/manual-selector
...
Auto commit by PR queue bot
2016-02-25 09:02:28 -08:00
Wojciech Tyczynski
506899008f
Parallelization of namespace deletion
2016-02-25 16:33:25 +01:00
Ben Parees
469bb1359a
fix syntax issues in template example json
2016-02-25 10:00:22 -05:00
mqliang
4a9a3aeeea
avoid use abbreviation in flag
2016-02-25 17:30:21 +08:00
k8s-merge-robot
33ef7a93a4
Merge pull request #20647 from dcbw/allow-disabling-bridge-nf-call-iptables
...
Auto commit by PR queue bot
2016-02-25 01:27:47 -08:00
Eric Tune
99e79720d0
Explain conversion for manualSelector
2016-02-24 23:00:44 -08:00
k8s-merge-robot
9a4e3f8470
Merge pull request #21870 from mqliang/lookup-cache
...
Auto commit by PR queue bot
2016-02-24 20:01:29 -08:00
Joe Finney
930291588c
Remove PrepareVersion from hack/e2e.go.
2016-02-24 13:08:22 -08:00
mqliang
e44e71ca87
make cache size configurable
2016-02-24 22:37:02 +08:00
Vladimir Rutsky
57a4c07351
fix identation in list
...
tabs were replaces with 4 spaces
2016-02-24 17:19:42 +03:00
feisky
e8e01fdfc2
Fix missing doc links
2016-02-24 16:06:59 +08:00
Jordan Liggitt
b502b8f6a1
Restore service port validation compatibility with 1.0/1.1
2016-02-23 21:27:44 -05:00
Dawn Chen
a8c0ac88fc
Merge pull request #21754 from kargakis/use-generation-for-deployments
...
Use generation for deployments
2016-02-23 16:42:16 -08:00
Yu-Ju Hong
a07d1411a8
Change default --max-pods in kubelet to 110
...
Also increase maximum dead containers to 240
2016-02-23 15:37:36 -08:00
k8s-merge-robot
6332d84039
Merge pull request #19782 from pmorie/config-docs
...
Auto commit by PR queue bot
2016-02-23 11:11:36 -08:00
kargakis
6506d76f76
update-all changes for deployment's observedGeneration
2016-02-23 19:42:35 +01:00
Matt Hughes
aaa4100d3a
Make sure etcd2 actually gets started
...
Need to actually start etcd2. Right now it is just being configured and using the CoreOS Openstack image, nothing else is starting etcd2.
2016-02-23 13:34:17 -05:00
Matt Hughes
ce6c87ce49
Make sure etcd2 actually gets started
...
This configures etcd2, but doesn't actually start it up. At least using the CoreOS Openstack image, nothing else was doing this.
2016-02-23 13:33:11 -05:00
Paul Morie
7e64b4ac52
Add ConfigMap docs
2016-02-23 13:27:54 -05:00
Dan Williams
6248939e11
Push responsibility for bridge-nf-call-iptables to kubelet network plugins
...
bridge-nf-call-iptables appears to only be relevant when the containers are
attached to a Linux bridge, which is usually the case with default Kubernetes
setups, docker, and flannel. That ensures that the container traffic is
actually subject to the iptables rules since it traverses a Linux bridge
and bridged traffic is only subject to iptables when bridge-nf-call-iptables=1.
But with other networking solutions (like openshift-sdn) that don't use Linux
bridges, bridge-nf-call-iptables may not be not relevant, because iptables is
invoked at other points not involving a Linux bridge.
The decision to set bridge-nf-call-iptables should be influenced by networking
plugins, so push the responsiblity out to them. If no network plugin is
specified, fall back to the existing bridge-nf-call-iptables=1 behavior.
2016-02-23 09:34:59 -06:00
k8s-merge-robot
be623ae3fa
Merge pull request #18562 from fgimenez/added-missing-juju-dependency-to-doc
...
Auto commit by PR queue bot
2016-02-23 00:49:29 -08:00
k8s-merge-robot
5d4007f2fa
Merge pull request #21644 from thibserot/dns2
...
Auto commit by PR queue bot
2016-02-22 23:45:44 -08:00
Jeff Lowdermilk
c406665b2b
Plumb node labels through salt
...
Expose node-labels flag on kubelet for gce via a startup script
env var.
2016-02-22 15:31:34 -08:00
Dawn Chen
699c80b752
Merge pull request #21641 from bprashanth/promisc
...
Teach the kubelet about promiscuous mode, take 2
2016-02-22 15:08:18 -08:00
Dawn Chen
1e680c9d94
Merge pull request #21158 from kubernetes/milestone-doc
...
Add milestone tag clarifications
2016-02-22 14:11:45 -08:00
k8s-merge-robot
fb2a209ed7
Merge pull request #21221 from yifan-gu/rkt_doc
...
Auto commit by PR queue bot
2016-02-22 14:02:54 -08:00
Yifan Gu
b3ed1b633f
docs/rkt: Document the different UX.
2016-02-22 11:46:02 -08:00
Eric Chiang
080bdde5c1
*: update documentation for webhook authorizer
2016-02-22 11:39:07 -08:00
Brian Grant
3042f1d1c8
Merge pull request #21300 from soltysh/ds_docs
...
Updated label selector for daemon set
2016-02-22 10:17:56 -08:00
Mike Spreitzer
22246291e3
Support a CNI plugin as an alternative to Flannel
...
Resolves issue #20292
2016-02-22 11:29:55 -05:00
k8s-merge-robot
aee2eb3977
Merge pull request #21434 from erictune/job-ga
...
Auto commit by PR queue bot
2016-02-22 00:12:54 -08:00
Thibault Serot
b6ce3f3411
Fixing conflct
2016-02-21 18:58:36 +01:00
Thibault Serot
9c5f4c112b
Enabling DNS support in local-up-cluster.sh
2016-02-21 18:55:06 +01:00
k8s-merge-robot
d6192dd152
Merge pull request #21342 from spxtr/remove-e2e-test
...
Auto commit by PR queue bot
2016-02-21 00:39:38 -08:00
Prashanth Balasubramanian
2e8ff81de1
Teach the kubelet about --hairpin-mode=promiscuous-bridge.
2016-02-20 22:40:54 -08:00
k8s-merge-robot
0f1043d6df
Merge pull request #21299 from wojtek-t/always_event_etcd
...
Auto commit by PR queue bot
2016-02-20 21:03:27 -08:00
k8s-merge-robot
807344da0b
Merge pull request #21235 from davidopp/affinity-docs
...
Auto commit by PR queue bot
2016-02-20 11:15:02 -08:00
k8s-merge-robot
6c5bf89ed3
Merge pull request #21160 from justinsb/aws_bigger_master
...
Auto commit by PR queue bot
2016-02-20 00:29:45 -08:00
Daniel Smith
a8b943dddd
Revert "Put the container bridge in promiscuous mode."
2016-02-19 23:14:53 -08:00
Prashanth Balasubramanian
a694a7ae4b
Teach the kubelet about --hairpin-mode=promiscuous-bridge.
2016-02-19 14:59:16 -08:00
k8s-merge-robot
1820da67a2
Merge pull request #21436 from caesarxuchao/clientget-doc
...
Auto commit by PR queue bot
2016-02-19 11:38:29 -08:00
Chao Xu
f255a723ac
add client-gen readme
2016-02-19 10:43:17 -08:00
Eric Tune
b4d454e9d5
Autogenerate.
2016-02-19 09:48:03 -08:00
k8s-merge-robot
057b8352ec
Merge pull request #21182 from vishh/repoTagsRename
...
Auto commit by PR queue bot
2016-02-19 08:56:09 -08:00
k8s-merge-robot
4f410d389a
Merge pull request #21145 from justinsb/doc_aws_elb_describe
...
Auto commit by PR queue bot
2016-02-19 08:27:29 -08:00
k8s-merge-robot
5a3dec8dad
Merge pull request #20777 from pmorie/kubectl-create-configmap
...
Auto commit by PR queue bot
2016-02-19 00:03:53 -08:00
k8s-merge-robot
54ecdbc222
Merge pull request #19761 from derekwaynecarr/quota_doc
...
Auto commit by PR queue bot
2016-02-18 21:23:17 -08:00
Paul Morie
7a243cb615
Regen for kubectl create configmap
2016-02-18 21:25:31 -05:00
k8s-merge-robot
d792e55e21
Merge pull request #21388 from justinsb/docs_quotas
...
Auto commit by PR queue bot
2016-02-18 18:23:00 -08:00
k8s-merge-robot
f1cbaed60f
Merge pull request #17493 from feihujiang/supportSubresourceOfServiceProxy
...
Auto commit by PR queue bot
2016-02-18 18:22:59 -08:00
David Oppenheimer
053f1c6008
Update user guide and scheduler documentation to describe node affinity.
...
Register image priority locality function, which the original PR that introduced
it forgot to do. Change zone and region labels to beta.
2016-02-18 17:09:41 -08:00
Rob Szumski
6e4e5e0e1b
docs: update alternative to official CoreOS guide
2016-02-18 11:46:43 -08:00
Rob Szumski
ac218b3d00
docs: add AWS to list of CoreOS guides
2016-02-18 11:46:11 -08:00
k8s-merge-robot
5acdb92126
Merge pull request #21177 from laushinka/spelling-fixes
...
Auto commit by PR queue bot
2016-02-18 10:29:49 -08:00
k8s-merge-robot
17325ef6ef
Merge pull request #20501 from piosz/hpa-ga
...
Auto commit by PR queue bot
2016-02-18 06:52:39 -08:00
k8s-merge-robot
b3f6e26cc8
Merge pull request #21343 from a-robinson/buildcop
...
Auto commit by PR queue bot
2016-02-18 02:03:43 -08:00
feihujiang
ac9f890238
Support the subresource of service proxy
2016-02-18 15:16:05 +08:00
k8s-merge-robot
bcabc096f2
Merge pull request #21130 from madhusudancs/daemonset-enable-default
...
Auto commit by PR queue bot
2016-02-17 22:54:35 -08:00
k8s-merge-robot
10f3403536
Merge pull request #21362 from ArtfulCoder/fluentd
...
Auto commit by PR queue bot
2016-02-17 22:25:28 -08:00
laushinka
7ef585be22
Spelling fixes inspired by github.com/client9/misspell
2016-02-18 06:58:05 +07:00
k8s-merge-robot
093aa17e17
Merge pull request #21415 from bparees/fix_braces
...
Auto commit by PR queue bot
2016-02-17 15:38:15 -08:00
k8s-merge-robot
2afe60d766
Merge pull request #21395 from jawnsy/topics/update-getting-started
...
Auto commit by PR queue bot
2016-02-17 15:38:13 -08:00
Madhusudan.C.S
6023d2075c
Auto-generated docs and specs.
2016-02-17 15:10:53 -08:00
Madhusudan.C.S
475546be66
Remove the Caveats section from DaemonSet doc because DaemonSet is now enabled by default.
2016-02-17 15:04:31 -08:00
Madhusudan.C.S
ab1e9c200f
Graduate DaemonSet to v1beta1 API, enable it by default.
2016-02-17 15:03:12 -08:00
Ben Parees
287706138b
minor cleanup to the template proposal
2016-02-17 16:40:03 -05:00
Abhishek Shah
51fba282ec
Fluentd on GCE master should not use ClusterFirst
2016-02-17 11:32:41 -08:00
Jonathan Yu
3e92a3fb8c
Indicate that OpenSSL is required to run Kubernetes
...
Signed-off-by: Jonathan Yu <jawnsy@redhat.com>
2016-02-17 18:49:45 +00:00
k8s-merge-robot
0866c377e9
Merge pull request #18010 from feihujiang/supportSubresourceOfNodeProxy
...
Auto commit by PR queue bot
2016-02-17 08:15:50 -08:00
Justin Santa Barbara
98e9985c1b
Docs: fix invalid json in quota example
...
Fixes #21385
2016-02-17 10:32:14 -05:00
Justin Santa Barbara
a16372ce40
AWS: Change master to m3.medium by default
...
m3.large for > 150 nodes.
t2.micro often runs out of memory. The t2 class has very
difficult-to-understand behaviour when it runs out of CPU. The
m3.medium is reasonably affordable, and avoids these problems.
Fix #21151
Issue #18975
2016-02-17 10:24:14 -05:00
k8s-merge-robot
1a2f811a3b
Merge pull request #20063 from mqliang/imageGC-config
...
Auto commit by PR queue bot
2016-02-17 06:16:45 -08:00
Vishnu kannan
2623fdde17
Improve the naming of fields in ContainerImage struct used in NodeStatus.
...
Signed-off-by: Vishnu kannan <vishnuk@google.com>
2016-02-16 15:45:22 -08:00
k8s-merge-robot
0bb59866cd
Merge pull request #21301 from mdevilliers/patch-2
...
Auto commit by PR queue bot
2016-02-16 15:05:17 -08:00
Alex Robinson
6e4e21d9fe
Fix build cop issues link to filter out issues with the team/gke label.
2016-02-16 15:00:14 -08:00
Joe Finney
6f7182e500
Remove hack/e2e-test.sh in favor of hack/e2e.go.
2016-02-16 14:54:50 -08:00
Mark deVilliers
141c8c8671
fix another mistake
2016-02-16 16:55:30 +00:00
k8s-merge-robot
f37472fb4d
Merge pull request #21287 from macb/docs/remove_incomplete_sentence
...
Auto commit by PR queue bot
2016-02-16 08:55:05 -08:00
derekwaynecarr
f782089bb2
Proposal: ResourceQuota scoping support
2016-02-16 11:10:34 -05:00
Mark deVilliers
c618ec2303
Tweaks to Flocker description
2016-02-16 12:32:34 +00:00
Maciej Szulik
eccced231b
Updated label selector for daemon set
2016-02-16 12:16:03 +01:00
Wojciech Tyczynski
f6dc06bdc7
Always enable second etcd for events
2016-02-16 11:48:46 +01:00
k8s-merge-robot
0e037ac3ce
Merge pull request #21176 from davidopp/large-cluster-doc
...
Auto commit by PR queue bot
2016-02-16 01:48:34 -08:00
David Oppenheimer
4a817c7156
Clarify
2016-02-16 01:24:12 -08:00
k8s-merge-robot
90a7ac4aa1
Merge pull request #21293 from liggitt/sa-namespace-docs
...
Auto commit by PR queue bot
2016-02-16 01:21:57 -08:00
feihujiang
e85253916f
Support the subresource of node proxy
2016-02-16 17:02:45 +08:00
David Oppenheimer
f00e831607
Add PR with new heapster limits.
2016-02-15 23:12:08 -08:00
Jordan Liggitt
f1da2a92ab
Docs for service account token namespace
2016-02-16 00:15:20 -05:00
k8s-merge-robot
9dacc5b382
Merge pull request #21238 from AdoHe/kubectl_help_bug
...
Auto commit by PR queue bot
2016-02-15 19:16:39 -08:00
Mac Browning
6ca03de351
remove incomplete thought
2016-02-15 21:09:32 -05:00
k8s-merge-robot
47acbd62ec
Merge pull request #21099 from deads2k/extend-patch
...
Auto commit by PR queue bot
2016-02-15 14:49:02 -08:00
Piotr Szczesniak
e96515f590
Autogenerated conversions, deep copies, types
2016-02-15 21:39:00 +01:00
David Oppenheimer
97e2f4b413
Respond to reviewer comments.
2016-02-15 12:38:31 -08:00
mqliang
641ba92aa3
move minGCAge to ImageGCPolicy and make it configurable
2016-02-15 22:54:54 +08:00
k8s-merge-robot
138cb09aea
Merge pull request #20795 from luxas/remove_dev
...
Auto commit by PR queue bot
2016-02-15 03:52:26 -08:00
AdoHe
81103a07c2
fix --sort-by help bug
2016-02-14 22:31:13 -05:00
André Martins
97acdf4cd8
fixing docker -d deprecation
...
Signed-off-by: André Martins <aanm90@gmail.com>
2016-02-14 23:07:32 +01:00
Paul Morie
8323bb1727
Regen for ConfigMap volume
2016-02-14 16:28:59 -05:00
k8s-merge-robot
44d12a1389
Merge pull request #20782 from nickschuch/readonly_container_2
...
Auto commit by PR queue bot
2016-02-14 13:18:24 -08:00
k8s-merge-robot
38e827011b
Merge pull request #21005 from liggitt/delete-all
...
Auto commit by PR queue bot
2016-02-14 07:15:09 -08:00
k8s-merge-robot
43fb544a4a
Merge pull request #21001 from ericchiang/oidc_groups
...
Auto commit by PR queue bot
2016-02-14 05:24:43 -08:00
k8s-merge-robot
ad36fc8ba5
Merge pull request #19832 from caseydavenport/calico-cni-ubuntu-doc
...
Auto commit by PR queue bot
2016-02-13 21:43:56 -08:00
Nick Schuch
5d511aeb54
Adds ReadOnlyRootFilesystem support for containers
2016-02-14 15:39:51 +10:00
Tim Hockin
a3d688fc06
Update docs about ports, fix nits
2016-02-13 20:24:21 -08:00
Isaac Hollander McCreery
0ad9b2552b
Add docs for branching e2e jobs
2016-02-12 17:24:07 -08:00
Isaac Hollander McCreery
ec5b9abba8
Add instructions and tooling for munging test infra for a new release series
2016-02-12 17:24:06 -08:00
Isaac Hollander McCreery
c09da9e03c
Remove [Skipped] as a label for tests.
2016-02-12 17:24:06 -08:00
k8s-merge-robot
6250497c40
Merge pull request #21192 from erictune/manual-selector
...
Auto commit by PR queue bot
2016-02-12 17:06:13 -08:00
Eric Tune
2b9d22e030
Renamed noAutoSelector to manualSelector
...
Avoids double negative.
2016-02-12 14:34:07 -08:00
Eric Tune
485b0681c5
Update paths after move.
...
Also improve doc slightly.
2016-02-12 14:34:03 -08:00
k8s-merge-robot
8a4a73e372
Merge pull request #20517 from janetkuo/enable-deployments-default
...
Auto commit by PR queue bot
2016-02-12 14:26:12 -08:00
Eric Tune
7734dd8d18
Move selector-generation from proposal to design
2016-02-12 14:09:26 -08:00
Janet Kuo
311385e76c
Make deployment the default in kubectl run
2016-02-12 12:29:14 -08:00
Janet Kuo
2874f30c05
Enable Deployments by default
2016-02-12 12:29:14 -08:00
David Oppenheimer
8930c4c250
Update cluster-large.md to reflect 1000-node clusters.
2016-02-12 11:35:56 -08:00
Eric Chiang
92d37d5cc5
plugin/pkg/auth/authenticator/token/oidc: get groups from custom claim
2016-02-12 09:58:18 -08:00
goltermann
4f0f1df14b
Add milestone tag clarifications
...
Add Milestone details to our issues page that defines Priority
2016-02-12 09:06:29 -08:00
deads2k
9f003f7db3
allow patch to handle multiple types
2016-02-12 11:12:09 -05:00
derekwaynecarr
e5e691ed5f
Default lockfile to empty string while alpha
2016-02-12 10:50:17 -05:00
Brian Rosner
1511c23cbe
Added pykube client library
2016-02-12 08:15:26 -07:00
Justin Santa Barbara
c081e29a55
Add docs for AWS LoadBalancers: use kubectl describe
...
On AWS, we create ELBs for services with Type=LoadBalancer.
ELBs use hostnames, and the hostname is too long to fit in the output of
`kubectl get`. So instead the user must do `kubectl describe service
<id>`.
Fix #13827
2016-02-12 10:07:11 -05:00
k8s-merge-robot
b5c12d10b8
Merge pull request #20764 from mikedanese/controller-manager-componentconfig
...
Auto commit by PR queue bot
2016-02-11 16:47:58 -08:00
k8s-merge-robot
662a4291f3
Merge pull request #19488 from derekwaynecarr/fix_19129
...
Auto commit by PR queue bot
2016-02-11 15:08:55 -08:00
Mike Danese
33c4332b28
autogenerated
2016-02-11 13:14:47 -08:00
k8s-merge-robot
f6ae6b47ae
Merge pull request #20687 from vishh/systemd-support
...
Auto commit by PR queue bot
2016-02-11 13:06:29 -08:00
derekwaynecarr
06f26189f0
Update kubectl create subcommand to use printer flags
2016-02-11 15:37:47 -05:00
k8s-merge-robot
09314f97f6
Merge pull request #20944 from janetkuo/move-deployment-example
...
Auto commit by PR queue bot
2016-02-11 02:37:31 -08:00
k8s-merge-robot
3208665edf
Merge pull request #20928 from madhusudancs/replicaset-expose
...
Auto commit by PR queue bot
2016-02-11 02:02:20 -08:00
k8s-merge-robot
d66ae29587
Merge pull request #20758 from ihmccreery/reconcile-testing-docs
...
Auto commit by PR queue bot
2016-02-10 20:00:09 -08:00
Vishnu kannan
c3b5d5774c
Update flag values for cgroups managed by kubelet.
...
Signed-off-by: Vishnu kannan <vishnuk@google.com>
2016-02-10 17:33:29 -08:00
Isaac Hollander McCreery
c25c7c7491
Reconcile testing docs, fixes #18606
2016-02-10 16:33:35 -08:00
Madhusudan.C.S
293793cf0d
Allow replica set to be exposed as a service and add kubectl command tests for replica sets.
2016-02-10 16:20:08 -08:00
Vishnu kannan
51e4ccf106
Updating the default values for the cgroups hierarchies that kubelet
...
creates for managing the nodes.
Signed-off-by: Vishnu kannan <vishnuk@google.com>
2016-02-10 16:02:36 -08:00
Vishnu kannan
38efc837b9
Make container runtime's cgroup configurable.
...
Use the real cgroups for metrics generation.
Signed-off-by: Vishnu kannan <vishnuk@google.com>
2016-02-10 16:02:34 -08:00