Kubernetes Prow Robot
5756eea804
Merge pull request #74700 from SataQiu/fix-golint-20190228
...
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-03-04 13:25:26 -08:00
Ismo Puustinen
f7e1058c98
shellcheck failures: remove hack/lib/util.sh
2019-03-04 23:23:20 +02:00
Ismo Puustinen
1e34d9df7d
hack/lib/util.sh: replace sed with bash replace.
...
Test script:
#!/bin/bash
rev1="foo"
rev2="\"bar\""
rev3="'bar'"
newrev1="${rev1//[\'\"]}"
newrev2="${rev2//[\'\"]}"
newrev3="${rev3//[\'\"]}"
oldrev1=$(echo "${rev1}" | sed "s/['\"]//g")
oldrev2=$(echo "${rev2}" | sed "s/['\"]//g")
oldrev3=$(echo "${rev3}" | sed "s/['\"]//g")
echo "$newrev1 vs. $oldrev1"
echo "$newrev2 vs. $oldrev2"
echo "$newrev3 vs. $oldrev3"
expected output:
foo vs. foo
bar vs. bar
bar vs. bar
2019-03-04 23:23:20 +02:00
Ismo Puustinen
0078fce5bd
hack/lib/util.sh: don't implicitly convert "find" results into array.
...
Also fix array item comparison. Test script for the comparison change:
#!/bin/bash
staging_apis=(extensions/v1beta1 extensions/v1 extensions/v1alpha)
group_versions=(v1 extensions/v1beta1 extensions/v1 extensions.k8s.io/v1)
for group_version in ${group_versions[@]}; do
# original code
if [[ " ${staging_apis[@]} " =~ " ${group_version/.*k8s.io/} " ]]; then
echo "orig: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
# new code
for api in ${staging_apis[@]}; do
if [[ "${api}" = "${group_version/.*k8s.io/}" ]]; then
echo "new: vendor/k8s.io/api/${group_version/.*k8s.io/}"
fi
done
done
Expected output:
orig: vendor/k8s.io/api/extensions/v1beta1
new: vendor/k8s.io/api/extensions/v1beta1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
orig: vendor/k8s.io/api/extensions/v1
new: vendor/k8s.io/api/extensions/v1
2019-03-04 23:23:20 +02:00
Ismo Puustinen
edd806330a
hack/lib/util.sh: mark variables to be used in a sourcing context.
...
"Decorate" the variables with a no-op function to prevent shellcheck
from complaining that they are not being used. This method provides
visibility to which variables are supposed to be used in a sourcing
script compared to just disabling the warning.
2019-03-04 23:23:20 +02:00
Ismo Puustinen
24b5c67723
hack/lib/util.sh: various shellcheck-reported cleanups.
...
Use "command -v" instead of "which". Also remove the redirections,
since "command -v" does not return an error message if the command isn't
found. Also use "read -r" instead of "read" and quote variables
properly. Do some error handling if "pushd" or "popd" fail. Read values
properly into arrays.
However, one shellcheck error is ignored in trap mechanism. The logic
in trap_add function requires the trap command to be expanded when run.
Just storing the variable into trap doesn't work. Add a shellcheck
disable directive to ignore the error.
An alternative to ignoring could be tricking shellcheck with:
trap ''"${new_cmd}" "${trap_add_name}"
2019-03-04 23:18:54 +02:00
Niko Pen
32f4bf6edf
cherry picks usage info link
2019-03-04 03:20:41 +00:00
Xing Yang
bb45b8ee34
Make CSINodeInfo and CSIDriver Core APIs
...
This PR is the first step to transition CSINodeInfo and CSIDriver
CRD's to in-tree APIs. It adds them to the existing API group
“storage.k8s.io” as core storage APIs.
2019-03-02 12:31:05 -08:00
Kubernetes Prow Robot
222dd0af4c
Merge pull request #71022 from emwalker/68026-golint-fixes-5
...
Remove test/integration/* from hack/.golint_failures
2019-03-01 14:08:33 -08:00
Kubernetes Prow Robot
8acb522c03
Merge pull request #74488 from xichengliudui/fixshellcheck19022502
...
fix shellcheck in test/e2e_node/jenkins/...
2019-03-01 12:49:08 -08:00
Thomas Runyon
1e44e33517
pulled kubeadm tests out of runTests to run before tests in test/cmd
...
Added timeout for https://github.com/kubernetes/kubeadm/issues/1430
2019-03-01 12:17:25 -05:00
danielqsj
696c98a5e6
fix golint failures for metrics api
2019-03-01 17:36:20 +08:00
Eric Walker
75df4dc04c
Remove test/integration/* from hack/.golint_failures
2019-02-28 19:52:39 -07:00
Kubernetes Prow Robot
343bb4bd6b
Merge pull request #74561 from moshe010/start_kube_scheduler
...
Move start kubescheduler to it own function
2019-02-28 05:07:37 -08:00
Kubernetes Prow Robot
02b8056efb
Merge pull request #73288 from wangzhen127/npd-config
...
Decouple node-problem-detector release from kubernetes
2019-02-28 00:27:25 -08:00
SataQiu
11451bbb59
fix golint failures in staging/src/k8s.io/apiserver/pkg/storage/errors, staging/src/k8s.io/apiserver/pkg/storage/etcd
2019-02-28 15:51:05 +08:00
danielqsj
cee02e62b7
Fix golint failures for e2e/windows
2019-02-28 15:48:48 +08:00
Kubernetes Prow Robot
6af2e9afea
Merge pull request #74591 from xichengliudui/fixgolint190226
...
fix shellcheck in test/image/...
2019-02-27 20:39:25 -08:00
SataQiu
c0a0471b3b
fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
2019-02-28 12:29:22 +08:00
Kubernetes Prow Robot
d58ff3bfc0
Merge pull request #74176 from dims/containerized-kubelet-is-being-deprecated
...
Remove support for containerized-kubelet in local-up-cluster.sh
2019-02-27 14:40:06 -08:00
Zhen Wang
6df207bdaa
allows configuring NPD image version in node e2e test and fix the test
2019-02-26 21:29:50 -08:00
Kubernetes Prow Robot
81e6407393
Merge pull request #74140 from Liujingfang1/kflag
...
add -k flag in cli-runtime and kubectl to process kustomization directories
2019-02-26 19:40:16 -08:00
Kubernetes Prow Robot
5ebdf3e3f2
Merge pull request #74574 from SataQiu/fix-golint-20190226
...
fix some golint failures in pkg/registry/...
2019-02-26 18:12:19 -08:00
Kubernetes Prow Robot
493b261057
Merge pull request #74586 from danielqsj/patch3
...
fix golint failures for test/e2e/cloud|kubectl|servicecatalog
2019-02-26 14:08:16 -08:00
Kubernetes Prow Robot
26f90e850d
Merge pull request #74540 from oomichi/golint-e2e-framework-ingress
...
Fix golint under test/e2e/framework/ingress
2019-02-26 14:08:06 -08:00
Kubernetes Prow Robot
0ecba229aa
Merge pull request #74512 from danielqsj/ui
...
fix golint failures for test/e2e/ui
2019-02-26 14:07:54 -08:00
SataQiu
9e4c8950be
fix some golint failures in pkg/registry/...
2019-02-26 22:36:52 +08:00
danielqsj
8911a2ddbb
fix golint failures for test/e2e/kubectl
2019-02-26 18:27:01 +08:00
danielqsj
9ea1b3d86d
fix golint failures for test/e2e/servicecatalog
2019-02-26 18:25:23 +08:00
danielqsj
84aeafee7b
fix golint failures for test/e2e/cloud
2019-02-26 18:25:23 +08:00
SataQiu
f8c4aba0cb
fix some golint failures for plugin/pkg/admission/...
2019-02-26 17:12:40 +08:00
Kubernetes Prow Robot
736baa5e33
Merge pull request #73593 from danielqsj/etcd
...
fix shellcheck failure in etcd shell
2019-02-25 23:11:50 -08:00
danielqsj
1ce7b0b2fa
fix golint failures for test/e2e/ui
2019-02-26 14:03:34 +08:00
xichengliudui
4b38978329
fix shellcheck in test/e2e_node/jenkins/...
...
update pull request
2019-02-26 01:01:48 -05:00
Kubernetes Prow Robot
33a0afafe7
Merge pull request #74508 from danielqsj/uapps
...
Fix golint failures for e2e/upgrades/...
2019-02-25 21:48:42 -08:00
Kubernetes Prow Robot
5a2d587ac4
Merge pull request #74505 from SataQiu/fix-golint-20190225
...
fix golint failures for pkg/apis/...
2019-02-25 20:28:30 -08:00
Kubernetes Prow Robot
272d78f1d9
Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server
...
Fix lint on pkg/kubelet/server/...
2019-02-25 20:27:48 -08:00
Moshe Levi
b9fb656546
Move start kubescheduler to it own function
...
Currently the kubescheduler starts in the start_kubeproxy
This change move it to ir own function start_kubescheduler
Change-Id: Iff93114d4becabe4b6b937c5077821e092abffd3
Signed-off-by: Moshe Levi <moshele@mellanox.com>
2019-02-26 04:30:11 +02:00
Kubernetes Prow Robot
1595089ec5
Merge pull request #74453 from xichengliudui/fixgolintfailures1902
...
fixgo lint failures test/integration/...
2019-02-25 17:25:34 -08:00
Kubernetes Prow Robot
483d19ccc4
Merge pull request #74420 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-for-more-scripts-in-hack
...
Fix shellcheck for more scripts in hack
2019-02-25 17:25:23 -08:00
Kubernetes Prow Robot
0ff7e463ee
Merge pull request #73746 from mrbobbytables/kubemark-shellcheck
...
Fix shellcheck lint errors in Kubemark scripts
2019-02-25 17:25:13 -08:00
Jingfang Liu
beacc87ebf
add cmdline tests for -k
2019-02-25 16:31:03 -08:00
Jeff Grafton
392ad719eb
add comments
2019-02-25 15:34:09 -08:00
Jeff Grafton
883b6cff0d
Generate a repos_generated.bzl file with all staging repos
...
Additionally, ensure that every staging repo has a BUILD file at its
root.
Also, remove a gazelle directive we no longer need.
2019-02-25 15:33:46 -08:00
Kubernetes Prow Robot
3814176d42
Merge pull request #74455 from SataQiu/fix-shell-2019022302
...
Fix shellcheck lint errors in cluster and hack scripts
2019-02-25 15:15:19 -08:00
Kubernetes Prow Robot
a778f409ba
Merge pull request #74385 from SataQiu/fix-shell-20190222
...
Fix some shellcheck failures in hack
2019-02-25 13:54:32 -08:00
Kubernetes Prow Robot
0813567660
Merge pull request #74349 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-in-hack
...
Fix shellcheck for hack/verify-generated-*
2019-02-25 13:54:10 -08:00
Kenichi Omichi
215dee7dd2
Fix golint under test/e2e/framework/ingress
2019-02-25 20:55:03 +00:00
Bob Killen
e137f4702a
Fix shellcheck lint errors in test/kubemark/stop-kubemark.sh
2019-02-25 15:21:32 -05:00
Bob Killen
b8aae458a1
Fix shellcheck lint errors in test/kubemark/start-kubemark.sh
2019-02-25 15:21:31 -05:00
Bob Killen
46333a01b4
Fix shellcheck lint errors in test/kubemark/run-e2e-tests.sh
2019-02-25 15:21:31 -05:00
Bob Killen
adf4bf1741
Fix shellcheck lint errors in test/kubemark/resources/start-kubemark-master.sh
2019-02-25 15:21:31 -05:00
Bob Killen
f72ac1f5b7
Fix shellcheck lint errors in test/kubemark/master-log-dump.sh
2019-02-25 15:21:31 -05:00
Bob Killen
cb59cb33ff
Fix shellcheck lint errors in test/kubemark/iks/util.sh
2019-02-25 15:21:30 -05:00
Bob Killen
e3e2a96521
Fix shellcheck lint errors in test/kubemark/iks/startup.sh
2019-02-25 15:21:30 -05:00
Bob Killen
6310305d3b
Fix shellcheck lint errors in test/kubemark/iks/shutdown.sh
2019-02-25 15:21:30 -05:00
Bob Killen
186b83fe5b
Fix shellcheck lint errors in test/kubemark/gce/util.sh
2019-02-25 15:21:30 -05:00
Bob Killen
5f4b919887
Fix shellcheck lint errors in test/kubemark/common/util.sh
2019-02-25 15:21:29 -05:00
Bob Killen
9a4f4878f5
Fix shellcheck lint errors in cluster/kubemark/util.sh
2019-02-25 15:21:29 -05:00
Bob Killen
9a58913e8f
Fix shellcheck lint errors in cluster/kubemark/iks/config-default.sh
2019-02-25 15:21:25 -05:00
Bob Killen
ce4c85e3fd
Fix shellcheck lint errors in cluster/kubemark/gce/config-default.sh
2019-02-25 14:55:01 -05:00
Kubernetes Prow Robot
35a258d640
Merge pull request #73272 from danielqsj/juju
...
fix shellcheck in cluster/juju
2019-02-25 11:33:21 -08:00
Kubernetes Prow Robot
f288678cfa
Merge pull request #73261 from danielqsj/local
...
fix shellcheck in cluster/local
2019-02-25 11:33:11 -08:00
Davanum Srinivas
5d13f6f776
Remove support for containerized-kubelet in local-up-cluster.sh
...
Change-Id: I3435b02fbe052a88f6b88d5517de2d68ff636a66
2019-02-25 08:53:14 -05:00
SataQiu
09ba08f8f4
fix some golint failures for pkg/apis/...
2019-02-25 18:06:08 +08:00
SataQiu
7181c44230
fix some golint failures for pkg/cloudprovider/providers/vsphere/vclib and pkg/kubelet/apis/...
2019-02-25 18:01:41 +08:00
danielqsj
6322025d5c
fix golint failures for test/e2e/upgrades
2019-02-25 16:36:26 +08:00
danielqsj
7c8498ab03
fix golint failures for test/e2e/upgrades/storage
2019-02-25 15:41:31 +08:00
danielqsj
8916ccabaf
fix golint failures for test/e2e/upgrades/apps
2019-02-25 13:32:15 +08:00
mattjmcnaughton
b4d086f914
Fix shellcheck for hack/verify-generated-*
...
All of the `hack/verify-generated-*` files now pass shellcheck and are
removed from `hack/.shellcheck_failures`.
2019-02-24 23:50:59 -05:00
mattjmcnaughton
57c51c741d
Fix shellcheck for more scripts in hack
...
Making more of the scripts in hack pass the shellcheck linter.
2019-02-24 23:48:21 -05:00
SataQiu
d357bcd2cd
fix some shellcheck failures in hack
2019-02-25 11:38:56 +08:00
danielqsj
7e655e8666
fix shellcheck in cluster/juju
2019-02-24 20:40:59 +08:00
danielqsj
e698682a0e
change a way to pass SC2164 in etcd.sh
2019-02-24 20:26:59 +08:00
danielqsj
c215966d22
fix shellcheck failure in etcd shell
2019-02-24 20:19:50 +08:00
SataQiu
9cda80e836
fix shellcheck lint errors in cluster and hack scripts
2019-02-24 11:15:35 +08:00
Kubernetes Prow Robot
139a13d312
Merge pull request #74269 from moshe010/kubelet_gen_cert
...
Move kubelet cert generation when starting kubelet
2019-02-23 18:41:10 -08:00
Kubernetes Prow Robot
1cf8001e53
Merge pull request #74449 from xichengliudui/fix190223
...
make more of the shell pass lints
2019-02-23 12:52:34 -08:00
Kubernetes Prow Robot
6a29f8ca5f
Merge pull request #74451 from xichengliudui/fixshellcheckout190223
...
fix shellcheck in hack/...
2019-02-23 10:23:15 -08:00
Kubernetes Prow Robot
0133d14170
Merge pull request #72939 from runyontr/test-cmd-what
...
Test cmd what
2019-02-23 02:54:36 -08:00
Kubernetes Prow Robot
8993fbc543
Merge pull request #74328 from daixiang0/delete-blank
...
delete all duplicate empty blanks
2019-02-23 01:43:58 -08:00
Kubernetes Prow Robot
795ae35201
Merge pull request #74318 from cblecker/fix-swagger
...
Fix verify-generated-swagger-docs script
2019-02-23 01:43:48 -08:00
Xiang Dai
36065c6dd7
delete all duplicate empty blanks
...
Signed-off-by: Xiang Dai <764524258@qq.com>
2019-02-23 10:28:04 +08:00
Kubernetes Prow Robot
743f864310
Merge pull request #73819 from coffeepac/move-fluentd-es-images
...
Move fluentd es images
2019-02-22 17:58:12 -08:00
Kubernetes Prow Robot
e2b74ad91d
Merge pull request #73864 from oomichi/cleanup-array_contains
...
Use kube::util::array_contains() in hack
2019-02-22 16:15:10 -08:00
Kubernetes Prow Robot
3afa003126
Merge pull request #73555 from bsalamat/priority_to_ga
...
Graduate PriorityClass API to GA
2019-02-22 16:14:49 -08:00
Bobby (Babak) Salamat
453498fe2c
Graduate PriorityClass to GA
2019-02-22 10:51:13 -08:00
Patrick Christopher
1bd45ba6eb
review updates
2019-02-22 10:00:10 -08:00
danielqsj
998147de59
fix shellcheck in pkg/kubectl/cmd/edit/testdata/record_testcase.sh
2019-02-22 15:10:38 +08:00
danielqsj
0e78dd2d17
fix shellcheck in pkg/util/verify-util-pkg.sh
2019-02-22 15:10:16 +08:00
danielqsj
5733241f7a
fix shellcheck in plugin/pkg/admission/imagepolicy/gencerts.sh
2019-02-22 15:10:06 +08:00
Kubernetes Prow Robot
651faf2e0d
Merge pull request #74250 from SataQiu/fix-golint-20190219
...
Fix golint failures on pkg/kubectl/cmd/completion, pkg/kubectl/cmd/cp, pkg/kubectl/cmd/edit
2019-02-21 22:17:36 -08:00
Kubernetes Prow Robot
125dc6c8ea
Merge pull request #74187 from xichengliudui/fixgolint0218
...
Fix shellcheck lint errors in cluster/addons/fluentd-elasticsearch/fl……uentd-es-image/run.sh
2019-02-21 20:51:13 -08:00
Kubernetes Prow Robot
4f4695fefe
Merge pull request #73214 from danielqsj/metrics
...
fix shellcheck in k8s.io/metrics
2019-02-21 19:16:31 -08:00
Kubernetes Prow Robot
4763720dc1
Merge pull request #74338 from BenTheElder/testcmdshellcheck
...
make test/cmd/delete.sh pass shellcheck
2019-02-21 12:26:57 -08:00
Thomas Runyon
f97170ea38
Merge remote-tracking branch 'upstream/master' into test-cmd-what
2019-02-21 11:35:23 -05:00
Aldo Culquicondor
e61cd68bf3
Fix lint on pkg/kubelet/server/...
2019-02-21 10:31:41 -05:00
Kubernetes Prow Robot
59beb8c36b
Merge pull request #74299 from SataQiu/fix-shell-20190220
...
Fix some shellcheck failures in hack
2019-02-21 02:20:05 -08:00
Kubernetes Prow Robot
7d75b73e1d
Merge pull request #74057 from liggitt/ingress-network-v1beta1
...
Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1
2019-02-21 01:07:48 -08:00
Benjamin Elder
da859ae734
make test/cmd/delete.sh pass shellcheck
2019-02-21 00:45:37 -08:00