Commit Graph

68 Commits (cacda7bc7aa60d88b217daa5482f550044bb3021)

Author SHA1 Message Date
Clayton Coleman 2fd38a7dc0 Break kubectl from assuming details of codecs
Most of the logic related to type and kind retrieval belongs in the
codec, not in the various classes. Make it explicit that the codec
should handle these details.

Factory now returns a universal Decoder and a JSONEncoder to assist code
in kubectl that needs to specifically deal with JSON serialization
(apply, merge, patch, edit, jsonpath). Add comments to indicate the
serialization is explicit in those places. These methods decode to
internal and encode to the preferred API version as previous, although
in the future they may be changed.

React to removing Codec from version interfaces and RESTMapping by
passing it in to all the places that it is needed.
2016-01-22 13:27:26 -05:00
Tim Hockin 5002b784f9 Clarify --external-ip in kubectl expose docs
Also fix a couple minor punctuation issues.
2016-01-10 23:29:57 -08:00
Michail Kargakis 71934b7643 kubectl: Validate flag usage against generators
This commit moves the generators into separate buckets and creates
separate calls for each one group. This helps in providing just the
necessary generators to each generator command.

Validation of flags against generators is also added so that flags
that are not meant to be used with a specific generator will result
in error.
2015-12-18 15:09:53 +01:00
deads2k 66eecb963a update more kubectl bits for groupversion 2015-12-07 09:01:44 -05:00
deads2k 303bcad398 use groupversion in RESTMapping 2015-11-16 09:22:11 -05:00
Janet Kuo a6a64820d7 Make generation of the apply annotation optional 2015-11-06 15:08:50 -08:00
Jordan Liggitt b58e62e7d4 Pass runtime.Object to Helper.Create/Replace 2015-10-28 12:43:21 -04:00
kargakis 7d0e691520 expose: Enable exposing multiport objects
The generated service will inherit all the ports from the exposed object.
2015-10-19 11:25:14 +02:00
kargakis 4b23bf602d expose: Minor cleanup 2015-10-10 16:16:41 +02:00
kargakis 083c5bebbd expose: --dry-run should dump the object
Also make some tests use --dry-run and compare generated objects
against expected
2015-10-10 16:15:17 +02:00
jackgr ef3f64612e Add calls to set annotation for kubectl apply 2015-10-07 17:15:56 -07:00
kargakis 989806d9ec expose: Truncate service names
In case the generated service inherits the exposed object's name (the user didn't specify
a name via --name), truncate it up to the maximum length for a valid service name
2015-10-05 10:39:42 +02:00
feihujiang 98689a99ec Limit the type for kubectl expose command 2015-09-15 11:17:04 +08:00
Jeff Lowdermilk 0898ce852d Merge pull request #13756 from kargakis/make-external-svcs-exposable
expose: Avoid selector resolution if a selector is not needed
2015-09-14 16:01:55 -07:00
k8s-merge-robot 96df310729 Merge pull request #13783 from feihujiang/changeExposePortOperationToNoRequired
Auto commit by PR queue bot
2015-09-12 18:54:34 -07:00
Abhishek Shah 44ce4aa423 Create a LB for a K8S with the LB-IP provided by user. 2015-09-10 21:05:06 -07:00
feihujiang 714a042ce4 Change Expose Command's port operation to no required 2015-09-11 11:37:55 +08:00
kargakis c9268e1faf expose: Avoid selector resolution if a selector is not needed 2015-09-09 21:30:23 +02:00
hurf 8efc62bcce Simplify default output of "expose" command
Use simple output string such as "rc nginx exposed" to show the
result. Users can still use options like "-o yaml" to view detailed
result.

IP will be printed with detailed result now.
2015-09-07 15:17:17 +08:00
feihujiang 0427711c42 Fixes upper case letters in kubectl examples 2015-09-03 12:00:21 +08:00
Abhi Shah 642ebb4994 Merge pull request #13099 from JanetKuo/kubectl-expose-deprecate-create-external-load-balancer
Deprecated kubectl flag "create-external-load-balancer"
2015-09-02 15:16:08 -07:00
Daniel Smith 10efd9806a Merge pull request #13227 from kargakis/fix-exposing-from-file
expose: Don't query the server for input objects
2015-09-01 12:23:01 -07:00
deads2k f1b81ff678 bind filenames var instead of looking up 2015-09-01 08:35:57 -04:00
Janet Kuo 18e87724c5 Deprecated kubectl flag "create-external-load-balancer" 2015-08-28 00:54:33 -07:00
kargakis e86bb1aeca expose: Don't query the server for input objects
Signed-off-by: kargakis <mkargaki@redhat.com>
2015-08-27 15:52:22 +03:00
Abhishek Shah b6b8e99393 External IPs support. 2015-08-20 16:10:01 -07:00
Brendan Burns 586931fe16 Add optional arguments to kubectl run ... 2015-08-13 09:41:51 -07:00
Peeyush Agarwal 05e069d038 Use bash comments in kubectl examples
Comments in kubectl examples should use bash comments, not Go comments.
So, replaces // by # for example strings.
2015-08-12 19:56:23 +00:00
feihujiang c0b2098844 Kubectl expose command accepts a filename param 2015-08-12 16:16:37 +08:00
Kris Rousey 565189f5b8 Correcting all go vet errors 2015-08-11 13:55:37 -07:00
Mike Danese 8e33cbfa28 rewrite go imports 2015-08-05 17:30:03 -07:00
hurf 33fb6170f9 Use TYPE instead of RESOURCE in help string
For commands in kubectl, use TYPE in help string.
2015-08-05 16:34:48 +08:00
Brendan Burns c9bc1456ff Add session affinity flags to kubectl expose 2015-07-31 10:34:52 -07:00
nikhiljindal c849730116 Fixing the error message 2015-07-16 23:33:16 -07:00
nikhiljindal 496f30a92f Introduce a new service generator that leaves service port unnamed 2015-07-16 20:40:40 -07:00
Brendan Burns a8f02e5472 Automatically open a firewall when creating a GCE load balancer. 2015-07-10 14:35:29 -07:00
Kris Rousey ffa764d60b Unify command line namespace resolution
This change allows the namespace in kubeconfig to be overridden by
specifying the namespace in the spec file. If namespace is explicitly
provided in the command line flags and the spec file has a different
namespace, this will cause an error.
2015-07-01 12:59:17 -07:00
Brendan Burns 380790a8e2 Add messages to indicate that opening an external firewall may be necessary. 2015-06-04 22:31:52 -07:00
kargakis 0fba4820f5 expose: Better error formatting and generic flag message
Re error formatting:
$ osc expose svc frontend --port=5432 --generator='service/v2' --name=test

Before:
error: generator %!!(MISSING)q(<nil>) not found.
see 'osc expose -h' for help.

Now:
error: generator "services/v2" not found.
see 'openshift cli expose -h' for help.
2015-06-02 13:06:21 +02:00
kargakis 6c85040cef expose: Use separate parameters for default and custom name 2015-05-28 11:03:16 +02:00
Justin Santa Barbara 973c2e4819 Add Type to ServiceSpec: ClusterIP or LoadBalancer 2015-05-22 19:14:21 -04:00
kargakis 30958f892d expose: Use resource builder
Plus:
* Rename flag --service-name to --name
* Some refactoring
2015-05-20 23:55:07 +02:00
kargakis ac652d16e6 expose: Re-use labels in case none was specified 2015-05-15 11:54:41 +02:00
kargakis 93dc839b19 Load input object for increased safety 2015-05-08 03:17:54 +02:00
kargakis c9e79a3c28 Setup generators in factory 2015-05-05 12:00:13 +02:00
kargakis fa42901798 expose: Create objects in a generic way 2015-05-04 14:21:24 +02:00
Filip Grzadkowski be2b2466f3 Merge pull request #7076 from eparis/bash-5-kubectl-required-flags
annotate required flags for bash_completions
2015-05-04 13:26:11 +02:00
Eric Paris 6b3a6e6b98 Make copyright ownership statement generic
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.
2015-05-01 17:49:56 -04:00
Rohit Jnagal 0a8b136ee6 Fix typo in 'kubectl expose' examples. 2015-04-30 06:02:16 +00:00
Eric Paris 0620940d26 annotate required flags for bash_completions
some commands require that certain flags be set in order to function.
Annotate those flags so the bash completions will suggest to the user
that they be set.
2015-04-20 18:33:00 -04:00