Commit Graph

71 Commits (c582a37cae02b4d1a850e6668ea8ea0a81dcd204)

Author SHA1 Message Date
Clayton Coleman 3a29e3971b Improve terminal reuse and attach
Currently attach and the editor do not share the same logic for saving
and restoring the terminal, and are not suitable for nesting (when the
caller wants to create something, attach, and then delete something when
the attach is over).  This commit moves the interrupt protection logic
to a util package and supports nesting interrupt handlers.
2016-03-21 23:59:58 -04:00
Kris e664ef922f Move restclient to its own package 2016-02-29 12:05:13 -08:00
AdoHe 9cc668f7c6 update commented examples just remove $ 2016-02-29 09:41:09 -05:00
Clayton Coleman 8692d260f8 Use Parameter codec in request.VersionedParams() 2016-01-30 14:14:20 -05:00
feihujiang 3a3421b742 Print how to reattch to seesion when session ends 2015-12-11 17:00:56 +08:00
hurf 27d6b58ba5 fix a nit in long description of attach command
remove an extra 'a'
2015-11-25 18:57:03 +08:00
Fabiano Franz ab455784f5 kubectl attach only takes one argument 2015-11-17 23:16:02 -02:00
feihujiang dfdd9b7558 Print clue for getting command prompt 2015-11-06 17:09:12 +08:00
hurf a15998f46c Aggregate errors while validating attach options
Return all errors at a time while validating attach options.
2015-11-05 10:39:32 +08:00
Fabiano Franz c60f19a1f8 Attach must only allow a tty when container supports it 2015-11-02 09:56:58 -05:00
Clayton Coleman 7f6f85bd7b Fix attach, which was broken during the refactor
The new e2e test catches the break in attach (no e2e test
exposed this codepath before).
2015-10-16 20:33:51 -04:00
Clayton Coleman 3f1b18fbba Refactor exec to make attach useful without a client.Config
The current executor structure is too dependent on client.Request
and client.Config. In order to do an attach from the server, it needs
to be possible to create an Executor from crypto/tls#TLSConfig and to
bypassing having a client.Request.

Changes:

* remotecommand.spdyExecutor - handles upgrading a request to SPDY and getting a connection
* remotecommand.NewAttach / New - moved to exec / portforward / attach since they handle requests
* Remove request.Upgrade() - it's too coupled to SPDY, and can live with the spdyExecutor
* Add request.VersionedParams(runtime.Object, runtime.ObjectConvertor) to handle object -> query transform
2015-10-09 14:36:46 -04:00
k8s-merge-robot 2516086771 Merge pull request #14764 from timstclair/kubectl
Auto commit by PR queue bot
2015-10-01 17:10:10 -07:00
Tim St. Clair 4dc9df91d8 Fix race condition in kubectl run --attach 2015-09-29 15:02:38 -07:00
feihujiang e31bc89232 Fix minor bugs in kubectl command 2015-09-28 13:58:31 +08:00
feihujiang 0427711c42 Fixes upper case letters in kubectl examples 2015-09-03 12:00:21 +08:00
Kris Rousey ae6c64d9bb Moving everyone to unversioned client 2015-08-18 10:23:03 -07:00
Peeyush Agarwal 05e069d038 Use bash comments in kubectl examples
Comments in kubectl examples should use bash comments, not Go comments.
So, replaces // by # for example strings.
2015-08-12 19:56:23 +00:00
Mike Danese 17defc7383 run gofmt on everything we touched 2015-08-05 17:52:56 -07:00
Mike Danese 8e33cbfa28 rewrite go imports 2015-08-05 17:30:03 -07:00
Brendan Burns 97cb1cd071 Add support for attach to kubectl 2015-07-30 12:56:18 -07:00