github/k3s - k3s - https://git.xinac.net

Commit Graph

Author	SHA1	Message	Date
Jose A. Rivera	13462bf341	PVC Protection: Wait for Pod delete Currently, the PVC protection controller will remove its finalizer when all Pods using a PVC reach at least a Terminating state. However, certain volumes cannot be guaranteed to be umounted until a Pod is deleted. Only Pods not in the current pods list can be considered deleted, so we're removing the exception to not check Terminating Pods. Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>	2018-08-13 13:57:36 -05:00
Pavel Pospisil	d3ddf7eb8b	Always Start pvc-protection-controller and pv-protection-controller After K8s 1.10 is upgraded to K8s 1.11 finalizer [kubernetes.io/pvc-protection] is added to PVCs because StorageObjectInUseProtection feature will be GA in K8s 1.11. However, when K8s 1.11 is downgraded to K8s 1.10 and the StorageObjectInUseProtection feature is disabled the finalizers remain in the PVCs and as pvc-protection-controller is not started in K8s 1.10 finalizers are not removed automatically from deleted PVCs and that's why deleted PVC are not removed from the system but remain in Terminating phase. The same applies to pv-protection-controller and [kubernetes.io/pvc-protection] finalizer in PVs. That's why pvc-protection-controller is always started because the pvc-protection-controller removes finalizers from PVCs automatically when a PVC is not in active use by a pod. Also the pv-protection-controller is always started to remove finalizers from PVs automatically when a PV is not Bound to a PVC. Related issue: https://github.com/kubernetes/kubernetes/issues/60764	2018-04-20 19:54:50 +02:00
jsafrane	4ad4ee3153	Added PVC Protection Controller This controller removes protection finalizer from PVCs that are being deleted and are not referenced by any pod.	2017-11-23 11:46:34 +01:00

Author

SHA1

Message

Date

Jose A. Rivera

13462bf341

PVC Protection: Wait for Pod delete

Currently, the PVC protection controller will remove its finalizer when
all Pods using a PVC reach at least a Terminating state. However,
certain volumes cannot be guaranteed to be umounted until a Pod is
deleted. Only Pods not in the current pods list can be considered
deleted, so we're removing the exception to not check Terminating Pods.

Signed-off-by: Jose A. Rivera <jarrpa@redhat.com>

2018-08-13 13:57:36 -05:00

Pavel Pospisil

d3ddf7eb8b

Always Start pvc-protection-controller and pv-protection-controller

After K8s 1.10 is upgraded to K8s 1.11 finalizer [kubernetes.io/pvc-protection] is added to PVCs
because StorageObjectInUseProtection feature will be GA in K8s 1.11.
However, when K8s 1.11 is downgraded to K8s 1.10 and the StorageObjectInUseProtection feature is disabled
the finalizers remain in the PVCs and as pvc-protection-controller is not started in K8s 1.10 finalizers
are not removed automatically from deleted PVCs and that's why deleted PVC are not removed from the system
but remain in Terminating phase.
The same applies to pv-protection-controller and [kubernetes.io/pvc-protection] finalizer in PVs.

That's why pvc-protection-controller is always started because the pvc-protection-controller removes finalizers
from PVCs automatically when a PVC is not in active use by a pod.
Also the pv-protection-controller is always started to remove finalizers from PVs automatically when a PV is not
Bound to a PVC.

Related issue: https://github.com/kubernetes/kubernetes/issues/60764

2018-04-20 19:54:50 +02:00

jsafrane

4ad4ee3153

Added PVC Protection Controller

This controller removes protection finalizer from PVCs that are being
deleted and are not referenced by any pod.

2017-11-23 11:46:34 +01:00

3 Commits (c582a37cae02b4d1a850e6668ea8ea0a81dcd204)