Commit Graph

16 Commits (b1357da473ff2f50857e29c3c5ab993fb1454322)

Author SHA1 Message Date
Cheng Xing 6dbfea1b80 Adding dummy and dummy-attachable example Flexvolume drivers; adding DaemonSet deployment example 2018-02-26 10:30:30 -08:00
Tim(Xiaoyu) Zhang 623d0efb6d Reduce one time url direction
Reduce one time url direction
2017-08-18 11:09:11 +08:00
Kubernetes Submit Queue 57414d9b9c Merge pull request #47066 from php-coder/improve_nfs_flex_volume_script
Automatic merge from submit-queue

examples/volumes/flexvolume/nfs: check for jq and simplify quoting

**What this PR does / why we need it**:

This PR improves error reporting of the nfs flex plugin script. Before it output non-JSON error, when `jq` wasn't installed on the server:
```
$ /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s~nfs/nfs getvolumename test
/usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s~nfs/nfs: line 87: jq: command not found
/usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s~nfs/nfs: line 88: jq: command not found
{"status": "Success", "volumeName": "/"}
```
K8s fails to unmarshal such output to show an error in the logs:
>E0606 19:32:30.196262   25700 driver-call.go:212] Failed to unmarshal output for command: getvolumename, output: "/usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s\~nfs/nfs: line 87: jq: command not found\n/usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s\~nfs/nfs: line 88: jq: command not found\n{\"status\": \"Success\", \"volumeName\": \"/\"}", error: invalid character '/' looking for beginning of value

After  this change:
```sh
$ /usr/libexec/kubernetes/kubelet-plugins/volume/exec/k8s~nfs/nfs getvolumename test
{ "status": "Failure", "message": "'jq' binary not found. Please install jq package before using this driver"}
```
and
> E0606 19:52:07.915594   25700 driver-call.go:219] getvolumename command failed, status: Failure, reason: 'jq' binary not found. Please install jq package before using this driver

Also this PR improves quoting a bit by using single quotes where it possible.

**Release note**:
```release-note
NONE
```

CC @mfojtik
2017-07-14 12:42:02 -07:00
Sebastien Goasguen b0bc271ef3 add redirect notice in all readme files 2017-07-14 17:18:01 +02:00
Slava Semushin 7d664960df examples/volumes/flexvolume/nfs: check for jq and simplify quoting. 2017-07-07 19:54:12 +02:00
Chakravarthy Nelluri 894b9b2add Remove controller node plugin driver dependency for non-attachable flex volume drivers (Ex: NFS). 2017-06-17 14:12:43 -04:00
Chakravarthy Nelluri 7885aaf689 Remove broken getvolumename and pass PV or volume name to attach call 2017-06-13 00:32:38 -04:00
Chakravarthy Nelluri 399fe519a1 Move documentation to community 1.6 2017-03-22 14:55:40 -04:00
Chakravarthy Nelluri ef35d6a726 Address review comments from @saad-ali 2017-03-20 14:02:39 -04:00
Chakravarthy Nelluri 522cf1876e Update flex volume 1.6 documentation. 2017-03-17 16:46:46 -04:00
Chakravarthy Nelluri 0d2af70e95 Add support for attacher/detacher interface in Flex volume 2017-02-24 20:18:06 -05:00
Tim Hockin b0fa2056a6 Remove 'this is HEAD' warning on docs 2016-10-26 00:06:59 +02:00
David McMahon 385fb81407 Update the latestReleaseBranch to release-1.4 in the munger. 2016-09-01 14:40:55 -07:00
Keegan Carruthers-Smith 70a1536820 Fix markdown of flexvolume lvm example link 2016-07-25 22:59:32 +02:00
joe2far 88b6d4ad36 Fix broken warning image link in docs 2016-07-15 10:44:58 +01:00
Cindy Wang fedc513658 Consolidated examples into storage/ and volume/ folders
Search and replace for references to moved examples

Reverted find and replace paths on auto gen docs

Reverting changes to changelog

Fix bugs in test-cmd.sh

Fixed path in examples README

ran update-all successfully

Updated verify-flags exceptions to include renamed files
2016-07-08 13:34:32 -07:00