The codec factory should support two distinct interfaces - negotiating
for a serializer with a client, vs reading or writing data to a storage
form (etcd, disk, etc). Make the EncodeForVersion and DecodeToVersion
methods only take Encoder and Decoder, and slight refactoring elsewhere.
In the storage factory, use a content type to control what serializer to
pick, and use the universal deserializer. This ensures that storage can
read JSON (which might be from older objects) while only writing
protobuf. Add exceptions for those resources that may not be able to
write to protobuf (specifically third party resources, but potentially
others in the future).
Combine the fields that will be used for content transformation
(content-type, codec, and group version) into a single struct in client,
and then pass that struct into the rest client and request. Set the
content-type when sending requests to the server, and accept the content
type as primary.
Will form the foundation for content-negotiation via the client.
If not, using `go test -count=n` would make them pile up and ultimately
get to the limit of open files:
client_test.go:522: expected an error, got Get http://127.0.0.1:46070/api: dial tcp 127.0.0.1:46070: socket: too many open files
Steps to reproduce (no longer fails):
godep go test -short -run '^$' -o test .
./test -test.run '^TestGetSwaggerSchema' -test.count 100
Note that this might not fail if your `ulimit -n` is not low enough.
I'm moving/deleting some tests to make an upcoming RESTClient refactor
PR cleaner.
- TestDoRequestBearer is redundant to
pkg/client/transport.TestBearerAuthRoundTripper
- Added a case to pkg/client/transport.TestBasicAuthRoundTripper to
cover what TestDoRequestWithoutPassword was testing
- Moved TestSetsCodec, TestRESTClientRequires,
TestValidateHostParameter to helper_test.go since they were really
testing helper functions and not the RESTClient directly.
- Modified TestValidateHostParameter during the moved to just use
DefaultServerURL instead of creating a client.